Makefile question

Ok, first of all here's my code:

Code:

---

CC = gcc
CFLAGS = -g

CFILES = main.c lex.yy.c y.tab.c util.c

OFILES = main.o lex.yy.o y.tab.o util.o

HFILES = y.tab.h globals.h util.h scan.h

compile: $(OFILES)
        $(CC) $(CFLAGS) $(OFILES) -lfl -o compile

y.tab.c : parse.y util.h scan.h
        yacc -v -d parse.y

lex.yy.c : scan.l y.tab.h globals.h
        flex scan.l

y.tab.h : parse.y util.h scan.h
        yacc -v -d parse.y

clean:
        /bin/rm -f compile lex.yy.c y.tab.c y.tab.h *.BAK *.o

---

I think there's something wrong as when I run make it can't found the function which is defined in util.c and global.h

The file scan.l is using an extern variable which is defined in the globals.h file, and I've already included globals.h on the header of scan.l.


Can you tell me what's wrong here?

Aww Equinox, sounds like a name from an Album of Eric Jordan, are u a fan?

Quote:

---

Originally Posted by AvaGodess

Aww Equinox, sounds like a name from an Album of Eric Jordan, are u a fan?

---

no I am not

If the function is in util.c, then you should probably compile util.c at some point along the way. (Including util.h as a requirement doesn't help -- you need util.o in your OFILES, I would guess.)

I don't see util.c / util.o listed anywhere, so how would it know to compile and link them?

okay, I already edited my first post and edited it also in my code, however it still fails.

Are your getting a compiler error or a linker error? In otherwords, are you not putting prototypes, or are your prototypes (or lack thereof) mismatching what the file actually contains?

Maybe post the log of make clean followed by make

here's a part of the error, mostly it's a linker error I think

Code:

---

/home/-/<stdout>:692: multiple definition of `yyin'
lex.yy.o:/home/-/lex.yy.c:692: first defined here
scan.o: In function `yylex':
/home/-/<stdout>:692: multiple definition of `yyout'
lex.yy.o:/-/lex.yy.c:692: first defined here
scan.o:(.data+0x0): multiple definition of `yylineno'
lex.yy.o:(.data+0x0): first defined here
scan.o: In function `yylex':
/home/-/<stdout>:704: multiple definition of `yy_flex_debug'
lex.yy.o:/home/-/lex.yy.c:704: first defined here
scan.o: In function `yylex':
/home/-/<stdout>:692: multiple definition of `yylex'
lex.yy.o:/home/herlamba/cs453/ass3/C-/lex.yy.c:692: first defined here
scan.o: In function `yy_create_buffer':
/home/-/<stdout>:1516: multiple definition of `yy_create_buffer'
lex.yy.o:/-/lex.yy.c:1516: first defined here
scan.o: In function `yyrestart':
/home/-/<stdout>:1454: multiple definition of `yyrestart'
lex.yy.o:/home/-/lex.yy.c:1454: first defined here
scan.o: In function `yyrealloc':

---

Code:

---

make clean
make all

---

I did make clean and make all, still the same thing

some additional info:

/home/-/parse.y:219: undefined reference to `newStmtNode'
/home/-/parse.y:220: undefined reference to `newStmtNode'
/home/-/parse.y:228: undefined reference to `newStmtNode'
/home/-/parse.y:233: undefined reference to `newStmtNode'
/home/-/parse.y:240: undefined reference to `newStmtNode'

where newStmtNode is a function in util.c and I already include util.h on the header of parse.y, why can't it find that function saying it's an undefined reference

Do your prototypes jive with how they are defined?

Quote:

---

Originally Posted by master5001

Do your prototypes jive with how they are defined?

---

What do you mean by prototypes jive?

here's the header of each file

scan.l:

Code:

---

#include "globals.h" 
#include "util.h" 
#include "y.tab.h"

---

util.c

Code:

---

#include "globals.h" 
#include "util.h" 
#include "y.tab.h"

---

parser.y

Code:

---

#include "globals.h" 
#include "util.h" 
#include "scan.h"

---

all the other .h file of course doesn't include anything

I mean do they match. Are you saying:

header.h

Code:

---

#ifndef MYHEADER
#define MYHEADER

int function(void);

#endif /* include once */

---

definition.c

Code:

---

/* Copyright (c) 2008. -EquinoX-
 * All rights reserved. Please don't steal my code!
 * Its all I really have :(
 */

int function(int x, int y)
{
  return x * y;
}

---

Quote:

---

Originally Posted by master5001

I mean do they match. Are you saying:

header.h

Code:

---

#ifndef MYHEADER
#define MYHEADER

int function(void);

#endif /* include once */

---

definition.c

Code:

---

/* Copyright (c) 2008. -EquinoX-
 * All rights reserved. Please don't steal my code!
 * Its all I really have :(
 */

int function(int x, int y)
{
  return x * y;
}

---

---

yes, something like that.. I have all the ifndef in every .h file

Something like that as in you defined your function one way, and prototyped it another, or something like that as in you just saw the pre-compiler directives and nodded and smiled?

Multiple definitions make it sound like you've got code in your header files.

I don't have any codes in my .h file all there is is just some definitions of structs and function header, please guys.. I really need to resolve this

So I'm afraid you're now going to have to convince us this is a makefile problem: can you compile this project manually without errors; and if so, what commands do you use to do so?

Did you use extern when declaring variables in your header files?