storage size of 'sin' isn't known

Hi,

i am writing my first program regarding sockets in C and i have this problem which i cannot unfortunately resolve...any ideas pls??

Storage size of 'sin' isn't known

Code:

---

#include <stdio.h>
#include <sys/types.h>
#include <sys/socket.h>
#include <string.h>

int main(){
       
        struct hostent *phe;
        struct sockaddr_in sin; //problem is here........
        char *host;
        int s, rc, type;

        host = "tombaker.cis.um.edu.mt";
        memset(&sin, 0, sizeof(sin));

        sin.sin_family = AF_INET;
        sin->sin_port = 7; //ECHO service
        sin.sin_addr = inet_makeaddr(
                        inet_network("193.188.43.36"),
                        inet_addr("193.188.43.36"));
        s= socket(PF_INET, SOCK_STREAM, 0);
        rc = connect(s, (struct sockaddr *)&sin, sizof(sin));
        if (rc != 0)
        printf("failed");
        else (printf("connected"));

}

---

You failed to include winsock2.h.
String literals should be const: http://cpwiki.sourceforge.net/Common...kes_and_errors
And just in you aren't aware, you can't assign strings in C that way. It will merely store the address of the string literal.

>>sin->sin_port = 7; //ECHO service
Doesn't work, because sin is a local variable, not a pointer.

Quote:

---

Originally Posted by Elysia

You failed to include winsock2.h.
String literals should be const: http://cpwiki.sourceforge.net/Common...kes_and_errors

---

They should be, but you often have no choice. There are a lot of bad APIs out there that take string parameters as simply "char *". So you either declare your own strings the same way, or you have to scatter zillions of cast-away-const all over the place.

The error of attempting to modify a string literal is becoming less and less dangerous, since more and more systems will throw a fault when you try to do so -- at least you'll find the problem and be able to correct it.

I had the same problem (Xubuntu-8.10 on i386), and i solved it with including one header file of those:

#include <netinet/in.h>

or

#include <arpa/inet.h>