Why am I getting segmentation fault on this?

Hi


I keep getting segmentation fault when the program gets to

Code:

---

c[i] = c[i + 1];

---

This is in another constructor, I have included the code and the output below, Please let me know if you know why I get segmentation fault when I use c[i] = c[i + 1]

Code:

---

#include <stdio.h>
#include <string.h>

class Account
{
char customer[251];
char accountNumber[16];
int balance;

public:
Account();
Account(char c[]);
};

int main()
{
Account test("    test");

return 0;
}

Account::Account()
{
strcpy(customer, ",,,;");
strcpy(accountNumber, "000000000000000");
balance = 0;
}

Account::Account(char c[])
{
 int i = 0;


//while loop removes the spaces in front of the string.
 while (c[i] == ' ' || c[i] == '\t' || c[i] == '\n')
 {
    printf("Loop started\n");
    c[i] = c[i + 1];
    i++;
 }

}

---

Output

Quote:

---

Loop started
Segmentation fault

---

Thank You

Because " test" is not a writable string. It's a string literal, and cannot be changed in memory.

I think this is a buffer overflow, too.

Code:

---

strcpy(accountNumber, "000000000000000");

---

BTW, isspace() from <cctypes> is your friend.

Quote:

---

Originally Posted by tabstop

Because " test" is not a writable string. It's a string literal, and cannot be changed in memory.

---

But I'm trying to move characters in "char c[]" which is a character array, would you clarify this?

I think now I understand, first I have to copy the string into the data member than I can move the characters in the string.

Also:
- Use std::strings, not character arrays. Otherwise, you will need to define a copy-constructor and assignment operator. Besides, it will make your life much easier. ;)
- Space-trimming is so common as to warrant being it's own function, outside of the class.

char[], when in a function parameter list, is only an alias for char*.