Printable View
Code intended to "zip" two strings together.
(Some input cases are not defined in this code.)
What are bugs in the code?. How to fix bugs?.
Code:
char *zip(char *a, char *b) {
char *result;
int len, i;
len = strlen(a);
result = malloc(2*len);
for(i = 0; i <= len; i++) {
result[2*i] = a[i];
result[2*i+1] = b[i];
}
return result;
}
Right, I should have recognised your behaviour earlier. Read our homework policy. You tell us what are the bugs with the code, and then we'll give you clues on how to fix them.
Please help me learn C.
And if we give you the correct answers, you will get the job? Or are you just hoping that me telling you that the malloc in the above is wrong, you will automatically be able to recognise such a scenario in another piece of code? Assuming of course that the malloc is actually wrong, which I'm not by any means saying it is, because I think you need to think about what the code does and see if you can figure out what is wrong.Quote:
Originally Posted by me001
Without knowing what the preconditions are (such as, do we know anything about the strings a and b that we can use in the code), I can spot at least 3 potential bugs.
--
Mats
From your questions, it is clear that you have not tried compiling C programs and running them recently. As such, I suggest that you go slow and practice with simpler programs first.
Even if we gave you the answers to these questions you've been posting and explained them to you, you would still not be able to fool an interviewer. Trust me, I am one.Quote:
Originally Posted by me001
Besides, what good is it for you to swindle your way into a job, that obviously requires you to know C, when you don't? Don't you think it'll become apparent very quickly, when you fail to write the simplest programs?
QuantumPete
i don't need helloworld to learn C. i code enough language....just forgot C...
i am going to interview somebody based on these questions...
No offence, but are you really the right person to interview someone for a job on a language that you have no idea about???Quote:
Originally Posted by me001
QuantumPete
these are random selected code for interview...we need to get answer and discuss...
Fortunately and unfortunately for you, we are helping you and sharing our knowledge. Eventually you will realize that the point of the question you posted (in an interview setting) is to see how well you understand code and spot common trouble areas. Asking us just sees how well we understand code and spot common trouble areas, which is not quite the same thing.Quote:
Originally Posted by me001
ok....
bug 1: both a and b need to be initialized as arrays rather than char
bug 2: len=strlen(a) will not work, since there is no string length for a initially
bug 3: one cannot assign malloc(2*len) to a char variable result.
is this right? can you pls correct me?
Quote:
Originally Posted by matsp
1. a and b are arraysQuote:
Originally Posted by me001
2. len=strlen(a) is probably not the right line of code for this situation, but not for the reaon you state, because the reason you state makes no sense
3. No one is trying to assign malloc(2*len) to a char variable (i.e., result is not a char variable).
I'm with QuantumPete on this: If you are going to ask technical programming questions, I'd say you need to have someone who understands the answers. Because if I answer your question, then you would not necessarily get the same answer from someone else, and someone third may spot something I hadn't thought of.
My first question if I was given that code would be "Are a and b strings always guaranteed to be the same length". If that's SUPPOSED to be the case, I'd still check that strlen(b) == len, and return some sort of error (NULL?) if it is not.
The code is broken in that it copies past the end of result's memory allocation, for sure. The allocation needs to be 2*(len+1).
You may want to check for NULL inputs, zero length inputs, and check if the memory allocation was successful or not.
--
Mats
It is true that a and b should point to characters that are part of an array of characters, but making a and b char* parameters is not a bug since arrays are converted to a pointer to their first element when passed as an argument to a function.Quote:
bug 1: both a and b need to be initialized as arrays rather than char
Again, this is not true, since strlen() operates on a string, that is true, but what is passed to it is a pointer to a character (usually the first) in the string.Quote:
bug 2: len=strlen(a) will not work, since there is no string length for a initially
That is true, but result is a char*, not a char.Quote:
bug 3: one cannot assign malloc(2*len) to a char variable result.
EDIT:
I think that 2*len+1 will suffice, assuming that both a and b are of length len.Quote:
Originally Posted by matsp