n-th element of the fibonacci sequence

n-th element of the fibonacci sequence.
What are the bugs in below code and how to fix?.

Code:

---

int fib(int n) {
        int tmp;
        if (n == 0) return 0;
        if (n == 1) return 1;
        tmp = fib(n-2);
        tmp += fib(n-1);
        return tmp;
}

---

What makes you think there are bugs in the first place?

That said, what happens if n is negative?

Thanks...Please help me debug this code..

what compiler i need to use?.

i put this code in miracle C compiler...gives me bug.

Quote:

---

No bug in this code?

---

Whether there is a bug or not depends on the specification. As it stands, it is correct, except that negative input would cause an error. Other possible issues include the fact that it is inefficient.

Quote:

---

i put this code in miracle C compiler...gives me bug.

---

I have heard that Miracle C is miraculously disastrous, so perhaps it would better if you switched compiler.

Quote:

---

what compiler i need to use?.

---

The GNU C compiler is available at zero price (use MinGW port for Windows), as is Microsoft Visual C++ 2008 Express (which comes with a C compiler).

Quote:

---

Originally Posted by me001

i put this code in miracle C compiler...gives me bug.

---

Perhaps Miracle C is the bug? I have no personal experience with this compiler, but there are plenty of free compilers that are BETTER from what I hear. Two of those would be gcc and Microsoft Visual Studio Express Edition.

--
Mats

Quote:

---

Originally Posted by me001

i put this code in miracle C compiler...gives me bug.

---

A compiler doesn't give you a bug, a compiler gives you an error or a warning and if you don't post them, we can't tell you what they mean...!

QuantumPete

Microsoft Visual Studio Express Edition is bulky compiler. i installed...this tool got a learning curve.

i want a light weight, less resource, free C compiler to learn C...

i am not going code C...just want to brush up my C skills.

Quote:

---

i want a light weight, less resource, free C compiler to learn C...

---

The MinGW port of GCC that I listed would be appropriate.

what version i need to download?

http://gcc.gnu.org/

For Windows, it would be here: MinGW. Use the installer package.

downloaded and installed.

how to start this tool and debug code?

Quote:

---

Originally Posted by me001

how to start this tool and debug code?

---

RTFM?

Quote:

---

how to start this tool and debug code?

---

You run it from the command prompt:

Code:

---

gcc -o program.exe sourcefile.c

---

then run program.exe

But yes, for more information, refer to the GCC website.

if n is negative code won't work.
Need to add check to see, n is positive beore passing n to this code.

what else i need to modify this code to work?

Quote:

---

Originally Posted by me001

if n is negative code won't work.

---

Correct. What about if n is very large?

QuantumPete

any nice free visual C compiler like Miracle C Compiler?

Quote:

---

any nice free visual C compiler like Miracle C Compiler?

---

Frankly, for Windows, Visual C++ is the best, but if you found that has a learning curve that you dislike, then any other IDE would have a learning curve that you do not want to overcome. That said, Code::Blocks would be your next best bet.

thanks Code::Blocks is excellent

If n is very large, code will run damm slow.
This is not efficient code.

Quote:

---

If n is very large, code will run damm slow.
This is not efficient code.

---

Yes, though there is also a limitation in terms of the range of int.

Quote:

---

Originally Posted by laserlight

Yes, though there is also a limitation in terms of the range of int.

---

That's more what I was thinking of. Also, since this is a recursive function, you'll break the stack with sufficiently large n values.

QuantumPete

To work nothing. It is fine

EDIT: Just for practice, try writing the code using fewer lines. Then try to write the algorithm using more variables instead of recursion