Printable View
Moin,
I want to get a NULL-Pointer instead of a bad_alloc exception in use with new.
But my Program crashes if I use "nothrow" !
What's wrong with my code ?
Please, could somebody give me a hint !?
Thanks.Code:#include <new>
// This works, but not with (std::nothrow) ..., why ???
pObj = new /*(std::nothrow)*/ OBJ[newDim];
Greetz
Greenhorn
Where exactly does the program crash?
In the debugger exactly at/after this line !Quote:
Originally Posted by CornedBee
There comes an error message if I go one step forward: "There is no source code available at this line"
Screenshot
This is the function.
Code:bool TabCtrl::InsertTabItem (unsigned numID) {
TAB_ITEM *pTempBuf = NULL;
unsigned oldDim = tabNumItems;
unsigned newDim = ++tabNumItems;
if (oldDim == 0) {
tabItems = new /*(std::nothrow)*/ TAB_ITEM[newDim];
} else {
pTempBuf = new (std::nothrow) TAB_ITEM[oldDim];
if (pTempBuf == NULL)
return false;
// Das alte Array Zwischenspeichern.
for (size_t i = 0; i < oldDim; i++) { pTempBuf[i] = tabItems[i]; }
// Den Speicher freigeben.
delete [ ] tabItems;
// Den Zwischenspeicher zurück kopieren.
tabItems = new /*(std::nothrow)*/ TAB_ITEM[newDim];
if (tabItems == NULL)
return false;
for (size_t i = 0; i < oldDim; i++) { tabItems[i] = pTempBuf[i]; }
// Den Zwischenspeicher wieder freigeben.
delete [ ] pTempBuf;
}
// Das neue Tab-Item initialisieren
SetTabItemRect (oldDim);
// Das neue Tab-Item als "selected" setzen
tabCurSelItem = oldDim;
// Alle Tab-Items updaten
AlignTabItems ();
return true;
}
Greetz
Very peculiar. I could have imagined VC++6 doing something absurd like this, but not 2008. No idea what could cause this crash.
On a different note, there's no need to allocate a temporary array, copy the data, then allocate a new one and copy the data again. You can do it like this:
Code:pTempBuf = new TABITEM[newDim];
// copy stuff from tabItems to pTempBuf
delete[] tabItems;
tabItems = pTempBuf;
Thank you very much, CornedBee. :)
I will try it.
The "nothrow"-Thing I will try in Code::Blocks and MinGW and then I'll give a report ... ;)
Greetz
It looks a bit that you are reinventing a (square) std::vector<TAB_ITEM>?
Are you sure that you can't use one? In general, I don't believe the implementation of high level classes such as TabCtrl should be implementing really low-level behaviour such as resizing dynamic memory.
You're right, it could be done easier with std::vector<TAB_ITEM>.Quote:
Originally Posted by anon
But I'm a Rookie and so I want to learn the basics at first.
Thanks for the hint, anyway. :)
Greetz
IMO, in C++ vector is the basics. What goes on behind the facade of vector definitely isn't the basics.
Also, it helps you come up with better designs if you know how using SC++L stuff works. You want to reimplement your own vector? Fine - but make it a separate class, that is used by TabCtrl to implement its high-level functionality.
I don't want to create a container class like vector, just an dynamic array, that's all.Quote:
Originally Posted by anon
Greetz
But ... but ... vector IS "a dynamic array".
A vector is just a dynamic array?
The thing is that your implementation of the dynamic array is built into a class, whose task seems to be providing a completely different service.
What InsertTabItem does is:
a) mess with dynamic allocations (16 lines)
b) initialize the tab item (1 line)
c) selects the new item (1 line)
d) update all tabs (1 line)
Doesn't this look a bit disproportionate? It would seem that the classes reason to exist is to handle dynamic allocations?
Wouldn't it be better if those 16 lines of memory reallocation were handled elsewhere too, by a smart RAII object that has been well tested in isolation?
Anyway, the cause of crashes may well be elsewhere. How's your constructors, copy constructors and such?
One mistake that I see is that you increment tabNumItems member regardless of whether the allocations succeed or fail (I wouldn't expect new to fail that often, though, that you might have noticed).
That's kinda like saying you don't want to drink H20, but want to drink water.Quote:
Originally Posted by Greenhorn__
The problem is that the "dynamic array" you're writing has absolutely shockingly terrible performance for adding new items, compared to a vector. Yours also is pretty buggy, unsafe, and incomplete right now. To add item number 1000, your code does 1999 constructions, 1999 destructions and 1999 assignments. A vector usually does just one copy-construction, (ignoring for the moment amortized constant time operations).
You should probably learn how to make your own vector another time. Right now you may as well get this finished quickly by simply using what the standard library provides.
I agree with all of you, and in the end it could be that I'll use a vector instead of what I'm trying now.
But, as I said, I also want to learn how to work with dynamic arrays under use with "new" and "delete".
I don't need 1000 Tabs, in practice I think I never need more than 50 Tabs.
@anon
You're right, this error I didn't noticed until now, thanks a lot.
I wouldn't criticize this so much for run-time inefficiency.
TabCtrl probably won't be your last class to use some kind of dynamic storage for something. Do you think it is wise to keep reimplementing exactly the same memory handling functionality for all of them (and one that's easy to get wrong), or would it be better if there was a (generic) class like vector that would take care of this task once and for all?
If you want to implement a dynamic-array class for practice, go ahead, but it should still be a separate class (that TabCtrl, among others might use - making it a template is a good idea). Otherwise, unless you are implementing classes whose only purpose is to manage memory, you should practically never need the array form of new and delete in your code.