why dose this only give me:Code:deleted
ouput is:
not
Output is: <somthing here>
Printable View
why dose this only give me:Code:deleted
ouput is:
not
Output is: <somthing here>
You never change output[0], since runoften is at least 1 before you get to anywhere in your "input parsing routine" -- and if output[0] happens to be \0, then your string ends before it even gets started.
(I put "input parsing routine" in quotes because it's not clear that you mean to be skipping all those letters -- when runoften increases two or three or four at a time, you're going to be skipping two or three or four input characters. And I also really hope you have indentation in your source file, or else eeesh.)
And:
is absolutely meaningless. Assigning a variable to itself is NEVER meaningfull [1]Code:runoften=runoften;
[1] If it's a pointer to a hardware register then it may have a meaning (e.g. writing bits that are set will actually clear those bits in some hardware registers).
And would it not make more sense to have a function that produces N stars followed by the symbol X?
Further, instead of having a huge number of if-statements, use a switch-case [or at least use if-else-if chains, since if the letter is 'a', then it's obviously NOT going to be equal to 'b'.
--
Mats
Code:int aa;
int bb;
string name;
char input[1000];
char output[1000];
void a
{
while (aa != 100)
{
cout<<"loop";
aa=aa+1;
if(input[aa]=='a'||input[aa]=='d'||input[aa]=='g'||input[aa]=='j'||input[aa]=='m'||input[aa]=='p'||input[aa]=='s'||input[aa]=='w')
{
input[aa]='*';
}
else
{
if(input[aa]=='b'||input[aa]=='c'||input[aa]=='d'||input[aa]=='e'||input[aa]=='f'||input[aa]=='g'||input[aa]=='t'||input[aa]=='x')
{
output[aa]='*';
bb=aa;
bb++;
output[bb]='*';
bb=0;
}
else
{
output[aa]='*';
bb=aa;
bb++;
output[bb]='*';
bb++;
output[bb]='*';
bb=0;
}
}
}
cout<<output;
}
I only read that dubious line and didn't even bother going further ahead. You need that to be broken into multiple conditions. Or'ing those together is not at all doing what you want.Code:if(input[aa]='a'|'d'|'g'|'j'|'m'|'p'|'s'|'w')
Well, 'a'|'d'|'g'|'j'|'m'|'p'|'s'|'w' is some large number, you then assign it to input[aa] (not comparison, mind you, but assignment), and then output[1] is set to *.Code:input[aa]='a'|'d'|'g'|'j'|'m'|'p'|'s'|'w'
(And continues etc.)
Then when you go to print output, it starts at output[0], finds that that is the null character, and stops (because that's how strings work -- they go until you get a null character and then you stop).
Are those supposed to be ORs? If so, that's not how it works.Code:if(input[aa]='a'|'d'|'g'|'j'|'m'|'p'|'s'|'w')
Code:if (input[aa] == 'a' || input[aa] == 'd' || input[aa] == 'g' ...
OK thank you all, I still have a lot to learn :) , I made some corrections. now how do I get the to print the output
Fantastic! I am glad you are at least halfway getting it now. Next time don't be so ashamed by your initial post that you delete the code, however. Believe it or not, others will probably one day ask the same question and benefit from seeing someone who asked it in a similar way. Right?
You build the output appropriately. (At least all the code you've posted has had inappropriately created output, with \0's at the *beginning* of the output, which is bad. You need to start writing into your output at character 0.)Quote:
Originally Posted by IM back!
OK thanks now it works i simply defined aa like this int aa = -1;
Wow... I didn't even notice that it was uninitialized. You should put those as local variables, by the way. There is no earthly reason for them to exist outside of your function.
That's because they are initialized (all global variables are initialized to 0 unless otherwise explicitly initialized). I agree that that's not a good reason to make them global.Quote:
Originally Posted by master5001
> if (input[aa] == 'a' || input[aa] == 'd' || input[aa] == 'g' ...
To improve further, consider
if ( strchr( "adg", input[aa] ) )
thats because that is a part of a small app, I could have done it like this. operation(char input[100], int aa) but i find global variables easyer in this case.Quote:
Originally Posted by tabstop
now one last qusetion: why dose this not work:
I also tryed:Code:
if(input[aa]==' ')
{
output[bb]='0';
bb++;
}
since 32 is the acsii code for "space" i think.Code:if(input[aa]==32)
{
output[bb]='0';
bb++;
}
Really, that's not a good reason.Quote:
Originally Posted by IM back!
If you have a good reason, use them. If you don't, then don't. It's bad practice.
A small app is just not a good reason. Don't get into the habit of doing it!
Wouldn't it be much easier to read this way:Code:if(input[aa]=='a'||input[aa]=='d'||input[aa]=='g'||input[aa]=='j'||input[aa]=='m'||input[aa]=='p'||input[aa]=='s'||input[aa]=='w')
{
input[aa]='*';
}
else
{
if(input[aa]=='b'||input[aa]=='c'||input[aa]=='d'||input[aa]=='e'||input[aa]=='f'||input[aa]=='g'||input[aa]=='t'||input[aa]=='x') {
output[aa]='*';
bb=aa;
bb++;
output[bb]='*';
bb=0;
}
else
{
output[aa]='*';
bb=aa;
bb++;
output[bb]='*';
bb++;
output[bb]='*';
bb=0;
I have no idea what your code is actually intending to do, so I have no idea if the above code is actually correct - it's just a replacement of your long if-statements with switch - which makes it easier to read. strchr() as suggested is also an option, but it's a bit of a roundabout way to do it.Code:switch (input[aa])
{
case 'a':
case 'd':
case 'g':
case 'j':
case 'm':
case 'p':
case 's':
case 'w':
input[aa]='*';
break;
case 'b':
case 'c':
case 'd':
case 'e':
case 'f':
case 'g':
case 't':
case 'x':
output[aa]='*';
bb=aa;
bb++;
output[bb]='*';
bb=0;
break;
default:
output[aa]='*';
bb=aa;
bb++;
output[bb]='*';
bb++;
output[bb]='*';
bb=0;
}
--
Mats
Because it does work. You seem to have deleted all your original code, but I recall you using >> to read in your input, and it is not possible to read in a space into a string with >>.Quote:
Originally Posted by IM back!
I do indeed use cin>>input;, but if i do this:
it comes with spaces, so I dont understand what you mean, but ill try cin.getline( input, 100, '\n' )Code:cin>>input;
cout<<input;
EDIT: it works with cin.getline( input, 100, '\n' ), thank you, i dont understand why thow.
If you have cin >> input and you type "hello world", input will only read "hello", and that's what will get printed. The next time through (if you have a loop) you'll get "world", but the space between them will be ignored.Quote:
Originally Posted by IM back!