binary search

Code:

---

#include<iostream.h>
#include<conio.h>

int binarysearch(int[], int, int);

void main(void)
{
    clrscr();
    int a[10]={6,4,89,23,45,65,88,22,11,56};
    int loc, item, n=10;
    cout<<"Enter Item for Search: ";
    cin>>item;
    loc=binarysearch(a, item, n);
    if(loc == -1)
    cout<<"Not Found\n";
    else
    cout<<"Found At Location: "<<loc;
    getch();
    }
    int binarysearch(int a[], int item, int n)
    {
        int mid, end, beg;
        beg=0;
        end=n-1;
        while(beg <= end)
        {
                  mid=int((beg+end)/2);
                  if(item == a[mid])
                  return mid;
                  if(item < a[mid])
                  end=mid-1;
                  else
                  beg=mid+1;
                  }
                  return -1;
                  }

---

what's wrong with this? ;\ please let me know

thanks

Hmm, what is wrong.....

• iostream.h
• conio.h
• void main()
• Horrible indenting

This list is not necessarily conclusive.

HRM

Indenting Has nothing to do with compilation
Iostream.h Is used for Input/output else cin/cout are not recognized
void main() <- even If I change that to int main still gives an error
conio.h <- clearscreen = clrscr(); wont work without it neither will getch(); but instead of getch(); we can use cin.get(); however we cant use clrscr

now If you can fix the above logicaly please reply
thank you

Code:

---

#include<iostream.h>
#include<conio.h>
int binarysearch(int[], int, int);

int main(void)
{
   
    int a[10]={6,4,89,23,45,65,88,22,11,56};
    int loc, item, n=10;
    cout<<"Enter Item for Search: ";
    cin>>item;
    loc=binarysearch(a, item, n);
    if(loc == -1)
    cout<<"Not Found\n";
    else
    cout<<"Found At Location: "<<loc;
    getch();
      }
    int binarysearch(int a[], int item, int n)
    {
        int mid, end, beg;
        beg=0;
        end=n-1;
        while(beg <= end)
        {
                  mid=int((beg+end)/2);
                  if(item == a[mid])
                  return mid;
                  if(item < a[mid])
                  end=mid-1;
                  else
                  beg=mid+1;
                  }
                  return -1;
                  }

---

fixed one, works fine
thanks anyways UNCLE Mac :P

Quote:

---

Originally Posted by salmansalman

HRM

Indenting Has nothing to do with compilation

---

It has all to do with people reading it.

For example, I might have pointed out that binarysearch appears to be defined inside main() (as it appears at first glance).

Quote:

---

Iostream.h Is used for Input/output else cin/cout are not recognized
void main() <- even If I change that to int main still gives an error
conio.h <- clearscreen = clrscr(); wont work without it neither will getch(); but instead of getch(); we can use cin.get(); however we cant use clrscr

---

You are probably using some ancient compiler, writing non- and prestandard code. Unfortunately yes, there is no standard way to clear the screen (but what's the big deal - if the program is run by double-clicking on the exe/from the IDE, the screen will be empty anyhow?).

As for what is wrong - did you know that binary search is only supposed to work on sorted data?

Quote:

---

Originally Posted by salmansalman

thanks anyways UNCLE Mac :P

---

Apparently I need to have a talk with a sibling of mine.