Moving cursor to the end of line

I have wrote this:

Code:

---

#include <stdio.h>
#include <conio.h>

void main()
{
        /* variables define here */
        char lgn, beep = 0x07, ctrl_char;
       
        /* Start of program */
        printf("Welcome to Students DataBase\n");
       
        /* Main page */
        main:
                printf("you want to login as Teacher or Student (T/S):");
               
                lgn_check:
                lgn = getche();
                if (lgn == 0x08){
                        printf("%c:", beep);
                        goto lgn_check;
                }
                else if (lgn == 0x0D || lgn == 0x03){
                        printf("%c", beep);
                        goto lgn_check;
                }
                ctrl_char = getch();
               
                ctrl_char_check:
                if (ctrl_char == 0x08){
                        printf("\b");
                        lgn = getche();
                        ctrl_char = getch();
                       
                        if (ctrl_char == 0x08)
                                goto ctrl_char_check;
                }
               
                switch (lgn){
                        case 'T':
                        case 't':
                                printf("\nyou loged in as Teacher.\nPlease enter your password:");
                                goto teacher;
                                break;
                        case 'S':
                        case 's':
                                printf("\nyou loged in as Student.\n");
                                goto student;
                                break;
                        default:
                                printf("\n%cError: unknown command\n", beep);
                                goto main;
                }
        // End of main loop
       
        teacher:
                /* teacher commands */
        // End of teacher loop
       
        student:
                /* student commands */
        // End of student loop
}

---

when I press "enter" key the cursor go to start of line. but I want it stay where it is.

thanks to all

You need to clean up your code a bit.
Void main is bad: http://cpwiki.sourceforge.net/Void_main
Goto is bad. Use loops.
Don't use "magic numbers" such as 0x08, use appropriate characters (like '\n' or so).
And then you are using non-standard functions such as getche (avoid them).

As for the cursor... if I'm thinking right, then it's platform specific or may be found somewhere in the depths of some conio.h header or some other unportable non-standard functions.

Quote:

---

Originally Posted by Elysia

You need to clean up your code a bit.
Void main is bad: http://cpwiki.sourceforge.net/Void_main
Goto is bad. Use loops.
Don't use "magic numbers" such as 0x08, use appropriate characters (like '\n' or so).
And then you are using non-standard functions such as getche (avoid them).

As for the cursor... if I'm thinking right, then it's platform specific or may be found somewhere in the depths of some conio.h header or some other unportable non-standard functions.

---

you said use loops, which loop can act like goto!?
another question, why goto is bad?

Quote:

---

you said use loop, which loop can act like goto!?

---

All of them, but a while loop or a do while loop look most appropriate here. Your teacher and student labels should be replaced by functions, with the corresponding gotos replaced by function calls.

Quote:

---

Originally Posted by behzad_shabani

you said use loop, which loop can act like goto!?

---

If you want to repeat something a certain number of times, a for-loop.
If you want to do something "zero or more times until some condition", then a while-loop is generally the right thing.
If you want to do soemthign "at least once, until some condition", then do-while-loop is generally the right thing.

The goto's in the switch-statements should probably be function calls, rather than goto's.

--
Mats

Quote:

---

Originally Posted by laserlight

Your teacher and student labels should be replaced by functions, with the corresponding gotos replaced by function calls.

---

Did you read my mind, or did I read yours? :)

--
Mats