single swap for char,short,int,float,double

Code:

---

#include <stdio.h>

void swap(void *a, void *b) {
        void *t;
        t = a;
        a = b;
        b = t;
}

int main() {
        int i, j;
        double f, g;
        i = 1;
        j = 2;
        f = 1.1;
        g = 2.2;
        printf("Before: %d, %d & %f, %f\n", i,j, f,g);
        swap(&i, &j);
        swap(&f, &g);
        printf("After: %d, %d & %f, %f\n", i,j, f,g);
        return 0;
}

---

I tried to write a generic swap() for char,short,int,long,float,double all the standard data types. But it is not working the way I thought it will :(

I suppose you could do something like this:

Code:

---

void swap(void *a, void *b, size_t dataSize)
{
  void *t = malloc(dataSize);
  memcpy(t, a, dataSize);
  memcpy(a, b, dataSize);
  memcpy(b, t, dataSize);
  free(t);
}

int a = 32;
int b = 64;
swap(&a, &b, sizeof(int));

---

Jackie Chan: I think a,b,t are local pointers in swap() that's why your program is not working. You can do this by passing by reference.

No, this is because you're just trying to swap the pointers.

You would have to dereference the pointers and swap the values, but unfortunately, void pointers cannot be dereferenced.

I'm not sure if it's even possible to create a generic swap function using void pointers - AFAIK, you'll be forced to cast the voids to some type and swap them.

Maybe someone wiser than I can help you out.

.. Cue matsp

If you wanted to write swap() to swap ints, you might write:

Code:

---

void swap(int *a, int *b) {
    int *t;
    *t = *a;
    *a = *b;
    *b = *t;
}

---

Changing int to void will not work since you cannot create objects of type void. I suspect that if you want a generic swap, you have to do something like this:

Code:

---

void swap(void *a, void *b, size_t size) {
    void *t = malloc(size);
    memcpy(t, a, size);
    memcpy(a, b, size);
    memcpy(b, t, size);
    free(t);
}

---

and assume and a and b point to objects of the same type.

Update: oh, 39ster has the same idea, that's good.

The IDEA given above is much better than what I was about to reply to.
I know there are many C whiz kids on this block! :D

Here is my version, very simple also:

Code:

---

#define SWAP(a, b, TYPE)  {\
                TYPE t;\
                t = a;\
                a = b;\
                b = t;}

---

Works with standard data-types only.

Another possibility is to (ab)use macros:

Code:

---

#define SWAP(a, b, T) do { T t; t = a; a = b; b = t; } while(0)

---

This works for all types that are assignable (so, essentially all but arrays).

Usage something like this:

Code:

---

float x = 7f;
float y = 8f;
SWAP(x, y, float);
double d1 = 5.0;
double d2 = 6.0;
SWAP(d1, d2, double);

---

If you have a compiler that supports typeof() [e.g. gcc], you could even do:

Code:

---

#define SWAP(a, b) do { typeof(a) t; t = a; a = b; b = t; } while(0)

---

--
Mats

Bring on the auto keyword! :):):)

Quote:

---

Originally Posted by matsp

Another possibility is to (ab)use macros:

Code:

---

#define SWAP(a, b, T) do { T t; t = a; a = b; b = t; } while(0)

---

This works for all types that are assignable (so, essentially all but arrays).

Usage something like this:

Code:

---

float x = 7f;
float y = 8f;
SWAP(x, y, float);
double d1 = 5.0;
double d2 = 6.0;
SWAP(d1, d2, double);

---

If you have a compiler that supports typeof() [e.g. gcc], you could even do:

Code:

---

#define SWAP(a, b) do { typeof(a) t; t = a; a = b; b = t; } while(0)

---

--
Mats

---

Can somebody please explain why do{ }while(0) is used in the above code.
I understand that it is used to make sure the code inside is executed atleast/atmost once.
Can the same result can be got without it ?

Quote:

---

Bring on the auto keyword!

---

It already exists in C. I suspect that you are thinking of C++0x.

Quote:

---

Can somebody please explain why do{ }while(0) is used in the above code.
I understand that it is used to make sure the code inside is executed atleast/atmost once.
Can the same result can be got without it ?

---

It is a trick to allow the macro to be used in contexts where it would otherwise be problematic. Consider:

Code:

---

if (x)
    swap(a, b, int);

---

Thank you 39ster, abh!shek, IceDane, laserlight, manav, matsp and others also who asked more questions to make it more clear.

:)

Quote:

---

Originally Posted by laserlight

It is a trick to allow the macro to be used in contexts where it would otherwise be problematic. Consider:

Code:

---

if (x)
    swap(a, b, int);

---

---

Sorry if I bothered you,but I still can't get it.
The code you have mentioned runs just fine on
my system even after I remove the do while(0).

Code:

---

#include <stdio.h>
#include <string.h>
#define SWAP(a, b, T) {T t; t = a; a = b; b = t;}

int main()
{
    float x = 7.0f;
    float y = 8.0f;
    double d1 = 5.0;
    double d2 = 6.0;
    int a=10;
    int b=6;
    if(x)
        SWAP(a,b,int);
    SWAP(x, y, float);
    SWAP(d1, d2, double);
    printf("%f %f\n",x,y);
    printf("%f %f\n",d1,d2);
    printf("%d %d\n",a,b);
    return 0;
}

---

Is there anything i am doing wrong here?

Anything wrong with a bitwise swap, along with a bit of macro abuse? (Hence no typeof() or 3rd var of the type required)

Providing they're the same type isn't it valid? (I'd think so).

Quote:

---

Originally Posted by stevesmithx

Sorry if I bothered you,but I still can't get it.
The code you have mentioned runs just fine on
my system even after I remove the do while(0).

---

Try with

Code:

---

if(x)
    SWAP(a,b,int);
else
    SWAP(x, y, float);

---

The do... while(0) trick prevents a stray semicolon appearing in the statement. (It converts multiple statements into a single do...while statement.)

Quote:

---

Anything wrong with a bitwise swap, along with a bit of macro abuse? (Hence no typeof() or 3rd var of the type required)

Providing they're the same type isn't it valid? (I'd think so).

---

I think it has problems if swapping a variable with itself. It also wouldn't work for doubles and floats...?

Thanks a lot anon.
More explanation about this is
given here.