BOOL bool ? unresolved external symbol

All I did was add the following two lines to my mysql.h file:

Code:

---

#include ".\mysql\h\my_global.h"
#include ".\mysql\h\m_string.h"

---

Everything compiled great until the very end.

Then I got these errors:

Code:

---

1>Linking...
1>item_handling.obj : error LNK2019: unresolved external symbol "void __cdecl affect_join(struct playerDATA *,struct affected_type *,bool,bool,bool,bool)" (?affect_join@@YAXPAUplayerDATA@@PAUaffected_type@@_N222@Z) referenced in function "void __cdecl do_drink(struct playerDATA *,char *,int,int)" (?do_drink@@YAXPAUplayerDATA@@PADHH@Z)
1>verb_eat.obj : error LNK2001: unresolved external symbol "void __cdecl affect_join(struct playerDATA *,struct affected_type *,bool,bool,bool,bool)" (?affect_join@@YAXPAUplayerDATA@@PAUaffected_type@@_N222@Z)
1>utilities_one.obj : error LNK2019: unresolved external symbol "void __cdecl affect_join7z(struct playerDATA *,struct affected_type7z *,bool,bool,bool,bool)" (?affect_join7z@@YAXPAUplayerDATA@@PAUaffected_type7z@@_N222@Z) referenced in function "void __cdecl apply_roundtime(int,int,struct playerDATA *,int,int,unsigned long)" (?apply_roundtime@@YAXHHPAUplayerDATA@@HHK@Z)
1>utilities_one.obj : error LNK2019: unresolved external symbol "void __cdecl affect_join5z(struct playerDATA *,struct affected_type5z *,bool)" (?affect_join5z@@YAXPAUplayerDATA@@PAUaffected_type5z@@_N@Z) referenced in function "void __cdecl apply_roundtime(int,int,struct playerDATA *,int,int,unsigned long)" (?apply_roundtime@@YAXHHPAUplayerDATA@@HHK@Z)
1>XIAIX.exe : fatal error LNK1120: 3 unresolved externals

---

Just for grins and giggles, I changed:

Code:

---

void affect_join(struct playerDATA *ch, struct affected_type *af, bool add_dur, bool avg_dur, bool add_mod, bool avg_mod);
void affect_join5z(struct playerDATA *ch, struct affected_type5z *af5z, bool add_dur);
void affect_join7z(struct playerDATA *ch, struct affected_type7z *af7z, bool add_dur, bool avg_dur, bool add_mod, bool avg_mod);

---

to

Code:

---

void affect_join(struct playerDATA *ch, struct affected_type *af);
void affect_join5z(struct playerDATA *ch, struct affected_type5z *af5z);
void affect_join7z(struct playerDATA *ch, struct affected_type7z *af7z);

---

(as you can see I only left out the bool values) and presto, everything compiled fine with no errors.

Now, I know you're bored already from reading all this pucky stuff but I promise, I'm almost done. :)

Okay, in the "my_global.h" file there's another #include to the "config-win.h" file. Within that "config-win.h" file there's a line of code, it reads:

Code:

---

#define bool BOOL

---

I commented this line of code out and the whole program compiles just fine now with no errors or warnings.

SO, MY QUESTION IS THIS:

Does anyone see any ill side effects from me commenting out this line? Something that I might run into in the future?

tyia

well windows have there own BOOL for c so the author may be wanted to use that :confused:

No, actually, in C there is no "bool," so the define was there to make bool default as BOOL, so you can use "bool" just as well as "BOOL".

There is a macro bool in C99 in stdbool.h which evaluates to _Bool.

Your changing of function prototypes is probably going to cause errors, if you ever tried to use those functions.

First, I'd check that you have the latest version - this might have been fixed. If you do/it hasn't, then I would create a "wrapper" header that includes the MySQL headers (the original ones, before you made changes) that you need, and then undef's bool. Additionally, when you were compiling, you got linker errors, that included C++ name mangling. All in all, what I'd try might be something like:

Code:

---

#ifndef FIX_MYSQL_H
#define FIX_MYSQL_H

#ifdef __cplusplus
extern "C" {
#endif

#include ".\mysql\h\my_global.h"
#include ".\mysql\h\m_string.h"
#ifdef bool
#undef bool
#endif

#ifdef __cplusplus
}
#endif

#endif

---

Do you really need the #ifdef bool, though? Wouldn't simply #undef suffice?

Quote:

---

Originally Posted by Cactus_Hugger

Your changing of function prototypes is probably going to cause errors, if you ever tried to use those functions.

---

Wow, that's a nice euphemism :-)

xwielder, note that C linking just looks up the symbol; there is no name mangling and no parameter checking. If you do something like the following:

impl.c

Code:

---

int square(int x)
{
    return x*x;
}

---

main.c

Code:

---

int square(void);
int main(void)
{
    int y = square();
    return 0;
}

---

then this will compile and link without errors; the implementation of square() will simply grab whatever is on the stack (or in a certain register, depending on your system) and use it as if it were a caller-supplied value for x.