Problem Displaying a Struct

I'm having problems displaying a struct. The program recieves input of a person's class schedule, and the person can search for a class using the id number. I keep getting errors when it comes to displaying the search results. I know that it doesn't seem to recognize the struct, but i don't know how to fix it. Thanks for your time.

Code:

---


#include<iostream>
#include<string>
using namespace std;

int InputClass(int cindex);
int DisplayClass(int cindex);

struct CLASS
{       
  string name;
  int number;
  string meets;
  int start;
  int end;
  string teacher;
  int size;
};


int main()
{
        int cindex=0;
        int menu;
//menu
        do {
                cout<<"Class Organizer"<<endl;
                cout<<"1: Enter in your classes"<<endl;
                cout<<"2: Search with class number"<<endl;
                cout<<"3: Quit"<<endl;
                cin>>menu;
               
                switch(menu) {
                        case 1:
                                InputClass(cindex);
                                break;
                        case 2:
                                DisplayClass(cindex);
                                break;
                        case 3:
                                break;
                        default:
                                cout<<"Invalid input, please enter a number given.";
                                break;
                }

        } while(menu);
       
        system ("PAUSE");
        return 0;
}


int InputClass(int cindex)
{
        CLASS Class[54];
        char crerun='y';

        do {
                cout<<"Name of Class:"<<endl;
                getline(cin,Class[cindex].name);
                cout<<"Class Number:"<<endl;
                cin>>Class[cindex].number;
                cout<<"Meets on (MWF if it meets on Monday, Wednesday, and Friday):"<<endl;
                getline(cin,Class[cindex].meets);
                cout<<"Start time:"<<endl;
                cin>>Class[cindex].start;
                cout<<"End time:"<<endl;
                cin>>Class[cindex].end;
                cout<<"Teacher Name:"<<endl;
                getline(cin,Class[cindex].teacher);
                cout<<"Number of Students in Class:"<<endl;
                cin>>Class[cindex].size;

                cindex++1;
                cout<<"Would you like to add another class?"<<endl;
                cin>>crerun;
        } while(crerun == 'Y' || crerun == 'y');
       
        return 0;
}


int DisplayClass(int cindex)
{
        int clnumber;
        int loop;
       
        cout<<"Enter class number to print that or 'all' to print all classes";
        cin>>clnumber;
        if (clnumber=-858993460) {
                for (loop=0; loop<=cindex; loop++) {
                        cout<<Class[loop].name<<endl;
                        cout<<Class[loop].number<<endl;
                        cout<<Class[loop].meets<<endl;
                        cout<<Class[loop].start<<endl;
                        cout<<Class[loop].end<<endl;
                        cout<<Class[loop].teacher<<endl;
                        cout<<Class[loop].size<<endl<<endl;
                }
        }
        else {
                for( loop=0; loop<=cindex; loop++){
                        if (Class(loop).number!=clnumber)
                                cout<<""<<endl;
                        else {
                                cout<<Class(loop).name<<endl;
                                cout<<Class(loop).number<<endl;
                                cout<<Class(loop).meets<<endl;
                                cout<<Class(loop).start<<endl;
                                cout<<Class(loop).end<<endl;
                                cout<<Class(loop).teacher<<endl;
                                cout<<Class(loop).size<<endl;
                                break;
                                }
                        }
               
                        if (loop==cindex) {
                        cout<<"There is no class with that number.";
                        }

                        else
                                cout<<"";
        }

        return 0;
}//goes back to menu

---

Errors:

c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(74) : error C2143: syntax error : missing ';' before 'constant'
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(92) : error C2065: 'Class' : undeclared identifier
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(92) : error C2228: left of '.name' must have class/struct/union
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(93) : error C2065: 'Class' : undeclared identifier
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(93) : error C2228: left of '.number' must have class/struct/union
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(94) : error C2065: 'Class' : undeclared identifier
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(94) : error C2228: left of '.meets' must have class/struct/union
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(95) : error C2065: 'Class' : undeclared identifier
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(95) : error C2228: left of '.start' must have class/struct/union
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(96) : error C2065: 'Class' : undeclared identifier
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(96) : error C2228: left of '.end' must have class/struct/union
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(97) : error C2065: 'Class' : undeclared identifier
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(97) : error C2228: left of '.teacher' must have class/struct/union
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(98) : error C2065: 'Class' : undeclared identifier
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(98) : error C2228: left of '.size' must have class/struct/union
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(103) : error C2228: left of '.number' must have class/struct/union
type is ''unknown-type''
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(103) : error C3861: 'Class': identifier not found
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(106) : error C2228: left of '.name' must have class/struct/union
type is ''unknown-type''
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(106) : error C3861: 'Class': identifier not found
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(107) : error C2228: left of '.number' must have class/struct/union
type is ''unknown-type''
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(107) : error C3861: 'Class': identifier not found
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(108) : error C2228: left of '.meets' must have class/struct/union
type is ''unknown-type''
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(108) : error C3861: 'Class': identifier not found
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(109) : error C2228: left of '.start' must have class/struct/union
type is ''unknown-type''
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(109) : error C3861: 'Class': identifier not found
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(110) : error C2228: left of '.end' must have class/struct/union
type is ''unknown-type''
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(110) : error C3861: 'Class': identifier not found
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(111) : error C2228: left of '.teacher' must have class/struct/union
type is ''unknown-type''
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(111) : error C3861: 'Class': identifier not found
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(112) : error C2228: left of '.size' must have class/struct/union
type is ''unknown-type''
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(112) : error C3861: 'Class': identifier not found

Why don't you use a vector which has functions to find data given a predicate function. or even a foreach to display only if it satisfies a predicate function.

The array Class is local to InputClass and does not exist in DisplayClass. This also means that all the data will be lost as soon as InputClass exits.

You should declare the CLASS list in main and pass it to both functions (together with any other data these might need to update/display the data, such as current size / max size).

Unless you typedef the struct you must refer to it with the struct keyword:

Code:

---

int InputClass(int cindex)
{
        //Wrong
        //CLASS Class[54];

        //Right
        struct CLASS Class[54];
...

---

This is C++, here you don't need that typedef.

Quote:

---

Originally Posted by rags_to_riches

Unless you typedef the struct you must refer to it with the struct keyword:

Code:

---

int InputClass(int cindex)
{
        //Wrong
        //CLASS Class[54];

        //Right
        struct CLASS Class[54];
...

---

---

Only in C. His program is C++, so that's acceptable.

You can see each function as a separate building. What exists in one building doesn't necessarily exist in another building.
So you either need to transport that something into the building (pass an argument, which is the recommended way) or put the something outside any buildings, in which case all buildings can see and use it (called global, not recommended).

Dammit, I guess I should stay in C programming only...this is the second C++ question I've boned from lack of use. Or maybe it's the crack.

Oh well, very sorry for the confusion.

Well, mistakes makes perfect. If you don't make mistakes, you don't learn! So don't be so down :)

Quote:

---

c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(34) : error C2664: 'InputClass' : cannot convert parameter 2 from 'CLASS [54]' to 'CLASS'

---

This particular error means that you have something like:

Code:

---

int InputClass(int cindex, CLASS Class);
...

CLASS array[54];
inputClass(n, array);

---

Which of course, the compiler is going to complain about.

You should EITHER:
1. Use class[] in the prototype.
2. Pass in an indexed element from the array variable.

--
Mats

I now only have errors in the second function, excluding line 73 error. I haven't changed any code in the second function. Code is now 1 line less from original post.

Errors:

c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(73) : error C2143: syntax error : missing ';' before 'constant'
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(102) : error C2064: term does not evaluate to a function taking 1 arguments
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(102) : error C2228: left of '.number' must have class/struct/union
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(105) : error C2064: term does not evaluate to a function taking 1 arguments
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(105) : error C2228: left of '.name' must have class/struct/union
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(106) : error C2064: term does not evaluate to a function taking 1 arguments
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(106) : error C2228: left of '.number' must have class/struct/union
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(107) : error C2064: term does not evaluate to a function taking 1 arguments
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(107) : error C2228: left of '.meets' must have class/struct/union
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(108) : error C2064: term does not evaluate to a function taking 1 arguments
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(108) : error C2228: left of '.start' must have class/struct/union
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(109) : error C2064: term does not evaluate to a function taking 1 arguments
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(109) : error C2228: left of '.end' must have class/struct/union
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(110) : error C2064: term does not evaluate to a function taking 1 arguments
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(110) : error C2228: left of '.teacher' must have class/struct/union
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(111) : error C2064: term does not evaluate to a function taking 1 arguments
c:\documents and settings\student\my documents\visual studio 2008\projects\mod 2 project 3\mod 2 project 3\class planner.cpp(111) : error C2228: left of '.size' must have class/struct/union

cindex++1;

and what do you mean by this?


DisplayClass - this function should somehow know about the Class - for example make it class member...

I accedentally put a 1 there, its not needed. I don't understand what you mean, I'm just using the fuction DisplayClass to display a class schedule or a searched class, not code class, but school class.

DisplayClass does not sees the Class variable declared in another function... it is upto you how to make it seing it - make function a class member, pass object as a parameter and (worst choice) make it global

I'm pretty much a noobie when it comes to programming, so I don't really know how I would pass an object as a parameter. If you could just point me in the right direction it would be much appreciated.

Quote:

---

Originally Posted by rockstarpirate

I'm pretty much a noobie when it comes to programming, so I don't really know how I would pass an object as a parameter. If you could just point me in the right direction it would be much appreciated.

---

Considering you did it several times in your program, that seems inconsistent somehow. But anyway: You pass things to a function by putting it in parentheses behind the function name, like function(this_object), or function(that_object), or whatever. In this case, you want to pass the class list, which is an array of Classes, so your function would take a Class whatever[].

The class that I'm taking doesn't really explain what the code is doing, it's more of a "if you want the program to do this, use this code."

Anyway, I finally have all the errors gone, I had () instead of []. It works fine until I search for a class. I can search for one class fine, but if I enter an invalid number or "all," it doesn't perform correctly.

Here's my code so you can test it.

Code:

---

#include<iostream>
#include<string>
using namespace std;

struct CLASS
{       
  string name;
  int number;
  string meets;
  int start;
  int end;
  string teacher;
  int size;
};

int InputClass(int cindex, CLASS Class[54]);
int DisplayClass(int cindex, CLASS Class[54]);

int main()
{
        int cindex=0;
        int menu;
        CLASS Class[54];
//menu
        do {
                cout<<"Class Organizer"<<endl;
                cout<<"1: Enter in your classes"<<endl;
                cout<<"2: Search with class number"<<endl;
                cout<<"3: Quit"<<endl;
                cin>>menu;
               
                switch(menu) {
                        case 1:
                                InputClass(cindex, Class);
                                break;
                        case 2:
                                DisplayClass(cindex, Class);
                                break;
                        case 3:
                                break;
                        default:
                                cout<<"Invalid input, please enter a number given.";
                                break;
                }

        } while(menu);
       
        system ("PAUSE");
        return 0;
}


int InputClass(int cindex, CLASS Class[54])
{
        char crerun='y';

        do {
                cout<<"Name of Class:"<<endl;
                cin>>Class[cindex].name;
                cout<<"Class Number:"<<endl;
                cin>>Class[cindex].number;
                cout<<"Meets on (MWF if it meets on Monday, Wednesday, and Friday):"<<endl;
                cin>>Class[cindex].meets;
                cout<<"Start time:"<<endl;
                cin>>Class[cindex].start;
                cout<<"End time:"<<endl;
                cin>>Class[cindex].end;
                cout<<"Teacher Name:"<<endl;
                cin>>Class[cindex].teacher;
                cout<<"Number of Students in Class:"<<endl;
                cin>>Class[cindex].size;

                cindex++;
                cout<<"Would you like to add another class?"<<endl;
                cin>>crerun;
        } while(crerun == 'Y' || crerun == 'y');
       
        return 0;
}


int DisplayClass(int cindex, CLASS Class[54])
{
        int clnumber;
        int loop;
       
        cout<<"Enter class number to print or 'all' to print all classes";
        cin>>clnumber;
        if (clnumber=-858993460) {
                for (loop=0; loop<=cindex; loop++) {
                        cout<<Class[loop].name<<endl;
                        cout<<Class[loop].number<<endl;
                        cout<<Class[loop].meets<<endl;
                        cout<<Class[loop].start<<endl;
                        cout<<Class[loop].end<<endl;
                        cout<<Class[loop].teacher<<endl;
                        cout<<Class[loop].size<<endl<<endl;
                }
        }
        else {
                for( loop=0; loop<=cindex; loop++){
                        if (Class[loop].number!=clnumber)
                                cout<<""<<endl;
                        else {
                                cout<<Class[loop].name<<endl;
                                cout<<Class[loop].number<<endl;
                                cout<<Class[loop].meets<<endl;
                                cout<<Class[loop].start<<endl;
                                cout<<Class[loop].end<<endl;
                                cout<<Class[loop].teacher<<endl;
                                cout<<Class[loop].size<<endl;
                                break;
                                }
                        }
               
                        if (loop==cindex) {
                        cout<<"There is no class with that number.";
                        }

                        else
                                cout<<"";
        }

        return 0;
}//goes back to menu

---