problems with prototype function looping

hey guys im learning to make my own functions and iv had a little trouble it seems my function is returning what i want but for some reason when i put it in a do while loop it just keeps looping instead of exiting when i want, you should be able to see what i mean from this sample text. Thanks in advance much appreciated the people on this site are so helpful.

Code:

---

#include <stdio.h>

const int TRUE = 1;
const int FALSE = 0;

int isY(char ch);

int main()
{

        int x = 1;
        int choice;
       
        while (x = 1)
        {
                choice = isY(choice);
                if (choice == FALSE)
                x++;
        }
        return 0;
}

int isY(char ch)
{
        int result;
        printf("Say this massage again\n(Y/N)? ");
        scanf("%c", &ch);
        fflush(stdin);
        printf("\n");
        if ( (ch == 'y') || (ch == 'Y') )
                result = TRUE;
        else
                result = FALSE;
               
        return result;
}

---

for some reason it just keeps looping even if something other than y or Y is entered.

p.s. fflush(stdin) works fine on my compiler (quincy 2005) and i have not yet been tought a better way to flush the standard input thing, but that should not be the problem here. thanks again

you should use break wihin your if block of while loop.

Quote:

---

Originally Posted by dezz101

p.s. fflush(stdin) works fine on my compiler (quincy 2005) and i have not yet been tought a better way to flush the standard input thing, but that should not be the problem here. thanks again

---

Yes, and if you change to another compiler it may not - the point about "don't use fflush(stdin)" is not that it doesn't work when the C library supports it, but rather that it's a bad habit to use it, because it's by no means guaranteed to work (and it may even crash in some C library implementations).

--
Mats

A better way to flush the input buffer, here you go! :)
http://cpwiki.sourceforge.net/Common...flush_stdin.21

Write your own:

Code:

---

void flush(FILE *in)
{
    int ch;
    while ((ch=fgetc(in)) != EOF)
    {
        if (ch == '\n') break;
    }
}

---

Code:

---

while (x = 1)

---

You probably meant to say:

Code:

---

while (x == 1)

---