Reading directories recursively

Ok, my mission that I would like to accomplish is to set my program wild on a certain directory. Its mission is to find every mp3 file, rename it to my liking, and organize them(I can handle this myself). I figured the easiest way would be to build an array of all of the directories and subdirectories, and once I finished moving the files in one, move to the next one.

Of course I have some big issues, but I really need some ideas. In my opinion the way I am doing it probably sucks. Here is the code I have been messing with, and it currently does not compile. But hopefully it can show you my idea.

I would like to take any suggestions about changing my approach completely. It seems to me like I am making a fairly simple thing hard.

Code:

---

#include <stdio.h>
#include <string.h>
#include <windows.h>

char* basedir = "C:\\Music\\*";

int main (void)
{
        WIN32_FIND_DATA f;
        HANDLE h = FindFirstFile(basedir, &f);
        char* dirs[1000];
        char* tempdir;
        int i = 0;
        int j = 0;
        int k = 0;

        while (h != INVALID_HANDLE_VALUE)
        {
                while (FindNextFile(h, &f))
                {

                        if (f.dwFileAttributes == 16)
                        {
                                dirs[j] = f.cFileName;
                                j++;
                        }
                        else
                        {
                                //will eventually move the file
                        }
                }

                if (j > k)
                {
                        tempdir = strcat(basedir, dirs[k]);
                        h = FindFirstFile(tempdir, &f);
                        k++;
                }

        }

return 0;
}

---

There's a win32 tree walker in the FAQ.

I tried to find the Win32 tree walker and had trouble finding it. A link could be nice.

Anyway, here is my code again. Not quite working correctly yet but doing better than before. If anyone would help, I would much appreciate it. Here once again is the rundown I am trying to acheive.

Give my program a directory, and fill an array will all paths. example:

Code:

---

dirs[0] = "C:\";
dirs[1] = "C:\Music\";
dirs[2] = "C:\Videos\";
dirs[3] = "C:\Music\Marley\";
etc...

---

Here is what I am working with:

Code:

---

#define _CRT_SECURE_NO_DEPRECATE 1

#include <stdio.h>
#include <string.h>
#include <windows.h>

LPTSTR extensn = "\\";
LPTSTR asteris = "*";

int main (void)
{
        WIN32_FIND_DATA f;
        DWORD buffSize = MAX_PATH;
        LPTSTR lpszBuffer = (LPTSTR)malloc(buffSize *sizeof(char));
        LPTSTR tempdir = (LPTSTR)malloc(buffSize *sizeof(char));
        LPTSTR basedir = (LPTSTR)malloc(buffSize *sizeof(char));
        LPTSTR dirs[1000];
        HANDLE h;
        int i = 0;
        int j = 0;
        int k = 0;
        sprintf(basedir, "&#37;s", "C:\\Music");
        sprintf(lpszBuffer, "%s%s%s", basedir, extensn, asteris);
        h = FindFirstFile(lpszBuffer, &f);


        while (h != INVALID_HANDLE_VALUE)
        {
                while (FindNextFile(h, &f))
                {
                        if (f.dwFileAttributes == FILE_ATTRIBUTE_DIRECTORY)
                        {
                                if (strcmp(f.cFileName, "..") != FALSE)
                                {
                                        sprintf(lpszBuffer, "%s%s%s", basedir, extensn, f.cFileName);
                                        dirs[j] = lpszBuffer;
                                        printf("ADDED %s\t%d\n", dirs[j], j);
                                        j++;
                                }
                        }
                        else
                        {
                                printf("FILE FOUND!\n");
                                //Will try to move it later
                        }
                }

                if (j > k)
                {
                        sprintf(lpszBuffer, "%s%s%s", lpszBuffer, extensn, asteris);               
                        h = FindFirstFile(lpszBuffer, &f);
                        k++;
                }

        }
        //Strange thing here, the array values seem to be different than what I set them to above
        for (i = 0; i < j; i++)
                printf("%s\n", dirs[j]);

return 0;
}

---

The standard idiom would be to use dir[i], not j.

Code:

---

        //Strange thing here, the array values seem to be different than what I set them to above
        for (i = 0; i < j; i++)
                printf("%s\n", dirs[j]);

---

See if that doesn't help.

Avoid pointer typedefs such as LPTSTR. Do you know what it is?
Your "dirs" array is just an array of pointers, each one pointing to lpszBuffer. Which means that every time your lpszBuffer changes, so does dirs[x]. You must use a real buffer and copy the string over via strcpy.
And you're far better off just using normal, fixed-size arrays instead of malloc here. You are not freeing the malloced data and you are not calling CloseHandle either which you must do after the FindFirstFile call.
Also beware that you can get a buffer overrun in lpszBuffer because it's just MAX_PATH characters. If the directory you found is MAX_PATH, then you will copy MAX_PATH + 2 bytes which means buffer overrun.

Code:

---

sprintf(basedir, "%s", "C:\\Music");

---

By the way, that's the same thing as

Code:

---

strcpy(basedir, "C:\\Music");

---

except that strcpy() is probably more efficient.

Also note that sizeof(char) is always 1, so you don't have to include it.

Lastly, malloc() is in <stdlib.h>, so you should include that.

Code:

---

                        if (f.dwFileAttributes == FILE_ATTRIBUTE_DIRECTORY)
                        {
                                if (strcmp(f.cFileName, "..") != FALSE)
                                {
                                        sprintf(lpszBuffer, "%s%s%s", basedir, extensn, f.cFileName);
                                        dirs[j] = lpszBuffer;
                                        printf("ADDED %s\t%d\n", dirs[j], j);
                                        j++;
                                }
                        }

---

On Linux, at least, I think you have to ignore "." as well as "..". Perhaps this doesn't apply to Windows.

Oh right. You have to ignore "." in Windows, too.