Parsing strings

I have a string of letters seperated by periods, like this:

Quote:

---

a.ds.ees.f.csg.cw.s.ab.s.f.s.ffsd.j

---

I want to place each set of letters into a element of an array, so it would look something like:

Quote:

---

[a][ds][ees][f][csg][cw][s][ab][s][f][s][ffsd][j]

---

Can you guys give me an idea on how to do this.

Thanks

Loop through each character, appending it to the array item in queue, then if you hit a period, queue the next array item.

Code:

---

#include <iostream>
#include <string>
#include <vector>

int main ()
{
  std::string input;
  std::vector<std::string> ar;
  while ( std::getline( std::cin, input, '.' ) ) {
      ar.push_back( input );
  }
}

---

With my apologies, I'm quite aware you aren't allowed to use the STL if you are doing homework. But you could borrow some of the ideas and write something similar to std::getline.

Thanks for the idea.
Now what is wrong with program it crashes;

Code:

---


    vector <string> text;

  string input = "a.ds.ees.f.csg.cw.s.ab.s.f.s.ffsd.j"  ;
 
  int j = 0;
  for (int i=0;i < input.length(); i++){
        if(isalpha(input[i]))
                text[j] += input[i];
        else if(ispunct(input[i]))
                j++;
  }

 for (int i=0;i < text.size(); i++)
    cout  <<"[" << text[i] << "]"<< endl;

---

You need to use put_back("") somewhere before you access element j - or set the size of the vector before-hand.

--
Mats

but when I do that it places every char into a seperate element, and I want to group them

insted of [a][d][s][e][e] ... I want [a][ds][ees] ...

Quote:

---

Originally Posted by Tupcia

but when I do that it places every char into a seperate element, and I want to group them

insted of [a][d][s][e][e] ... I want [a][ds][ees] ...

---

You are probably not placing your "put_back()" in the right place, then.

Edit: And if you can't figure out where it should go, you need to post your code (so that we can see what you are currently doing, and fix it up).

--
Mats

Code:

---


    vector <string> text;

  string input = "a.ds.ees.f.csg.cw.s.ab.s.f.s.ffsd.j"  ;
 
  int j = 0;
  for (int i=0;i < input.length(); i++){
        if(isalpha(input[i]))
                text.push_back(input[i])
        else if(ispunct(input[i]))
                j++;
  }

---

This does not even compile, it does when I make text a vector of chars, but then eeach element is just 1 letter.

If you have a vector of strings, then the things you push back must be strings. input[i] is not a string, it's a letter. You need to build a string -- look into substr.

Got it, by breaking the string into tokens:

Code:

---

 
 vector <string> text;

  char input = "a.ds.ees.f.csg.cw.s.ab.s.f.s.ffsd.j"  ;
 
  char *a;
  a = strtok(input, ".");
  while (a != NULL) {
      text.push_back(a);
      a = strtok(input, ".");
  }

---

Thanks for all the help !

That won't compile unless you make input a char array or const char pointer.

And if you were ever doing this outside of class, prefer citizen's implementation.

I'm not a very experienced programmer but couldn't you just use scanf?

just for fun i did it this way.

Code:

---

        char *input = "a.ds.ees.f.csg.cw.s.ab.s.f.s.ffsd.j"  ;
        unsigned int length = strlen(input);
        char delimiter = '.';
        unsigned int numFields=0;
        unsigned int *delimiterPositions=new unsigned int[1];
        for(int i=0;i<length;i++)
        {
                if(input[i]==delimiter)
                {
                        numFields++;
                        realloc(delimiterPositions,numFields*sizeof(unsigned int));
                        delimiterPositions[numFields-1]=i;
                }
        }
        char **parsed = new char*;
        unsigned int start = 0;
        unsigned int end;
        for(int i=0;i<numFields;i++)
        {
                end = delimiterPositions[i];
                parsed[i]=new char[end-start];
                memcpy(parsed[i],input+start,end-start);
                start = end+1;
        }

---

now, i originally used realloc on parsed, but after several successful iterations, i get an error. any ideas?

Code:

---

        char *input = "a.ds.ees.f.csg.cw.s.ab.s.f.s.ffsd.j"  ;
        char **parsed = new char*;
        char delimiter = '.';
        unsigned int numFields=0;
        char *start = input;
        char *end= (char *)memchr(input,delimiter,strlen(input));
        while( end!=NULL )
        {
                numFields++;
                realloc(parsed,numFields*sizeof(char *));
                char *end= (char *)memchr(start,delimiter,strlen(start));
                int size = end-start;
                parsed[numFields-1]=new char[end-start];
                memcpy(parsed[numFields-1],start,end-start);
                start = end+1;

        }

---

Hello World, this is C++, not C.
Let's get rid of unsafe stuff such as memcpy and get rid of new so you don't have to delete.
Citizen already provided an implementation. Does it not work?

m37h0d, your code never frees the memory you allocate.

Quote:

---

Originally Posted by Elysia

Hello World, this is C++, not C.
Let's get rid of unsafe stuff such as memcpy and get rid of new so you don't have to delete.
Citizen already provided an implementation. Does it not work?

m37h0d, your code never frees the memory you allocate.

---

well of course not. you'd free it when you didn't need it anymore! :)


i'm just asking. there are PACs out there that are programmable in C, but not C++. i realize this is the C++ forum, but i didn't think the topic warranted a whole new thread over there.