strnlen, implicit declaration?

Hi,

I am in my second year of Computer Science and have just been introduced to C this term. Coming from a JAVA background I must say it is slightly daunting, but I'm sure I'll pick it up...

I'm just having a bit of trouble with a small function I'm writing:

Code:

---

#include <stdlib.h>
#include <stdio.h>
#include <string.h>

/*
 * Print a given description to the standard output stream
 * formatting the output to conform to the maxLineWidth.
 */
void printDescription(const char *description, const int maxLineWidth) {
        char buff[maxLineWidth + 1], *b;
        char word[maxLineWidth + 1], *w;
        b = buff;
        w = word;
       
        for(; *description !='\0'; description++) {
                *w = *description;

                if (*description == ' ' &&  strnlen(w, maxLineWidth) + strnlen(b, maxLineWidth) <= maxLineWidth) {
                        b = strncat(*b, *w, strnlen(w, maxLineWidth));
                        w = "";
                }

                if (strnlen(w, maxLineWidth) + strnlen(b, maxLineWidth) > maxLineWidth) {
                        printf("%s\n", buff);
                        b = "";
                        b = strncat(*b, *w, strnlen(w, maxLineWidth));
                        w = "";
                }
               
                w++;
        }

        printf("%s\n", buff);
}

---

Basically the function 'printDescription' takes a paragraph of writing and outputs it depending on the 'maxLineWidth' parameter.

The way I am trying to implement it is by copying each character to a 'word', then when the word is complete placing it in the buffer for the line. Once the line has reached its maximum allowed length, the line is printed and then the next line and so on...

I keep getting an error for 'implicit declaration of strnlen' when I try to compile it, so I can't even see if it works yet. Any other tips on where my program is incorrect would also be welcome... :)

It means you haven't included the header file where strnlen resides. Without it, the compiler is not guaranteed to generate correct code to call the function (undefined behaviour).
However, I'm unsure at the time of writing, where it does reside. Suggest you google a little or wait until someone else shows up.

Didn't even think strnlen existed.

http://www.linux-foundation.org/spec...strnlen-3.html

Nvm

I am pretty sure strnlen resides within the string.h header, and I have included it there...

Locate your string.h file and see if it is there. I don't think it's in there if it gives you an implicit declaration.

It can't give you an implicit declaration if the compiler sees the actual decaration. Sometimes, depending on compiler, you may have to define macros or similar. The best bet is to take a peek inside the header file and see if you locate the function.

strnlen is a non-standard function, so I expect it to only "work" on certain implementations.

You can write your own:

Code:

---

size_t strnlen(const char *str, size_t maxlen)
{
    size_t i;
    for(i = 0; i < maxlen && str[i]; i++);
    return i;
}

---

--
Mats

OK thanks guys, yeah i couldn't find strnlen, but there is strlen there. I was told this may be bad to use because of potential buffer overflows, but I guess I'll just use this instead.

Not if your string is NULL terminated. But you are right in that it may be unsafe.

It is "bad" in the sense that if there isn't a zero at the end of the string, it will continue until it finds a zero - which can lead to a segfault/access violation if there is no zero before the "end of current memory block".

By the way, your code is broken in several ways when it comes to the handling of strings:

Code:

---

....
                        b = strncat(*b, *w, strnlen(w, maxLineWidth));
                        w = "";
....
                          b = "";
                        b = strncat(*b, *w, strnlen(w, maxLineWidth));
                        w = "";

---

These bits will DEFINITELY crash your system (unless you are using 16-bit code in DOS where there isn't have any memory protection), as in the second case, *b definitely is 0 - definitely bad destination for a strncpy, and in the other cases *b and *w is a the single character that w points to, which isn't a good memory address for strncat to copy to or from. Also, assuming you removed the *, you are trying to copy to an empty string constant (again, in the second case), which will also fail in most system since it's a "read only" piece of memory that holds the empty string.

You need to study string handling a bit further (and turn up your warning levels so that you get warnings for passing incorrect parameters to strncpy().


--
Mats

Quote:

---

Originally Posted by AngryStyro

OK thanks guys, yeah i couldn't find strnlen, but there is strlen there. I was told this may be bad to use because of potential buffer overflows, but I guess I'll just use this instead.

---

How can a function which only READS data possibly overflow a buffer? It could step out of bounds and crash, but the traditional definition of a "buffer overflow" is writing data where you're not supposed to. Whoever told you that is not thinking.

strnlen() is a paranoid GNU extension written by somebody who was afraid of the black helicopters.

Yes, I didn't exactly follow there either but took their word for it since they have more experience in C than me.

OK, I have managed to get rid of all the errors whilst compiling, but I am not getting the output I want from the function.

Code:

---

void printDescription(const char *description, const int maxLineWidth) {
        char buff[maxLineWidth + 1], *b;
        char word[maxLineWidth + 1], *w;
        b = buff;
        w = word;
       
        for(; *description !='\0'; description++) {
                *w = *description;

                if (*description == ' ' &&  strlen(w) + strlen(b) <= maxLineWidth) {
                        b = strncat(b, w, strlen(w + 1));
                        *w = 0;
                }

                else if (*description == ' ' && strlen(w) + strlen(b) > maxLineWidth) {
                        printf("%s\n", b);
                        *b = 0;
                        b = w;
                        *w = 0;
                }
               
                else {
                        w++;
                }
        }

        printf("%s\n", b);
}

---

From my analysis I think the problem is where I have *w=0. What I want to do here is effectively 'reset' the string so it is effectively empty, and the pointer is back at the starting position. I suspect what it is actually doing is just putting a 0 value at the current position and continuing on. Does anybody know what I would have to change it to to get the desired result?

The only other thing I thought it could be was if strlen included the null characters in the length of the string, but surely it doesn't...

Many thanks

Thought I'd just add what the function is meant to do again...

Basically the function 'printDescription' takes a paragraph of writing and outputs it depending on the 'maxLineWidth' parameter.

The way I am trying to implement it is by copying each character to a 'word', then when the word is complete placing it in the buffer for the line. Once the line has reached its maximum allowed length, the line is printed and then the next line and so on...

Code:

---

                if (*description == ' ' &&  strlen(w) + strlen(b) <= maxLineWidth) {
                else if (*description == ' ' && strlen(w) + strlen(b) > maxLineWidth) {

---

Both of these are undefined behaviour.
The reason is because ou never put anything in either buff or word (btw, your pointer variable names are lacking). You only assign one char. That doesn't add any NULL char, so it can go into infinity trying to find a NULL char.
Initialize your buffers to 0 with

Code:

---

= {0}

---

first and you'll find that works better.

Yes, sorry about the pointer names, I can be rather unthoughtful when it comes to naming some things. So you mean initialize them like this?

Code:

---

char buff[maxLineWidth + 1] = {0}, *b;
char word[maxLineWidth + 1] = {0}, *w;

---

When I do this I get the following when I try to compile it:
misc.c: In function ‘printDescription’:
misc.c:12: error: variable-sized object may not be initialized
misc.c:12: warning: excess elements in array initializer
misc.c:12: warning: (near initialization for ‘buff’)
misc.c:13: error: variable-sized object may not be initialized
misc.c:13: warning: excess elements in array initializer
misc.c:13: warning: (near initialization for ‘word’)

As the error says, you cannot initialize them to 0, because they variable-sized.
Better to use memset in that case, or set description + 1 to 0 (beware so that you don't do a buffer overrun).