New to C, need help understanding errors

I am new to C and I have to create a program that will take an array, input by the keyboard, and sort it in ascending order. I know there are easier ways but the way I have chosen will get me extra credit in the class which I need. I feel like I am getting close but I keep getting these two errors and I do not understand how to fix them.

If anyone has any suggestions or help it would be much appreciated.

Here are the two errors I am getting

Error 1 error C2447: '{' : missing function header (old-style formal list?) c:\documents and settings\me\my documents\visual studio 2005\projects\array\array\array.cpp 13

and

Error 2 fatal error C1004: unexpected end-of-file found c:\documents and settings\me\my documents\visual studio 2005\projects\array\array\array.cpp 63


and here is my source code:

Code:

---

// Array.cpp : Defines the entry point for the console application.
//

#include<stdio.h>
#include<stdafx.h>
#include"conio.h"
#include<math.h>

#define x 10

int get_min_range(int list[], int first, int last);
       
{

        first=0;
       
        for(last=1; last<x; ++last){
               
                if (arr[last,arr[first]){
                        first=last;
       
                return(first)
}


void sort_arr(int arr[], int n)
{

        int f,         
          temp,         
          index_of_min; 

      for (f = 0; f < x-1; ++f) {
          index_of_min = get_min_range(arr, f, x-1);

          if (f != index_of_min) {
                temp = arr[index_of_min];
                arr[index_of_min] = arr[f];
                arr[f] = temp;
}



int main()
{
       
int arr[x], b=0;

       
for(int n=0; n<x; n++)
{
        printf("Enter a number in the array:");
      scanf_s("%d", &arr[n]);
}

sort_arr(arr);

for(b=0; b<x; b++)
printf("%d", arr[b]);
getch();
return (0);
}

---

Quote:

---

int get_min_range(int list[], int first, int last);

---

Note the semi-colon that makes this a function prototype instead of the start of a function definition.

thank you so much I cant believe I over looked that.

I fixed it and then I had a few simple syntax errors
I fixed them and now I am getting these errors

Error 1 error C2601: 'sort_arr' : local function definitions are illegal c:\documents and settings\me\my documents\visual studio 2005\projects\array\array\array.cpp 29

Error 2 fatal error C1075: end of file found before the left brace '{' at 'c:\documents and settings\me\my documents\visual studio 2005\projects\array\array\array.cpp(35)' was matched c:\documents and settings\me\my documents\visual studio 2005\projects\array\array\array.cpp 65

Im not sure about the first one and I have no Idea on what the second one means.

Indent your code properly and you will find that your braces do not match.

Thanks that fixed all the errors now the program is not sorting the numbers in the array it is just printing them in the order I input them. Any ideas why? Here is the new source code:

Code:

---


// Array.cpp : Defines the entry point for the console application.
//

#include<stdio.h>
#include<stdafx.h>
#include"conio.h"
#include<math.h>

#define x 10

int arr[x], n, temp;


int get_min_range(int list[], int first, int last)
       
{

        first=0;
       
        for(last=1; last<x; ++last)
               
                if (arr[last],arr[first])
                        first=last;
       
                        return(first);
}


void sort_arr(int arr[], int n)
{

        int f, temp=0, index_of_min; 

      for (f = 0; f < x-1; ++f)
          index_of_min = get_min_range(arr, f, x-1);

          if (f != index_of_min)
                temp = arr[index_of_min];
                arr[index_of_min] = arr[f];
                arr[f] = temp;
}



int main()
{
       
        int f=0;

       
                for(int n=0; n<x; n++)
                {
                                printf("Enter a number in the array:");
                                scanf_s("&#37;d", &arr[n]);
                }

                sort_arr( arr, n);

                        for(f=0; f<x; f++)
                                printf("%d", arr[f]);
        getch();
        return (0);
}

---

here is my output window:

Your indentation is still a little off, and consequently it is misleading. It should be along these lines instead:

Code:

---

#include<stdio.h>
#include<stdafx.h>
#include"conio.h"
#include<math.h>

#define x 10

int arr[x], n, temp;

int get_min_range(int list[], int first, int last)
{
    first=0;

    for (last=1; last<x; ++last)
        if (arr[last],arr[first])
            first=last;

    return(first);
}

void sort_arr(int arr[], int n)
{

    int f, temp=0, index_of_min;

    for (f = 0; f < x-1; ++f)
        index_of_min = get_min_range(arr, f, x-1);

    if (f != index_of_min)
        temp = arr[index_of_min];

    arr[index_of_min] = arr[f];
    arr[f] = temp;
}

int main()
{
    int f=0;

    for (int n=0; n<x; n++)
    {
        printf("Enter a number in the array:");
        scanf_s("&#37;d", &arr[n]);
    }

    sort_arr( arr, n);

    for (f=0; f<x; f++)
        printf("%d", arr[f]);
    getch();
    return (0);
}

---

However, before we continue, turn your global variables into local variables.

Code:

---

if (arr[last],arr[first])

---

What are you trying to do here? This doesn't exactly do anything important, and it certainly doesn't do what you want it to.

Also, in that same function, you seem to pass in a value 'first', and then you immediately set it to zero. Why bother passing it at all? The same goes with last, which is immediately set to 1 in your for loop.

Is this looking any better? I cleaned it up a little and changed the variables but im still having the same problem.

Code:

---

// Array.cpp : Defines the entry point for the console application.
//

#include<stdio.h>
#include<stdafx.h>
#include"conio.h"
#include<math.h>

#define x 10

int get_min_range(int list[], int first, int last)
       
{       
        int arr[x];

        first=0;
       
        for(last=1; last<x; ++last)
                if (arr[last],arr[first])
                        first=last;
       
        return(first);
}


void sort_arr(int arr[], int n)
{

        int f, temp=0, index_of_min; 

    for (f = 0; f < x-1; ++f)
                index_of_min = get_min_range(arr, f, x-1);

    if (f != index_of_min)
                temp = arr[index_of_min];
    arr[index_of_min] = arr[f];
        arr[f] = temp;
}



int main()
{
       
        int f=0, n=0, arr[x];

       
        for(int n=0; n<x; n++)
        {
                printf("Enter a number in the array:");
                scanf_s("&#37;d", &arr[n]);
        }

        sort_arr( arr, n);

        for(f=0; f<x; f++)
                printf("%d", arr[f]);
        getch();
        return (0);
}

---

See my suggestions above.

Also, you removed your global variables. But you're defining them in the wrong place. Your arr[x] should be defined in main() and passed to your get_min_range() as the list[] variable. Currently, you're not using list[] for anything in that function.

Ok this is the part I am really having trouble with:

Code:

---

int get_min_range(int arr[], int first, int last)
       
{       

       
       
        for(last<x; ++last;)
                if (arr[last],arr[first])
                        first=last;
       
        return(first);
}

---

yeh I saw that and fixed it list was the example used in the book and and I guess I just had it on my mind then when I tried to build it it said arr[] was unidentified

Pay attention to what I told you. That if statement in the above function doesn't do anything close to what you want it to. It's not logical C, and my compiler throws a warning on it because it's pointless. Think about what you're trying to do there and rethink the if condition.

Go read the FAQ on for loops. This for loop isn't right at all.

Ok so I looked at the example and thanks to laserlights help with the indention problem I could see a few more problems this is my new get_min_range but it still doesn't do what I need it too:

Code:

---

int get_min_range(int arr[], int first, int last)
       
{       

        first=0;
       
        for(last=1; last<x; ++last)
                if (arr[last]<arr[first])
                        first=last;
       
        return(first);
}

---

arr[f], when used outside your for loop, will always mean that f will be equal to x-1. This isn't what you want.

And in your sort function, what is the purpose of the n parameter that you pass to it?

Honestly, I don't think your problem is solely in get_min_range. It's in sort_arr too.

Ok so I fixed a few things and changed some of the variables that where written as two different things but should have been carried over as one. So JDGATX, your saying to get rid of the variable n?

here is the new code I think I have get_min_range right now Ill look at sort_arr

Code:

---


// Array.cpp : Defines the entry point for the console application.
//

#include<stdio.h>
#include<stdafx.h>
#include"conio.h"
#include<math.h>

#define x 10

int get_min_range(int arr[], int small, int last)
       
{       

        small=0;

        for(last=1; last<x; ++last)
                if (last<small)
                        arr[small]=arr[last];
       
        return(small);
}


void sort_arr(int arr[], int n)
{

        int small, temp=0, index_of_min; 

    for (small = 0; small < x-1; ++small)
                index_of_min = get_min_range(arr, small, x-1);

    if (small != index_of_min)
                temp = arr[index_of_min];
    arr[index_of_min] = arr[small];
        arr[small] = temp;
}



int main()
{
       
        int f=0, n=0, arr[x];

       
        for(int n=0; n<x; n++)
        {
                printf("Enter a number in the array:");
                scanf_s("&#37;d", &arr[n]);
        }

        sort_arr( arr, n);

        for(f=0; f<x; f++)
                printf("%d", arr[f]);
        getch();
        return (0);
}

---

My problem is that it is only switching the first and last values if they are not in order.

There's still no point in passing in 'small' under your current implementation because you just set it to zero immediately upon entering the get_min_range function.

You still have the same problem in your sort_arr function that you did the LAST time I commented on it. Since this:

Code:

---

arr[small] = temp;

---

...is outside your for loop, small will always be x-1 when that statement executes, meaning you will always swap the last position, no matter what.

Thanks guys for the help I got a friend who is good at this he helped me too but thanks for all the suggestions they really helped.

Hi All,

3wit, please post the final code, so we all can learn from it. Cheers.

coolboarderguy