trying to loop FillRect

Code:

---

#include <windows.h>

/*  Declare Windows procedure  */
LRESULT CALLBACK WindowProcedure (HWND, UINT, WPARAM, LPARAM);

/*  Make the class name into a global variable  */
char szClassName[ ] = "WindowsApp";
PAINTSTRUCT ps;
RECT rect;
HBRUSH hb;
HDC hdc;
int R,G,B;
int WINAPI WinMain (HINSTANCE hThisInstance,
                    HINSTANCE hPrevInstance,
                    LPSTR lpszArgument,
                    int nFunsterStil)

{
    HWND hwnd;              /* This is the handle for our window */
    MSG messages;            /* Here messages to the application are saved */
    WNDCLASSEX wincl;        /* Data structure for the windowclass */

    /* The Window structure */
    wincl.hInstance = hThisInstance;
    wincl.lpszClassName = szClassName;
    wincl.lpfnWndProc = WindowProcedure;      /* This function is called by windows */
    wincl.style = CS_DBLCLKS;                /* Catch double-clicks */
    wincl.cbSize = sizeof (WNDCLASSEX);

    /* Use default icon and mouse-pointer */
    wincl.hIcon = LoadIcon (NULL, IDI_APPLICATION);
    wincl.hIconSm = LoadIcon (NULL, IDI_APPLICATION);
    wincl.hCursor = LoadCursor (NULL, IDC_ARROW);
    wincl.lpszMenuName = NULL;                /* No menu */
    wincl.cbClsExtra = 0;                      /* No extra bytes after the window class */
    wincl.cbWndExtra = 0;                      /* structure or the window instance */
    /* Use Windows's default color as the background of the window */
    wincl.hbrBackground = (HBRUSH) COLOR_BACKGROUND;

    /* Register the window class, and if it fails quit the program */
    if (!RegisterClassEx (&wincl))
        return 0;

    /* The class is registered, let's create the program*/
    hwnd = CreateWindowEx (
          0,                  /* Extended possibilites for variation */
          szClassName,        /* Classname */
          "Windows App",      /* Title Text */
          WS_OVERLAPPEDWINDOW, /* default window */
          CW_USEDEFAULT,      /* Windows decides the position */
          CW_USEDEFAULT,      /* where the window ends up on the screen */
          544,                /* The programs width */
          375,                /* and height in pixels */
          HWND_DESKTOP,        /* The window is a child-window to desktop */
          NULL,                /* No menu */
          hThisInstance,      /* Program Instance handler */
          NULL                /* No Window Creation data */
          );

    /* Make the window visible on the screen */
    ShowWindow (hwnd, nFunsterStil);

    /* Run the message loop. It will run until GetMessage() returns 0 */
    while (GetMessage (&messages, NULL, 0, 0))
    {
        /* Translate virtual-key messages into character messages */
        TranslateMessage(&messages);
        /* Send message to WindowProcedure */
        DispatchMessage(&messages);
    }

    /* The program return-value is 0 - The value that PostQuitMessage() gave */
    return messages.wParam;
}


/*  This function is called by the Windows function DispatchMessage()  */

LRESULT CALLBACK WindowProcedure (HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam)
{
    switch (message)                  /* handle the messages */
    {
        case WM_DESTROY:
            PostQuitMessage (0);      /* send a WM_QUIT to the message queue */
            break;
        case WM_KEYDOWN:
            switch(wParam)
            {
            case 'q': PostQuitMessage(0); break;
            }
            break;
        case WM_PAINT:
            BeginPaint(hwnd , &ps);
            GetWindowRect(hwnd , &rect);
            hdc = GetDC(hwnd);
            R += 1;
            hb = CreateSolidBrush(RGB(R,0,0));
            FillRect(hdc , &rect , hb);
            InvalidateRect(hwnd , &rect, true);
            UpdateWindow(hwnd);
            EndPaint(hwnd, &ps);
            break;
        default:                      /* for messages that we don't deal with */
            return DefWindowProc (hwnd, message, wParam, lParam);
    }

    return 0;
}

---

but its just staying the same color, i was expecting it to change from light to dark red 0 to 255

http://img176.imageshack.us/my.php?i...7895467cs9.jpg

I can see a couple of problems here:-

1. What is the value of R when your program starts? I don't see it set anywhere, so I can only assume it will be undefined (which under Windows means it will probably be 0xCCCCCCCC). Try either initializing it to zero when you declare it or during WinMain.

2. The 3rd parameter of InvalidateRect expects the Win32 API constant "TRUE", not the C++ keyword "true". Also I don't think you can expect an update to occur in between BeginPaint/EndPaint, that could be dangerous. Try using a timer or a keypress to invalidate and update the window.

3. You're creating brushes but not deleting them afterwards. That is baaaaaaad. You need to call DeleteObject() using the hb handle after FillRect().

ahh good tips Smruf , thanks