Private data question.

I have a header file that contain this class in regards to my other thread "Array of class objects"

When with the include and using namespace statements it will not allow me to declare a string in the private data. And i need to hold the name of a item from a file... Any ways around this?

Code:

---

#include <string>
#include <iostream>
using namespace std;

class dispenserType
{
        public:
                int getNoOfItems() const;
                int getCost() const;
                void makeSale();
                dispenserType(int setNoOfItems = 50, int setCost = 50);
        private:
                string name;
                int numberOfItems;
                int cost;
};

---

What do you mean by "it will not allow me to declare a string in the private data"?

Using declarations are frowned on in headers; I would recommend just using std::string name; instead.

Yes i know but it won't notice the private string data when it compiles, gives errors.

Quote:

---

Originally Posted by tabstop

Using declarations are frowned on in headers; I would recommend just using std::string name; instead.

---

I think you mean "using namespace" is frowned upon in headers.
"Declarations" are a little too unambiguous.



What errors?

Quote:

---

Originally Posted by GCNDoug

Yes i know but it won't notice the private string data when it compiles, gives errors.

---

It compiles just fine. Since it's private, you can't use it outside of the class (in main or wherever), only inside the class.

1>Compiling...
1>candymachinelab.cpp
1>c:\users\doug\documents\visual studio 2008\projects\lab5candy\lab5candy\dispensertype.h( 9) : error C2146: syntax error : missing ';' before identifier 'name'
1>c:\users\doug\documents\visual studio 2008\projects\lab5candy\lab5candy\dispensertype.h( 9) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
1>c:\users\doug\documents\visual studio 2008\projects\lab5candy\lab5candy\dispensertype.h( 9) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
1>Build log was saved at "file://c:\Users\Doug\Documents\Visual Studio 2008\Projects\lab5candy\lab5candy\Debug\BuildLog.h tm"
1>lab5candy - 3 error(s), 0 warning(s)
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

Quote:

---

Originally Posted by GCNDoug

1>Compiling...
1>candymachinelab.cpp
1>c:\users\doug\documents\visual studio 2008\projects\lab5candy\lab5candy\dispensertype.h( 9) : error C2146: syntax error : missing ';' before identifier 'name'
1>c:\users\doug\documents\visual studio 2008\projects\lab5candy\lab5candy\dispensertype.h( 9) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
1>c:\users\doug\documents\visual studio 2008\projects\lab5candy\lab5candy\dispensertype.h( 9) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
1>Build log was saved at "file://c:\Users\Doug\Documents\Visual Studio 2008\Projects\lab5candy\lab5candy\Debug\BuildLog.h tm"
1>lab5candy - 3 error(s), 0 warning(s)
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

---

As I said, it compiles fine here just the way you have it posted. Is there a difference between the file you're trying to compile and the file you have posted in this thread?

Also, maybe try std::string name; instead, if you haven't already.

Btw, iostream has no place in that header either.
So you can remove that and the "using namespace" and use std::string instead.

Notice that the error you posted references line 9, but the code you posted has that variable on line 13. Did you remove the #includes and try to compile it? You can't do that. You need #include<string> and you need either using namespace std; or to change to std::string (there are other solutions as well). The errors you're getting is what happens when you fail to include the proper header and specify the proper namespace.

Code:

---

#include <string>
#include <fstream>
class dispenserType
{
        public:
                int getNoOfItems() const;
                int getCost() const;
                void makeSale();
                dispenserType(int setNoOfItems = 50, int setCost = 50);
                void read(ifstream& readfrom)
                {
                        readfrom >> name;
                        readfrom >> numberOfItems;
                        readfrom >> cost;
                }
        private:
                string name;
                int numberOfItems;
                int cost;
};

---

I don't understand the teacher i making us keep the classes in separate header files. It won't understand the i/o file stuff either...

Also, put your class implementation in a separate cpp file.
The reason the class definitions goes into header files of their own is because, if other parts of your program wants to use the class, they need that definition or the compiler will complain.

And use std::ifstream and std::string, because it's in a header file.

still no luck.

Code:

---

std::ifstream // or std::ifstream;
std::string // or std::string;
class dispenserType
{
        public:
                int getNoOfItems() const;
                int getCost() const;
                void makeSale();
                dispenserType(int setNoOfItems = 50, int setCost = 50);
                void read(ifstream& readfrom)
                {
                        readfrom >> name;
                        readfrom >> numberOfItems;
                        readfrom >> cost;
                }
        private:
                string name;
                int numberOfItems;
                int cost;
};

---

You need the #include's. Put those back.

Then, you need to specify the namespace. The using directive you had in there originally was fine, but it is bad practice for larger projects so an alternative was given.

That alternative was to remove the using namespace std directive and instead always refer to string as std::string and ifstream as std::ifstream inside the actual code.


>> I don't understand the teacher i making us keep the classes in separate header files.
That's how it's done in C++ for several reasons. I don't understand why you are having a problem when your original code was working. Why are you changing it?

Code:

---

#include <string>
#include <iostream>

class dispenserType
{
        public:
                int getNoOfItems() const;
                int getCost() const;
                void makeSale();
                dispenserType(int setNoOfItems = 50, int setCost = 50);
                void read(std::ifstream& readfrom)
                {
                        readfrom >> name;
                        readfrom >> numberOfItems;
                        readfrom >> cost;
                }
        private:
                std::string name;
                int numberOfItems;
                int cost;
};

---

Elysia, please add the #include's to your example to avoid confusion.

oh sorry, that is totally new to me; have not learned in class. Will try now! Thanks you rock! lol

Quote:

---

Originally Posted by Daved

Elysia, please add the #include's to your example to avoid confusion.

---

Done.

hmm appears to have compiled fine without the #include statements but either way I added them. This issues is solved wooooo!

Thanks guys!

Yes, it may happen to compile because other headers before it included those headers. But it's a good idea not to rely on this because when you include that header from somewhere else, you might just get compile errors.
That's why all headers should include additional headers with the types it needs to get it to compile properly.