Strange problem during runtime (Program has stopped working...)

Hey guys, I just wrote a simple program that takes 10 integers into a vector, and the goal of the program is to output the ten numbers, all multiplied by two, using iterators. Well, I wrote the code and it seems fine, and also compiles fine, but when I enter in the first ten numbers into the vector, it says "Project1.exe has stopped working..." I'm currently using Vista Home Basic. Can anyone tell me what's going on? Thanks for anything in advance.

Here's the code:

Code:

---

#include <cstdlib>
#include <iostream>
#include <vector>

using namespace std;

int main(){
   
    vector<int> str(10);
    int num, counter;
   
    while (cin >> num){
            str.push_back(num);
    }
   
    for (vector<int>::iterator iter = str.begin(); iter != str.end(); ++iter){
        *iter = str[counter] * 2;
        ++counter;
        cout << *iter << endl;
}
       
    system("PAUSE");
    return EXIT_SUCCESS;
}

---

1. You create a vector of 10 ints, then add a couple more to the back of it. You probably want to create an empty vector instead.

2. counter is not initialised and thus holds garbage.

3. Since you want to use iterators, use them instead of an index, e.g., *iter += *iter.

Thanks. After doing what you suggested, the program now works, but what do you mean by "add a couple more to the back of it"? Cause, if I only enter 10 things for my while statement, it would fit in the vector, wouldn't it?

Quote:

---

After doing what you suggested, the program now works, but what do you mean by "add a couple more to the back of it"? Cause, if I only enter 10 things for my while statement, it would fit in the vector, wouldn't it?

---

Actually, you could enter a thousands ints and it will (most probably) still fit into the vector since you are using push_back() to add elements to the vector. However:

Code:

---

vector<int> str(10);

---

creates a vector of 10 ints, all zero initialised. You probably do not want these extra elements.

Oh I see, alright, thanks for helping.