question about strncmp

I'm using strncmp to return a 1 if the user has typed in recent:

Code:

---

return ((strncmp(checkvalue, "recent", 1) == 0)||(strncmp(checkvalue, "RECENT", 1) == 0)||(strncmp(checkvalue, "Recent", 1) == 0));

---

But if the user types in anything that begins in R it still returns 1, is this becuase strncmp is only looking at 1 letter, if so how can I change this?

Many Thanks

Use strcmp not strncmp. Strncmp checks only up to a given length; in your case the first character.

Edit: your code would look cleaner, and work better if you converted the string to upper or lower case first. That way if the user enters "REcent" by accident it would still be valid.

I've just figured out thats what the number 1 was doing in that. How would i use strcmp, just the same but without the number at the end?

Thanks Again

Yep.

Quote:

---

Originally Posted by sweetorangepie

I've just figured out thats what the number 1 was doing in that. How would i use strcmp, just the same but without the number at the end?

Thanks Again

---

You should learn to use C-reference - it describes exactly what each parametr is, what possible return values are, and how you can investigate the error happend.

Choose one that you like and start using it when you have a doubt how to call some standard function...

i have now changed it to:

Code:

---

return ((strcmp(checkvalue, "recent") == 0)||(strcmp(checkvalue, "RECENT") == 0)||(strcmp(checkvalue, "Recent") == 0));

---

but it is no longer returning a 1, what am i doing wrong?

Thanks

Quote:

---

but it is no longer returning a 1, what am i doing wrong?

---

Post the smallest and simplest compilable program that demonstrates the problem. For example, this works for me:

Code:

---

#include <stdio.h>
#include <string.h>

int isRecent(const char *checkvalue);

int main(void)
{
    const char *str = "Recent";
    printf("&#37;d", isRecent(str));
    return 0;
}

int isRecent(const char *checkvalue)
{
    return strcmp(checkvalue, "recent") == 0
        || strcmp(checkvalue, "RECENT") == 0
        || strcmp(checkvalue, "Recent") == 0;
}

---

This is the simplest version of what i'm trying to achieve:

Code:

---

int main (void)

recent = show_recent(guess);
                                if (0 != recent){
                                        printf("\n%s", recent_guess1);
                                        printf("%s", recent_guess2);
                                        printf("%s", recent_guess3);
                                        printf("%s", recent_guess4);
                                        break;
                                }

int show_recent( char* checkvar )
{
        return ((strcmp(checkvar, "recent") == 0)||(strcmp(checkvar, "RECENT") == 0)||(strcmp(checkvar, "Recent") == 0));
}

---

Can anyone see why this is?

Thanks

>Post the smallest and simplest compilable program that demonstrates the problem.