redefinition

this is the error that i get by running the following code.
how do i fix it?

Code:

---

#include<stdio.h>
#include<stdlib.h>

#define SIZE 10

main(){

        int values[]={5,3,7,12,9,1,10,8,4,3};
        int i;
        int square;
        for (i=0; i<SIZE; i++){
                printf ("%i  ",values[i]);}
                printf("\n");

        square=squareElements(values);

        for (i=0; i<SIZE; i++){
                printf("%i",values[i]);}

        system("Pause");
}
void squareElements(int values[],int size){
        int i;
        for (i=0; i<SIZE; i++){
                values[i]=values[i]*values[i];
        }
}

---

Quote:

---

this is the error that i get by running the following code.

---

running? or compiling?
Why not to post the exact error message and mark in some way the line where it ocured?

You should put the function prototype before main

Code:

---

void squareElements(int values[],int size);

---

update the call to mtch the prototype

and fix you main prototype to

Code:

---

int main(void)

---

i did some fixing and i still get the same error
error C2371: 'cube' : redefinition; different basic types
error C2063: 'cube' : not a function

Code:

---

#include<stdlib.h>
#include<stdio.h>

cube(int*);


main(){
       
        double variable=3.43;
        int* pVariable;
        int cube;
       
        printf("Value of variable is &#37;.2lf\n",variable);
        printf("Address of variable is %p\n",&variable);
       
        pVariable=&variable;
        cube(&variable);

        printf ("New value for variable is %lf\n",variable);
       

       
        system("Pause");
}

void cube(int* pVariable){
        printf("The number %.2lf\n",*pVariable);
        *pVariable=*pVariable * *pVariable * *pVariable;
        printf("The value for pVariable is %p\n",pVariable);
}

---

Quote:

---

Originally Posted by goran00

i did some fixing and i still get the same error
error C2371: 'cube' : redefinition; different basic types
error C2063: 'cube' : not a function

Code:

---

#include<stdlib.h>
#include<stdio.h>

cube(int*);


main(){
       
        double variable=3.43;
        int* pVariable;
        int cube;
       
        printf("Value of variable is &#37;.2lf\n",variable);
        printf("Address of variable is %p\n",&variable);
       
        pVariable=&variable;
        cube(&variable);

        printf ("New value for variable is %lf\n",variable);
       

       
        system("Pause");
}

void cube(int* pVariable){
        printf("The number %.2lf\n",*pVariable);
        *pVariable=*pVariable * *pVariable * *pVariable;
        printf("The value for pVariable is %p\n",pVariable);
}

---

---

your function prototype should be : void cube(int*);

Another problem is that you define a variable : int cube;
Thats the same name as your function.

thank you
now i still do not know how to fix the error
error C2063: 'cube' : not a function
i thought the compiler is supposed to know to look at the bottom to find what the cube function is
am i writing it wrong?

Code:

---

#include<stdlib.h>
#include<stdio.h>

void cube(int*);


main(){
       
        double variable=3.43;
        int* pVariable;
        int cube;
       
        printf("Value of variable is &#37;.2lf\n",variable);
        printf("Address of variable is %p\n",&variable);
       
        pVariable=&variable;
        cube(&variable);

        printf ("New value for variable is %lf\n",variable);
       

       
        system("Pause");
}

void cube(int* pVariable){
        printf("The number %.2lf\n",*pVariable);
        *pVariable=*pVariable * *pVariable * *pVariable;
        printf("The value for pVariable is %p\n",pVariable);
}

---

It's as DaveH already said.

Quote:

---

Another problem is that you define a variable : int cube;
Thats the same name as your function.

---

In other words, you have a variable called cube and a function called cube. The compiler thinks you're trying to call the variable, because it has more limited scope. (It's local to main and cube() is global.)

Call the variable or the function something else.

1. change to : int main() {

2. variable is a double. pVariable is int*. You have : pVariable=&variable;

3. function cube take an int* as a parameter. You are passing &variable. variable is a double.

4. rename your int cube variable to something else and see what happens.