Array of Base(Abstract) Class Problem

Hello,

Okay, here's the problem. I'm trying to create a linked list of abstract Object types, so I can use more complex (and extending) derivations of this Object class in the linked list. Follow so far?

The code in the game is more complex, but this code below gives the right idea (I've used an array instead of a linked list for simplicity)

Code:

---


class Base{

    public:

        virtual void doSomething(){
            std::cout << " - - - - " << std::endl;
        }
   
};

// - - - - - - - - - - - - - - - - - - - - - - - -

class Extended : public Base{

    public:

        void doSomething(){
            std::cout << "Doing something..." << std::endl;
        }
   
};

// - - - - - - - - - - - - - - - - - - - - - - - -

int main(int argc, char* argv[]){

    Base baseObj;
    Extended extensionObj;
   
    Base objs[2];
    objs[0] = baseObj;
    objs[1] = extensionObj;

    objs[0].doSomething();
    objs[1].doSomething();

    return 0;

}

---

Output only gives:

- - - -
- - - -

Rather than:

- - - -
Doing something...

Could someone please point me in the right direction? I don't understand why the overriding method in objs[1] is not called, like it should be..Thanks!

I do not know if this is right:

Extended *extensionObj = new Extended ;

extensionObj->doSomething();


EDIT:
This works, but I have no idea if its the right thing to do

Code:

---

#include <iostream>

class Base{

    public:

        virtual void doSomething(){
            std::cout << " - - - - " << std::endl;
        }
   
};

// - - - - - - - - - - - - - - - - - - - - - - - -

class Extended : public Base{

    public:

        void doSomething(){
            std::cout << "Doing something..." << std::endl;
        }
   
};

// - - - - - - - - - - - - - - - - - - - - - - - -

int main(int argc, char* argv[]){

    Base baseObj;
    Extended *extensionObj = new Extended;
     
    Base *objs[2];
    objs[0] = &baseObj;
    objs[1] = extensionObj;

    objs[0]->doSomething();
    objs[1]->doSomething();
   

    return 0;
}

---

Thanks very much! I've implemented those changes into my game and everything works well. :)

Ah yes, polymorphism only works with pointers.
To go with your original example:

Code:

---

    Base baseObj;
    Extended extensionObj;
   
    Base* pObjs[2];
    pObjs[0] = &baseObj;
    pObjs[1] = &extensionObj;

    pObjs[0]->doSomething();
    pObjs[1]->doSomething();

---

Should also do the trick.
Though it isn't required, I would mark every virtual function in derived classes as virtual, as well (the compiler will treat them as virtual anyway, but it's better to be explicit).

Quote:

---

I'm trying to create a linked list of abstract Object types, so I can use more complex (and extending) derivations of this Object class in the linked list.

---

Are you trying to create a cosmic hierarchy of classes based on an Object base class? If so, note that in C++ such genericity is normally provided by templates instead.

Quote:

---

I've implemented those changes into my game and everything works well.

---

I hope you noticed that h3ro's example fails to match new with a corresponding delete. Your code should do better. You could use std::tr1::shared_ptr with std::list or your own linked list class, or you could try Boost's ptr_list.

Quote:

---

Ah yes, polymorphism only works with pointers.

---

... and references, though in this case only pointers are applicable.

Note that arrays of base classes are a big no-no. Arrays of pointers, yes, but never directly of the class type.

Quote:

---

Originally Posted by CornedBee

Note that arrays of base classes are a big no-no. Arrays of pointers, yes, but never directly of the class type.

---

...only when trying to do polymorphism, right?

Quote:

---

Originally Posted by robwhit

...only when trying to do polymorphism, right?

---

Yes, but that's the point of (abstract)base classes, right?

In fact, any class that is inherited from another class would need to be a pointer, or you'd get "slicing". [Where the stored class is chopped to the size of the base].

--
Mats

>Yes, but that's the point of (abstract)base classes, right?

Yeah, I guess so.

Quote:

---

Originally Posted by Aramil

Array of Base ..... create a linked list of ..... in the linked list ..... an array instead ..... a linked list ..... Base objs[2];

---

Sheesh, make your freakin mind up already! :confused: :rolleyes: :p

They are totaly different sutrctures with very different properties. Sometimes you can use either, but usually one is a better choice than the other. You can't always expect to use the less appropriate one and get away with it (speed-wise).

Sheesh

Quote:

---

The code in the game is more complex, but this code below gives the right idea (I've used an array instead of a linked list for simplicity)

---