Trouble with overloading operators in a class with composition relationship

Hello,

I have been working on this code for a week. I have a point class I created and got everything working. Then I had to create a circle class from the point class. Originally I used an inheritance relationship, then I rewrote the code for a composition relationship. I got everything working in the circle class. Then, moved on to a cylinder class that has a composition relationship to the circle class. I finally have all the functions working in this class, with the exception of the cylinder calc functions that use a circle calc function. I think it is because I need to overload the '+' and '*' to perform their operation on the circle class function. So, I went looking in my textbook and the other four books I purchased for additional reference. And, none of them explain the operator overloading sufficiently to apply it to my need.

If anyone can help me by explaining what the body of my operator overload functions should look like I would appreciate it.

Here is my cylinderType class definition in my header file:

Code:

---

#ifndef H_CYLINDER
#define H_CYLINDER

#include "circleClass.h"

class cylinderType: public circleType
{
        public:
                cylinderType();
                cylinderType(int xCoord, int yCoord, int radius, int height);

                void setHeight(int height);
                void setCylinder(int xCoord, int yCoord, int radius, int height);
                void setRadius(int radius);
                void setCircle(int xCoord, int yCoord, int radius);
                void setPoint(int xCoord, int yCoord);
                void getHeight(int & height);
                void getCylinder(int & xCoord, int & yCoord, int & radius, int & height);
                void getRadius(int & radius);
                void getCircle(int & xCoord, int & yCoord, int & radius);
                void getPoint(int & xCoord, int & yCoord);

                cylinderType operator+(const cylinderType &) const;
                cylinderType operator*(const cylinderType &) const;

                double calcLateralSurfArea();
                double calcVolume();
                double calcArea();
                double calcCircum();
               
                void whereAmI();
                void printLateralSurfArea();
                void printVolume();
                void printHeight() const;
                void printCylinder() const;
                void printArea();
                void printCircum();
                void printRadius() const;
                void printCircle() const;
                void printPoint() const;
               
        private:
                pointType point;
                circleType circle;
                int h;
};

#endif

---

And, here is part of the cpp implementation file. I eliminated some of the functions to save space and they weren't part of the problem. My code does compile and work excluding the calc functions:

Code:

---

#include "cylinderClass.h"

cylinderType cylinderType::operator +(const cylinderType & right) const
{
        cylinderType temp;
        temp = ;
}

cylinderType cylinderType::operator *(const cylinderType & right) const
{
        cylinderType temp;
}

double cylinderType::calcLateralSurfArea()
{
        return (circle.calcCircum() * h);
}

double cylinderType::calcTotalSurfArea()
{
        int radius;
        return (circle.calcCircum() * (circle.getRadius(radius) + h));
}

double cylinderType::calcArea()
{
        return (circle.calcArea());
}

double cylinderType::calcVolume()
{
        return (circle.calcArea() * h);
}

void cylinderType::printLateralSurfArea()
{
        cout << "The Lateral Surface Area of a cylinder with ";
        circle.printRadius();
        cout <<        " and a height of " << h << " is ";
        calcLateralSurfArea();
        cout << endl;
}

void cylinderType::printTotalSurfArea()
{
        cout << "The Total Surface Area of a cylinder with a radius of ";
        circle.printRadius();
        cout << " and a height of " << h << " is ";
        calcTotalSurfArea();
        cout << endl;
}

void cylinderType::printVolume()
{
        cout << "The Volume of a cylinder with ";
        circle.printRadius();
        cout << " and a height of " << h << " is ";
        calcVolume();
        cout << endl;
}

---

I cannot figure out the operator overload function definition for this application from the reference books I have. They all use the private variables witin the class (private: int a, b; then the function definition uses: "temp.a = a + right.a; temp.b = b + right.b; return temp;" or something similar) I can't figure out how to apply that to my situation.

Thanks.

I recognized a problem with my cylinder calc functions. In the calcVolume(), calcTotalSurfaceArea() and calcLateralSurfaceArea() functions I have removed "circle." from the return statments because they are already defined as a cylinder function.

Before you start writing operators, ask if the operators make sense in the first place. What does it mean to add a cylinder to another cylinder? What about multiplying a cylinder by another cylinder?

Quote:

---

I cannot figure out the operator overload function definition for this application from the reference books I have. They all use the private variables witin the class (private: int a, b; then the function definition uses: "temp.a = a + right.a; temp.b = b + right.b; return temp;" or something similar) I can't figure out how to apply that to my situation.

---

When you have to implement operator+, I suggest also implementing operator+=, and then implementing operator+ in terms of operator+=. The reasoning is that operator+= is typically best as a member of the class, and it modifies the current object. operator+ is typically best as a non-member function. You could make it a friend function, but if operator+= exists, operator+ could be a non-member non-friend:

Code:

---

T operator+(const T& x, const T& y)
{
    return T(x) += y;
}

---

I guess I am not following...I am looking at, say: calcLateralSurfArea() and that mathematical formula is: 2* PI * r * h. which is the calcCircum() * h. That function isn't working - on my printLateralSurfArea() nothing does. So, in debugging I have come to the conclusion it is because I am using the '*' operator on a function and that isn't defined yet.

So from there I am trying to create the operator function and have stalled.

Quote:

---

I am looking at, say: calcLateralSurfArea() and that mathematical formula is: 2* PI * r * h. which is the calcCircum() * h

---

What does calcCircum() return? From what I see it returns a double, thus there is no operator overloading needed.

Then what else is happening for me to not have the amount print when it is called. My calcCircum() prints a result but the calcLateralSurfArea() does not.

Maybe my height isn't set right and therefore a '0'.

Since you want to use composition instead of inheritance, change:

Code:

---

class cylinderType: public circleType

---

To:

Code:

---

class cylinderType

---

Quote:

---

Then what else is happening for me to not have the amount print when it is called. My calcCircum() prints a result but the calcLateralSurfArea() does not.

---

I suspect that your calcLateralSurfArea() is not implemented correctly. As I pointed out in another thread you started, getX() type of functions tend to return a value. In your change, you have used a different idiom, namely to pass an argument by reference and use that argument as an output. As such, I guess that getRadius() from circleType returns void, so (circle.getRadius(radius) + h) is incorrect.

With your explanation, I understand the error I am getting with the calcTotalSurfArea(). getRadius() returns a void and I need the int radius to perform the calculation. How do I work around this? it is a getter so it is a void. But, there isn't a defined variable member just for radius, I have it as part of the circleType circle member variable. Does this mean I need a separate circleType r member variable in cylinder so I can call it separately in these calculation functions?

Code:

---

void cylinderType::getRadius(int & radius)
{
        circle.getRadius(radius);
}


double cylinderType::calcTotalSurfArea()
{
        int radius;
        return (calcCircum() * (getRadius(radius) + h));
}

---

I get '+' : illegal operand of type 'void'

Quote:

---

How do I work around this? it is a getter so it is a void.

---

One option is to change it such that your getters return values. If not, you have to resort to a more long winded way:

Code:

---

double cylinderType::calcTotalSurfArea()
{
    int radius;
    getRadius(radius);
    return calcCircum() * (radius + h);
}

---

I guess I am really confused. This chapter talks about inheritance, composition, function overloading, the pointer *this, friend functions, operator overloading, function templates and class templates all in 49 pages. I must have everything mixed up and confused.

All of the examples in the text have the getter functions as a void return. So, I concluded that getters and setters didn't return anything.

I also thought that " derived class : base class " was necessary for both inheritance and composition. But composition included a base class type variable in the member variable list.

I think I am really confused. This is an 8 week online class where it is really self study - read the book write the programs and take the tests. The instructor really doesn't. I have learned more about my code errors from this forum than I have in two weeks of emails with the instructor.

Quote:

---

All of the examples in the text have the getter functions as a void return. So, I concluded that getters and setters didn't return anything.

---

As far as I know, there is no rule in the C++ standard that says that getters and setters must or must not return anything. This is all a matter of how you want to design your class' public interface. In fact, in many situations you may not want getters and setters at all.

In this case, your getter does not return anything, so it cannot directly participate in your formula. You have to use it to get the radius value into the radius variable, and then have the radius variable participate in the formula.

Quote:

---

I also thought that " derived class : base class " was necessary for both inheritance and composition. But composition included a base class type variable in the member variable list.

---

It is only necessary for inheritance. Where composition is not concerned with base classes or derived classes. It is merely concerned with classes and the members they own.

Quote:

---

I also thought that " derived class : base class " was necessary for both inheritance and composition. But composition included a base class type variable in the member variable list.

---

Composition:

Code:

---

class Door {};
class Window {};
class Car {
    Door door[4];
    Window window[4];
    Window windscreen;
};

---

Inheritance:

Code:

---

class Vehicle {};
class Car : public Vehicle {};
class Toyota : public Car {};

---

Thank You! You have explained a lot.

I realize the more I do the more I will learn, but the class deadline is hanging over my head, and causing immeasureable stress. I am still on program 4 of lesson 1. Each lesson covers 2 or 3 chapters and has a test that includes 5 programs to be submitted. The programs are worth just 4 points each. So, I could realistically not write a line of code and pass the class. But that is not what I feel is in the best interest of learning data structures.

Thank you laserlight, you have come to my aid again.

I am still having issues with my cylinder calc functions. I can't figure out what I am missing.

These print out fine:

Code:

---

double cylinderType::calcArea()
{
        return (circle.calcArea());
}

void cylinderType::printArea()
{
        circle.printArea();
}

double cylinderType::calcCircum()
{
        return (circle.calcCircum());
}

void cylinderType::printCircum()
{
        circle.printCircum();
}

---

These print do not print the Volume, Total Surface Area, nor Lateral Surface Area and I can't find the problem. Any suggestions where to look?

Code:

---

double cylinderType::calcVolume()
{
        return (calcArea() * h);
}

void cylinderType::printVolume()
{
        cout << "The Volume of a cylinder with ";
        circle.printRadius();
        cout << " and a height of " << h << " is ";
        calcVolume();
        cout << endl;
}

double cylinderType::calcTotalSurfArea()
{
        int radius;
        getRadius(radius);
        return (calcCircum() * (radius + h));
}

void cylinderType::printTotalSurfArea()
{
        cout << "The Total Surface Area of a cylinder with a radius of ";
        circle.printRadius();
        cout << " and a height of " << h << " is ";
        calcTotalSurfArea();
        cout << endl;
}

double cylinderType::calcLateralSurfArea()
{
        return (calcCircum() * h);
}

void cylinderType::printLateralSurfArea()
{
        cout << "The Lateral Surface Area of a cylinder with ";
        circle.printRadius();
        cout <<        " and a height of " << h << " is ";
        calcLateralSurfArea();
        cout << endl;
}

---

Code:

---

        cout << "The Volume of a cylinder with ";
        circle.printRadius();
        cout << " and a height of " << h << " is ";

---

Might want to say something like "... a radius of ..." in there.

Code:

---

double cylinderType::calcVolume()
{
        return (calcArea() * h);
}

void cylinderType::printVolume()
{
        cout << "The Volume of a cylinder with ";
        circle.printRadius();
        cout << " and a height of " << h << " is ";
        calcVolume();
        cout << endl;
}

---

calcVolume() returns the volume, it doesn't print it. You need to actually print the value, with something like

Code:

---

double cylinderType::calcVolume()
{
        return (calcArea() * h);
}

void cylinderType::printVolume()
{
        cout << "The Volume of a cylinder with ";
        circle.printRadius();
        cout << " and a height of " << h << " is " << calcVolume() << endl;
}

---

In your print* functions, you consistently forget to actually write out the values you calculate.

UGH!!! THAT IS IT!!! I have been staring at this code for hours trying to figure out what the problem was. So simple...I feel foolish.

Thanks, DWKS.

BTW I have visited your links, helpful, thanks.

Thanks CornedBee, That is what DWKS just sugested, and ... something so simple and should be caught so easily, yet I have been staring at it for so long, I couldn't see it.

Yahoo! This test question is complete, I get to move on to the rational fraction class code.

Thank you ALL.

The help from this forum will save me in this class, if I can be saved!

Lord knows it won't be because of help from the instructor!