Better way maybe... but need assistance

I have a function to determine a letter grade for each individual grades however I am not sure I have it set up the best possible way.. the errors I am getting are at the bottom.. There is three test grades but that would be alot of if elses... could someone help me on this... I am so new at this and am about to pull my hair out... :confused:

Code:

---


  #include <stdio.h>
  #include <string.h>
  #include <stdlib.h>



  void readfile(char name, int grade1,int grade2,int grade3);
  int meangrade(int grade1,int grade2,int grade3);
  void display(char name, int grade1,int grade2,int grade3);
  int qsort(char name, int grade1, int grade2, int grade3, int meangrade);

    struct grades
    {
    char students[30];
    int grade1;
    int grade2;
    int grade3;
    };

      struct grades name[30], g1, g2, g3,*gptr;

      FILE *infile;
      FILE *outfile;

    int main(int argc, char **argv) {
    {
      char filename;
      int choice, exam;
   
      FILE *infile = fopen("grade.txt", "r");
      FILE *outfile = fopen("grades.txt","w");


      printf ("Please enter the filename needed:  \n");
      scanf("%c", &filename);
      printf("Please enter 1 for a specific exam to be displayed or 0 to exit. \n");
      scanf("%d", &choice);
        if (choice == 0)
            display;
        else
            printf("Goodbye....\n");

      fclose(infile);
      fclose(outfile);

      return 0;
  }
      void readfile(char filename,char name[30],int grade1,int grade2,int grade3){
      fscanf(infile,"%c %d%d%d", name[30], &grade1, &grade2,&grade3);
}
      int meangrade(int grade1,int grade2,int grade3,int meangrade){
      meangrade = (grade1 +grade2 +grade3)/3;
      return meangrade;
    }

      void display(char filename,char name[30], int grade1,int grade2,int grade3){
      int exam;
      printf("Which exam number would you like to see?    ");
      scanf("%d", &exam);
          if (exam > 3){
          printf("Please enter a valid exam number:  ");
          scanf("%d", &exam);
          }else
          fprintf(infile,"%s%d%d%d", name[30], &grade1,&grade2, &grade3);
        }


      void lettergrade(char letter, int grade1, int grade2, int grade3){
          if (grades > 85){
              printf("A");
          }else if  (grades > 70 || grades< 84){
              printf("B");
          } else if (grades >55 || grades < 69){
              printf("C");
            }else if (grades>40 || grades<54){
              printf("D");
            }else{
              printf("F");
          }
}


          int sorting(struct grades students[30] grade1 grade2, grade3,){
          int j, max;
          for(j = 0; j < 100; ++j) {
              if (students[j].grade1 > students[j].grade2)
                  max = students[j].grade1;
              else
                  max = students[j].grade2;
              if (students[j].grade3 > max)
                  max = students[j].grade3;
          return max;
        }
  }

---

Code:

---

grades.c: In function `lettergrade':
grades.c:77: `grades' undeclared (first use in this function)
grades.c:77: (Each undeclared identifier is reported only once
grades.c:77: for each function it appears in.)
grades.c: In function `main':
grades.c:93: parse error before "grade1"
grades.c:106: parse error at end of input

---

Code:

---

      int meangrade(int grade1,int grade2,int grade3,int meangrade){
      meangrade = (grade1 +grade2 +grade3)/3;
      return meangrade;
    }

---

meangrade is not a declared variable. Other languages, like VB, force you to return values like this, but in C you do not. You have to declare an int variable to return, and it cannot be meangrade, since that is the function name.

same thing in lettergrade(), grades was never declared. Don't worry about a lot of if else's. It gets the job done, and sometimes it's the only way to do what you want.

getting this error message. Don't understand why?

grades.c:89: conflicting types for `sorting'
grades.c:18: previous declaration of `sorting'

Code:

---

int sorting(struct grades students[30], int grade1, int grade2, int grade3) {

          int j, max;
          for(j = 0; j < 100; ++j) {
              if (students[j].grade1 > students[j].grade2){
                  max = students[j].grade1;
              }else{
                  max = students[j].grade2;
              }if (students[j].grade3 > max){
                  max = students[j].grade3;
            }
          return max;

---

You mind showing us line 18 and line 89 please.

Code:

---



Line 18: int sorting(char students[30], int grade1, int grade2, int grade3);

Line 89 int sorting(struct grades students[30], int grade1, int grade2, int grade3)

---

Line 18 is the def of the function and line 89 is the function itself... Sorry about that...

In the prototype you say the first parameter should be an array of characters, in the function header you say it should be an array of struct grades. Have to choose one and use it in both spots

So the fact that the two don't match isn't in the least bit odd to you?

If I make them both the same it gives me a new error..

grades.c:18: warning: `struct grades' declared inside parameter list
grades.c:18: warning: its scope is only this definition or declaration, which is probably not what you want.
grades.c:93: conflicting types for `sorting'
grades.c:18: previous declaration of `sorting'


and if I put it the other way...

Code:

---

int sorting(char students[30], int grade1, int grade2, int grade3);
int sorting(char students[30], int grade1, int grade2, int grade3) {
          int j, max;
          for(j = 0; j < 100; ++j) {
              if (students[j].grade1 > students[j].grade2){
                  max = students[j].grade1;
              }else{
                  max = students[j].grade2;
              }if (students[j].grade3 > max){
                  max = students[j].grade3;
            }
          return max;
        }
  }

---

grades.c: In function `sorting':
grades.c:96: request for member `grade1' in something not a structure or union
grades.c:96: request for member `grade2' in something not a structure or union
grades.c:97: request for member `grade1' in something not a structure or union
grades.c:99: request for member `grade2' in something not a structure or union
grades.c:100: request for member `grade3' in something not a structure or union
grades.c:101: request for member `grade3' in something not a structure or union

It's an order thing - if you prototype a function using a struct before the struct itself is in scope, C thinks you're declaring the struct in the prototype itself

Code:

---

    struct grades
    {
    char students[30];
    int grade1;
    int grade2;
    int grade3;
    };

// now do
int sorting(struct grades students[30], int grade1, int grade2, int grade3);

// and make your function definition match that prototype

---

Thank you that worked great now I have another issue.. I am trying to call a function and I am getting the following errors.

grades.c: In function `main':
grades.c:43: incompatible type for argument 1 of `readfile'
grades.c:43: incompatible type for argument 2 of `readfile'
grades.c:43: incompatible type for argument 3 of `readfile'
grades.c:43: incompatible type for argument 4 of `readfile'

Here is the code

Code:

---


 readfile(students[i], grade1, grade2,grade3); /* here is where I am trying to call it.*/


/* Here is the function itself...*/
void readfile(char students[30], int grade1, int grade2, int grade3){
        int choice;
        printf("Please enter 1 for a specific exam to be displayed or 0 to exit. \n");
        scanf("%d", &choice);
        if (choice == 1){
            display;
        }else{
            printf("Goodbye....\n");}
          fscanf(infile,"%s %d%d%d", students[30], &grade1, &grade2,&grade3);

  }

---

Are you passing it an array of 30 characters for the first argument?
Are you passing it an integer for the second, third, and fourth arguments?

Quzah.

yes I am passing the array for the first argument and then integers for the rest... Now it can be no more then 30 students... ..

I'm willing to bet you aren't passing an array of characters for the first parameter. Of course it'll help if you actually show the variable declartions for the function that you call from.

I am also.

Code:

---

readfile(students[i], grade1, grade2,grade3); /* here is where I am trying to call it.*/

---

So 'students' is a two dimensional array? And you're passing one of those arrays, located at i to the function?

Quzah.

Maybe this is more help....

Code:

---



void readfile(char students[30], int grade1,int grade2,int grade3);/*function declaration*/


readfile(students[30], grade1, grade2,grade3); /*calling the function*/

void readfile(char students[30], int grade1, int grade2, int grade3)
/*Function itself.*/
{
        int choice;
        printf("Please enter 1 for a specific exam to be displayed or 0 to exit. \n");
        scanf("%d", &choice);
        if (choice == 1){
            display;
        }else{
            printf("Goodbye....\n");}
          fscanf(infile,"%s %d%d%d", students[30], &grade1, &grade2,&grade3);

  }

---

no because we don't know what students is, what grade1 is, what grade2 is, etc. Thats why I said variable declartion

sorry misunderstood.. Here you go..

Code:

---


 struct grades  /*Structure to put the text into.*/
    {
    char students[30];
    int grade1;
    int grade2;
    int grade3;
    };
  struct grades students[30], grade1, grade2, grade3;

---

Ok so right now students is an array of struct grades. grade1, grade2, grade3 are all struct grades.

So when you call

Code:

---

readfile(students[30], grade1, grade2,grade3);

---

all the parameters are grades not an array of char, an int, an int, an int.

Oh, so it's like I said, you aren't passing the arguments correctly. Do you see what you're doing here? You should, because I already mentioned it to you once.

Code:

---

struct grades students[30], grade1, grade2, grade3;

---

Let's use the Way-Back-Machine(TM) and see exactly what it was I wrote...

Quote:

---

Originally Posted by quzah

To be precise, it's an array of 30 structures, plus 3 individual ones, and a pointer to a structure.

Quzah.

---

The only thing different is that you got rid of the pointer. I don't think you really understand what a structure is.

Quzah.

I am not passing the structure though.. I am only passing the things in the structure.. such as the students, grade1, grade2, grade3.... Then what do I have to do to get rid of the errors and call the function properly... I am a little confused here... :confused:

No you aren't. If you did you would have something like

Code:

---

somevar.grade1

---

So how do I correct it or what can I do to fix it.. Your statement was a little vague for me... I am still new at this so I am a little slow... sorry.... :confused:

Well I'd suggest you read up on how to use a structure.
http://faq.cprogramming.com/cgi-bin/...&id=1073086407

here is another one to help you better understand.