C++ Video Game Player Program

ok so I have a program that is supposed to use arrays and this is the week we start learning arrays. The program is supposed to allow the user to input scores for a number of players up to 100 players and then it will post all scores as well as calculate averages and show who has a below average score. My issue is that for some reason I am not getting the multiple players to display nor will any of there scores and the calculateAverage function doesnt seem to be working. Here is the code I have:

Code:

---

#include <iostream>
#include <iomanip>
#include <string>

using namespace std;

const int ARRAY_SIZE = 100;
void InputData(string playerNameAr[], int scoreAr[], int &numPlayersRef);
void DisplayPlayerData(const string playerNameAr[], const int scoreAr[], int numPlayers);
double CalculateAverageScore(const int scoreAr[], int numPlayers);
void DisplayBelowAverage(const string playerNameAr[], const int scoreAr[], int numPlayers, double averageScore);

void main()
{
        string playerNameAr[ARRAY_SIZE];
        int scoreAr[ARRAY_SIZE];
        int numPlayers = 0;
        int numPlayersRef = 0;
        double averageScore = 0;

        cout << fixed << showpoint << setprecision(2);
        InputData(playerNameAr, scoreAr, numPlayersRef);
        DisplayPlayerData(playerNameAr, scoreAr, numPlayers);
        CalculateAverageScore(scoreAr, numPlayers);
        DisplayBelowAverage(playerNameAr, scoreAr, numPlayers, averageScore);
        system("PAUSE");
}
void InputData(string playerNameAr[], int scoreAr[], int &numPlayersRef)
{
        while(numPlayersRef < ARRAY_SIZE)
        {
                cout << "Please enter player's name (press Q to quit):  ";
                getline(cin, playerNameAr[numPlayersRef], '\n');
                cout << endl;
                if ((playerNameAr[numPlayersRef] == "Q") || (playerNameAr[numPlayersRef] == "q"))
                        break;
                cout << "Please enter " << playerNameAr[numPlayersRef] << "'s score:  ";
                cin >> scoreAr[numPlayersRef];
                cout << endl;
                cin.ignore();
                numPlayersRef++;
        }
}

void DisplayPlayerData(const string playerNameAr[], const int scoreAr[], int numPlayers)
{
        cout << setw(10) << left << "\n Name"
                << setw(5) << right << "Score" << endl;
        for (int i = 0; i < numPlayers; i++)
        {
                cout << setw(10) << left << playerNameAr[numPlayers]
                << setw(5) << right << scoreAr[numPlayers] << endl;
        }
}

double CalculateAverageScore(const int scoreAr[], int numPlayers)
{
        int i;
        double averageScore = 0, totalScore;
        for (i = 0, totalScore = 0; i < numPlayers; i++)
        {
                totalScore += scoreAr[i];
        }
        averageScore = totalScore/i;
        cout << fixed << showpoint << setprecision(2);
        cout << averageScore << endl << endl;
        return averageScore;
}
void DisplayBelowAverage(const string playerNameAr[], const int scoreAr[], int numPlayers, double averageScore)
{
        cout << "Players who scored below average\n";
        cout << setw (10) << left << "Name"
                << setw(5) << right << "Score" << endl;
        for (int i = 0; i < numPlayers; i++)
                if(scoreAr[i] < averageScore)
                        cout << setw (10) << left << playerNameAr[i]
                << setw(5) << right << scoreAr[i] << endl;
}

---

void InputData(string playerNameAr[], int scoreAr[], int &numPlayersRef)

Needs to be:

void InputData(string& playerNameAr[], int& scoreAr[], int &numPlayersRef)

Quote:

---

Originally Posted by Alexandre

void InputData(string playerNameAr[], int scoreAr[], int &numPlayersRef)

Needs to be:

void InputData(string& playerNameAr[], int& scoreAr[], int &numPlayersRef)

---

Why?!

Quote:

---

Originally Posted by Alexandre

void InputData(string playerNameAr[], int scoreAr[], int &numPlayersRef)

Needs to be:

void InputData(string& playerNameAr[], int& scoreAr[], int &numPlayersRef)

---

thats not allowed with arrays.

Are you allowed (by your instructor) to use vectors then ?

@GReaper: He is handing over a copy of these objects and expecting modifications to happen. Obviously the object returns unchanged and DisplayPlayerData() has nothing to display.

Also I'm guessing you have not seen them in class yet but I would feel bad if I didn't mention that obviously you should use a struct/class to hold player data.

Quote:

---

Originally Posted by Alexandre

@GReaper: He is handing over a copy of these objects and expecting modifications to happen. Obviously the object returns unchanged and DisplayPlayerData() has nothing to display.

---

That is not applicable to ordinary arrays. They are always passed by address.


The OP's problem, (along *many* other things) is that the input buffer is not empty when the loop repeats.

Tells you how often I use arrays :/ I normally almost exclusively use STL containers :\

1. There is no such thing as void main. Read How to define main()-FAQ
2. You should make an array of structures here, with each structure representing a player: Lesson 7:Structs
3. You are didn't declare numPlayersRef to be a reference, you declared it to be an int. Hence your display loop never executes.
4. Same problem with you average loop.

So for numPlayersRef to actually be a reference to numPlayers you would:

Code:

---

int numPlayers = 0;
int &numPlayerRef = numPlayers;

---

However that isn't needed, your add players function should just be:

Code:

---

int main()
{
        string playerNameAr[ARRAY_SIZE];
        int scoreAr[ARRAY_SIZE];
        int numPlayers = 0;
        double averageScore = 0;

        cout << fixed << showpoint << setprecision(2);
        InputData(playerNameAr, scoreAr, numPlayers);
        DisplayPlayerData(playerNameAr, scoreAr, numPlayers);
        CalculateAverageScore(scoreAr, numPlayers);
        DisplayBelowAverage(playerNameAr, scoreAr, numPlayers, averageScore);
       
            system("PAUSE");
            return(0);
}
void InputData(string playerNameAr[], int scoreAr[], int &numPlayersRef)
{
              ....

---

Note: You need to change your prototype too.

Quote:

---

Originally Posted by AndrewHunter

You are didn't declare numPlayersRef to be a reference, you declared it to be an int. Hence your display loop never executes

---

That isn't necessary.

Quote:

---

Originally Posted by manasij7479

That isn't necessary.

---

Look at the OPs original code before you go around pulling out single statements from my response. He has two values declared in main:
int numPlayers;
int numPlayersRef;

Guess which one he passes to his input function and guess which one he passes to his print / average functions.

Quote:

---

Originally Posted by AndrewHunter

Look at the OPs original code before you go around pulling out single statements from my response. He has two values declared in main:
int numPlayers;
int numPlayersRef;

Guess which one he passes to his input function and guess which one he passes to his print / average functions.

---

Sorry, missed that. I don't know why there are two values though.

Quote:

---

Originally Posted by manasij7479

Sorry, missed that. I don't know why there are two values though.

---

I came across too harsh, and I am sorry; too early in the morning (haven't finished my cup of coffee :biggrin: ). He doesn't need it as I pointed out in my post.

Quote:

---

Originally Posted by AndrewHunter

I came across too harsh, and I am sorry; too early in the morning (haven't finished my cup of coffee :biggrin: ). He doesn't need it as I pointed out in my post.

---

I think I understand my issue with the numplayersref

I just need to make all of my code numPlayers and take out the "ref"
correct?

mana I am not sure I understand what you mean by the input buffer not being cleared out. I though the cin.ignore was supposed to free that all up before the loop restarted.

and andrew hunter,

We have not yet learned about these structs that you talked about nor is it anything that I could use in my code so I am oblivious to what you are telling me to do with it.

Quote:

---

Originally Posted by zonen

I think I understand my issue with the numplayersref

I just need to make all of my code numPlayers and take out the "ref"
correct?

---

Yes, just like I showed you in my post. If you can't use structs don't use them than. My point 1 still needs to be addressed though. (no such thing as void main).

Quote:

---

Originally Posted by zonen

mana I am not sure I understand what you mean by the input buffer not being cleared out. I though the cin.ignore was supposed to free that all up before the loop restarted.

---

You need a cin.ignore() after each input statement based on how you are doing things.

Is there any reason for this?

Code:

---

double averageScore = 0, totalScore;
        for (i = 0, totalScore = 0; i < numPlayers; i++)

---

It seems there for no good reason other than to confuse yourself, just initialise the totalScore right where you do the averageScore, silly constructs like that are totally out of context IMO !

Quote:

---

Originally Posted by zonen

mana I am not sure I understand what you mean by the input buffer not being cleared out. I though the cin.ignore was supposed to free that all up before the loop restarted.

---

Quote:

---

You need a cin.ignore() after each input statement based on how you are doing things.

---

vanilla cin.ignore() is not sufficient here ... AFAIK .
You need

Code:

---

cin.ignore(numeric_limits<streamsize>::max(),'\n');

---

To clear out all the trailing characters.
btw...you'd need to include <limits> for that.

Quote:

---

Originally Posted by manasij7479

vanilla cin.ignore() is not sufficient here ... AFAIK .
You need

Code:

---

cin.ignore(numeric_limits<streamsize>::max(),'\n');

---

To clear out all the trailing characters.
btw...you'd need to include <limits> for that.

---

mana is there any tutorials on how that statement you posted works because I haven't seen anything on limits<streamsize>::max() before. Is this going to have to go after all of my input statements?

I will try to research the <limits> and see if I can research it better then find out if I can use it in this assignment.

Quote:

---

Originally Posted by zonen

mana is there any tutorials on how that statement you posted works because I haven't seen anything on limits<streamsize>::max() before. Is this going to have to go after all of my input statements?

I will try to research the <limits> and see if I can research it better then find out if I can use it in this assignment.

---

Not always, but when the situation is somewhat like; you expect a single character y/n answer and get words like Yes, No, Nope ..and the program needs to use the input for other reasons after that.

numeric_limits can be used to determine the max or min size/range of type passed (and many other safety tricks !) in the <> brackets.
numeric_limits - C++ Reference

Then, the you can easily find out how it works, by examining the prototype of istream::ignore - C++ Reference .

Quote:

---

Originally Posted by manasij7479

Not always, but when the situation is somewhat like; you expect a single character y/n answer and get words like Yes, No, Nope ..and the program needs to use the input for other reasons after that.

numeric_limits can be used to determine the max or min size/range of type passed (and many other safety tricks !) in the <> brackets.
numeric_limits - C++ Reference

Then, the you can easily find out how it works, by examining the prototype of istream::ignore - C++ Reference .

---

so is this statement required after all of my input statements?

ok so my average is working now but the names are still not displaying from the arrays for me and the belowaverage function is not bringing anything up. Any ideas on what I am doing wrong?

Code:

---

#include <iostream>
#include <iomanip>
#include <string>

using namespace std;

const int ARRAY_SIZE = 100;
void InputData(string playerNameAr[], int scoreAr[], int &numPlayers);
void DisplayPlayerData(const string playerNameAr[], const int scoreAr[], int numPlayers);
double CalculateAverageScore(const int scoreAr[], int numPlayers);
void DisplayBelowAverage(const string playerNameAr[], const int scoreAr[], int numPlayers, double averageScore);

int main()
{
        string playerNameAr[ARRAY_SIZE];
        int scoreAr[ARRAY_SIZE];
        int numPlayers = 0;
        int numPlayersRef = 0;
        double averageScore = 0;

        cout << fixed << showpoint << setprecision(2);
        InputData(playerNameAr, scoreAr, numPlayers);
        DisplayPlayerData(playerNameAr, scoreAr, numPlayers);
        CalculateAverageScore(scoreAr, numPlayers);
        DisplayBelowAverage(playerNameAr, scoreAr, numPlayers, averageScore);
        system("PAUSE");
}
void InputData(string playerNameAr[], int scoreAr[], int &numPlayers)
{
        while(numPlayers < 100 & playerNameAr[numPlayers]!= "Q")
        {
                cout << "Please enter player's name (press Q to quit):  ";
                getline(cin, playerNameAr[numPlayers], '\n');
                cout << endl;               
                if ((playerNameAr[numPlayers] == "Q") || (playerNameAr[numPlayers] == "q"))
                        break;
                cout << "Please enter " << playerNameAr[numPlayers] << "'s score:  ";
                cin >> scoreAr[numPlayers];
                cout << endl;
                cin.ignore(numeric_limits<streamsize>::max(),'\n');
                numPlayers++;
        }
}

void DisplayPlayerData(const string playerNameAr[], const int scoreAr[], int numPlayers)
{
        cout << setw(10) << left << "\n Name"
                << setw(5) << right << "Score" << endl;
        for (int i = 0; i < numPlayers; i++)
        {
                cout << setw(10) << left << playerNameAr[numPlayers]
                << setw(5) << right << scoreAr[numPlayers] << endl;
        }
}

double CalculateAverageScore(const int scoreAr[], int numPlayers)
{
        int i;
        double averageScore = 0, totalScore;
        for (i = 0, totalScore = 0; i < numPlayers; i++)
        {
                totalScore += scoreAr[i];
        }
        averageScore = totalScore/i;
        cout << fixed << showpoint << setprecision(2);
        cout << averageScore << endl << endl;
        return averageScore;
}
void DisplayBelowAverage(const string playerNameAr[], const int scoreAr[], int numPlayers, double averageScore)
{
        cout << "Players who scored below average\n";
        cout << setw (10) << left << "Name"
                << setw(5) << right << "Score" << endl;
        for (int i = 0; i < numPlayers; i++)
                if(scoreAr[i] < averageScore)
                        cout << setw (10) << left << playerNameAr[i]
                << setw(5) << right << scoreAr[i] << endl;
}

---

Quote:

---

Originally Posted by zonen

ok so my average is working now but the names are still not displaying from the arrays for me

---

Well, let's see:

Code:

---

//Logical AND is && not &
//Also use your constant ARRAY_SIZE here vice your magic number 100
while(numPlayers < 100 & playerNameAr[numPlayers]!= "Q")

---

Quote:

---

Originally Posted by zonen

and the belowaverage function is not bringing anything up. Any ideas on what I am doing wrong?

---

That is because you never store the result of your CalculateAverageScore function. In main you would need to have:

Code:

---

averageScore = CalculateAverageScore(scoreAr, numPlayers);

---

Quote:

---

Originally Posted by AndrewHunter

Well, let's see:

Code:

---

//Logical AND is && not &
//Also use your constant ARRAY_SIZE here vice your magic number 100
while(numPlayers < 100 & playerNameAr[numPlayers]!= "Q")

---

That is because you never store the result of your CalculateAverageScore function. In main you would need to have:

Code:

---

averageScore = CalculateAverageScore(scoreAr, numPlayers);

---

---

ya that makes perfect sense I completely overlooked the '&' I guess I didn't stop and think enough about how my calculate average funtion was really returning the average. I will give that a shot tonight and see if it starts running everything smoothly.

still no luck even with those changes from hunter. Issue still is with displaying the names from the arrays and there scores correctly. The average score function works perfectly but It will not print out the names or scores and the below average function is also not putting any names and scores in at the bottom.

Here is one problem:

Code:

---

void DisplayPlayerData(const string playerNameAr[], const int scoreAr[], int numPlayers)
...
    for (int i = 0; i < numPlayers; i++)
    {
        cout << setw(10) << left << playerNameAr[numPlayers]
        << setw(5) << right << scoreAr[numPlayers] << endl;
    }
...

---

Presumably you meant numPlayers to be i.

Applying my fix with previously mentioned fixes makes the output correct for me. If it does not for you, then provide up-to-date code and steps to get incorrect output.

Quote:

---

Originally Posted by Elysia

Here is one problem:

Code:

---

void DisplayPlayerData(const string playerNameAr[], const int scoreAr[], int numPlayers)
...
    for (int i = 0; i < numPlayers; i++)
    {
        cout << setw(10) << left << playerNameAr[numPlayers]
        << setw(5) << right << scoreAr[numPlayers] << endl;
    }
...

---

Presumably you meant numPlayers to be i.

Applying my fix with previously mentioned fixes makes the output correct for me. If it does not for you, then provide up-to-date code and steps to get incorrect output.

---

ya making that fix to the scores worked but how did you get the players names to come out correctly? for some reason I am not getting them to display at all.

Quote:

---

Originally Posted by zonen

ya making that fix to the scores worked but how did you get the players names to come out correctly? for some reason I am not getting them to display at all.

---

this is my code now which still is not displaying the players names when I enter them and the belowAverage function is still not displaying either.

Code:

---

#include <iostream>
#include <iomanip>
#include <string>

using namespace std;

const int ARRAY_SIZE = 100;
void InputData(string playerNameAr[], int scoreAr[], int &numPlayers);
void DisplayPlayerData(const string playerNameAr[], const int scoreAr[], int numPlayers);
double CalculateAverageScore(const int scoreAr[], int numPlayers);
void DisplayBelowAverage(const string playerNameAr[], const int scoreAr[], int numPlayers, double averageScore);

int main()
{
        string playerNameAr[ARRAY_SIZE];
        int scoreAr[ARRAY_SIZE];
        int numPlayers = 0;
        int numPlayersRef = 0;
        double averageScore = 0;
        averageScore = CalculateAverageScore(scoreAr, numPlayers);

        cout << fixed << showpoint << setprecision(2);
        InputData(playerNameAr, scoreAr, numPlayers);
        DisplayPlayerData(playerNameAr, scoreAr, numPlayers);
        CalculateAverageScore(scoreAr, numPlayers);
        DisplayBelowAverage(playerNameAr, scoreAr, numPlayers, averageScore);
        system("PAUSE");
}
void InputData(string playerNameAr[], int scoreAr[], int &numPlayers)
{
        while(numPlayers < ARRAY_SIZE && playerNameAr[numPlayers]!= "Q")
        {
                cout << "Please enter player's name (press Q to quit):  ";
                getline(cin, playerNameAr[numPlayers], '\n');
                cout << endl;               
                if ((playerNameAr[numPlayers] == "Q") || (playerNameAr[numPlayers] == "q"))
                        break;
                cout << "Please enter " << playerNameAr[numPlayers] << "'s score:  ";
                cin >> scoreAr[numPlayers];
                cout << endl;
                cin.ignore(numeric_limits<streamsize>::max(),'\n');
                numPlayers++;
        }
}

void DisplayPlayerData(const string playerNameAr[], const int scoreAr[], int numPlayers)
{
        cout << setw(10) << left << "\n Name"
                << setw(5) << right << "Score" << endl;
        for (int i = 0; i < numPlayers; i++)
        {
                cout << setw(10) << left << playerNameAr[numPlayers]
                << setw(5) << right << scoreAr[i] << endl;
        }
}

double CalculateAverageScore(const int scoreAr[], int numPlayers)
{
        int i;
        double averageScore = 0, totalScore;
        for (i = 0, totalScore = 0; i < numPlayers; i++)
        {
                totalScore += scoreAr[i];
        }
        averageScore = totalScore/i;
        cout << fixed << showpoint << setprecision(2);
        cout << averageScore << endl << endl;
        return averageScore;
}
void DisplayBelowAverage(const string playerNameAr[], const int scoreAr[], int numPlayers, double averageScore)
{
        cout << "Players who scored below average\n";
        cout << setw (10) << left << "Name"
                << setw(5) << right << "Score" << endl;
        for (int i = 0; i < numPlayers; i++)
                if(scoreAr[i] < averageScore)
                        cout << setw (10) << left << playerNameAr[i]
                << setw(5) << right << scoreAr[i] << endl;
}

---

scratch that I got the names to post properly but the below average function is not working.

What is not working? Furthermore, what steps did you take to make it not working?

Quote:

---

Originally Posted by Elysia

What is not working? Furthermore, what steps did you take to make it not working?

---

what is not working for me is the BelowAverage function. All of the rest of my code is printing out correctly but below average is not identifying whose scores are less then the average score calculated in Calculateaverage function and then posting those names in below average.

Go back to my post #24. When you were making your changes you dropped saving the return value of your calculate average function. So when you pass averageScore to your print below average function it is still 0.

Quote:

---

Originally Posted by AndrewHunter

Go back to my post #24. When you were making your changes you dropped saving the return value of your calculate average function. So when you pass averageScore to your print below average function it is still 0.

---

I got it now thank you so much for the tips. I just entered
averageScore = CalculateAverageScore(scoreAr, numPlayers);

into my belowAverageScore function so that it recognized that the value of average score was the return vale of my CalculateAverageScore function.