this-->array(pointer)

i have aproblem in operator, can you help me fix it?thanks for you.

Code:

---

const int size =10;
//
MyStack::MyStack()//constructor
{        SIZE=size;
        Arr= new int[size];
        index=0;
}
//
MyStack::~MyStack(){//detructor
        delete []Arr;
}
//
int MyStack::Pop(){
        if(index==0){
                cout<<"Stack Underflow.\n";
                //return NULL;
                exit(1);
        }
        index=index -1;
        return Arr[index];
}//
MyStack &MyStack::operator =(const MyStack &mystack){
        this->Arr=mystack.Arr;
        this->index=mystack.index;
        //this->SIZE=mystack.SIZE;
        return *this;
        //this->Pop=mystack.Pop;
}

---

You've bolded a line, but you do not state why you believe it to be an error.

Quote:

---

Originally Posted by tabstop

You've bolded a line, but you do not state why you believe it to be an error.

---

Code:

---

MyStack s,s1;

        s.Push(8);
        s.Push(6);
        s.Push(3);
        s.Push(2);
        s.Push(9);
        s.Push(9);
        s.Push(6);
        s1=s;
cout<<s.Pop()<<endl;       
        cout<<s1.Pop()<<endl;
        cout<<s1.Pop();

---

it will run to random, i need valuein s1.pop(), but it run to random, you can help me?.thanks :(.

Looking at the context, Arr is a pointer. You probably want to perform a deep copy (i.e., copy all the elements of the array) rather than just copy pointers.

If you mean that Pop will all of a sudden print addresses, that's not true.

The error on the line is that you leak the old memory of the stack and now your two stacks are sharing that internal array.

Yes right. i need a deep copy, but when it comple.. it output random. can u instructure for me. thanks.

So copy each element of the array over, is what we're saying.

Also, as tabstop has hinted: if the destination array is not large enough to store copies of all the elements of the source array, then you should create a temporary array at least as large as the source array, copy over the elements of the source array, then destroy the destination array and make the temporary array the new destination array.

Alternatively and preferably, you use a std::vector or std::deque instead of doing your own manual memory management.

true. can you example it. thanks

Quote:

---

Originally Posted by laserlight

Also, as tabstop has hinted: if the destination array is not large enough to store copies of all the elements of the source array, then you should create a temporary array at least as large as the source array, copy over the elements of the source array, then destroy the destination array and make the temporary array the new destination array.

Alternatively and preferably, you use a std::vector or std::deque instead of doing your own manual memory management.

---

but i study vector yet. if i can use destroy how? create one new array.

Quote:

---

Originally Posted by llynx

but i study vector yet.

---

You might want to use proper English so that you can be better understood. In this case, I assume that you meant to say that you have not studied vector yet.

Quote:

---

Originally Posted by llynx

if i can use destroy how?

---

By using delete[].

Quote:

---

Originally Posted by llynx

create one new array.

---

Yes, at least if you need to.

Good. thanks for laserlight and tabstop :)

but when i used destroy i can used it in function main()?

Quote:

---

MyStack s,s1;

s.Push(8);
s.Push(6);
s.Push(3);
s.Push(2);
s.Push(9);
s.Push(9);
s.Push(6);

s1=s;
cout<<s.Pop()<<endl;
cout<<s1.Pop()<<endl;
cout<<s1.Pop();
s.~MyStack();

---

If you have a reason to destroy a declared variable, then go ahead. (I strongly doubt that you have such a reason.)

beacause this first time i used function destroy, i still dont understand it. :(

Do you mean the first time you've ever written a destructor? You've used one in every program you've written (more or less); all variables are destructed when they go out of scope.

Thanks for you.