ReadData txt file

Hi ! I'm struggling this problem and I didn't find a solution for it.
I'm trying to read data from txt which the data of the txt file is about having size of matrix and coordination (x,y) according to the size where the value "1" located. it might have more than matrix on the same txt file. for example"

Code:

---

444
12
23
33
555
12
23
33
44

---

the size of the matrix is always signed as 3 digits,
for example in the first line of txt file there's 444, it says that the matrix size of matrix 4*4 and the value number one is located on matrix at coordination: 12 23 33
for second matrix which it's in size 5 as shown in fifth line in txt file 555, the value of number one in that matrix is located at coordination: 12 23 33 44 .

the output is to print all the matrixs that txt file input have with proper value as written in txt file.

I'm stuck in and not moving forward , How can I assign matrixs by coordination that are given in txt file? thanks alot!!

I've written this code for reading data from txt file but didn't work well!(wrong output)

Code:

---

int main()
{
    int i,j;
    double value[10000][10000];
    FILE *archivo;
    archivo = fopen("matrix.txt","r");
    if (archivo == NULL)
        exit(1);
    i=0;
    while (feof(archivo) == 0)
    {
        fscanf( archivo, "%lf %lf %lf", &value[i][0],&value[i][1],&value[i][2]);
        printf("%10.0f %f %f\n", value[i][0], value[i][1], value[i][2]);
        i++;
    }


    printf("My matrix:\n");
    for(j = 0; j < i; j++)
        printf("%10.0f %10.3f %10.3f\n", value[j][0], value[j][1], value[j][2]);


    fclose(archivo);
    return 0;
}

---

THANKS for your help !

> the size of the matrix is always signed as 3 digits,
> for example in the first line of txt file there's 444, it says that the matrix size of matrix 4*4
Are your matrices always square, or can they be rectangular?
In other words, does it matter which of the three 4's you take to be the size.

Can the size be larger than 10?
If not, then double value[10000][10000]; is just massive overkill.
Not to mention that it probably blows the stack before you've even begun.

How do you know that say 444 and 555 are matrix sizes, and not a coordinate?

Quote:

---

Originally Posted by Salem

> the size of the matrix is always signed as 3 digits,
> for example in the first line of txt file there's 444, it says that the matrix size of matrix 4*4
Are your matrices always square, or can they be rectangular?
In other words, does it matter which of the three 4's you take to be the size.

Can the size be larger than 10?
If not, then double value[10000][10000]; is just massive overkill.
Not to mention that it probably blows the stack before you've even begun.

How do you know that say 444 and 555 are matrix sizes, and not a coordinate?

---

For your first question, matrics always square. (doesn't matter), the first digit is indicating the size of the matrix, the other two digits are don't care, they are just found for declaration that "444" is a boundary that says new matrices with size 4 initiated ..

For your second question, Yes can be larger than 10.
For your last question, because the matrix are always square so we just need 2D span in other words just (x,y) and there's no z axis (x,y,z). the pattern of the input is like this:
*** size of matrices ** following by
*** coordination of that matrices**
*** size of matrices *** followed by
***coordination of that matrices***

> For your second question, Yes can be larger than 10.
OK, so how do you know that say 444 is a size and not a coordinate?

And how do you know whether 444 should be interpreted as 4,44 or 44,4.

As far as file formats go, it sucks.

Quote:

---

Originally Posted by Salem

> For your second question, Yes can be larger than 10.
OK, so how do you know that say 444 is a size and not a coordinate?

And how do you know whether 444 should be interpreted as 4,44 or 44,4.

As far as file formats go, it sucks.

---

I understand .. but what's confusing me how can I read lines until I face 3 digits like "444" which implies new matrices will begin ..
I mean like this:
444
12
13
23
555
what's the condition that I can use for splitting the begging of new matrices ..here if I face 555 I understand that new matrices would be initiated ..so what's the condition for?

Code:

---

int value;
while ( fscanf( archivo, "%d", &value) == 1 ) {
  if ( value >= 100 && value <= 999 ) {
    int size = value % 10;
  } else {
    int x = value / 10;
    int y = value % 10;
  }
}

---

But you haven't said what happens when any size of coordinate is greater than 10.

Quote:

---

Originally Posted by Salem

Code:

---

int value;
while ( fscanf( archivo, "%d", &value) == 1 ) {
  if ( value >= 100 && value <= 999 ) {
    int size = value % 10;
  } else {
    int x = value / 10;
    int y = value % 10;
  }
}

---

But you haven't said what happens when any size of coordinate is greater than 10.

---

I really appreciated your help ! (for your question what happened when any size of ..greater than 10 , lets assume it wouldn't happen -an assumption-.

I appreciate once again your code, but checking your code, I have my own code and I need to know what's the problem:
here's my code:

Code:

---

int main() {
    int i, j, F, D, size, num, row1, coL1;
    FILE *filep;
    double *ptr = NULL;
    double x;


    if((filep==fopen("NAME.txt", "r")) == NULL) {
        printf("\nFailed to open File.\n");
        return -1;
    }
    while (!feof(filep)) {
        if (fscanf(filep, "%u", &num) == 1) {
            printf("%d\n", num);
        }
        if (fscanf(filep, "%u%u%u", &size, &F, &D) == 3) {
            printf("%d%d%d\n", size, F, D);


            if (fscanf(filep, "%u%u", &row1, &coL1) == 2) {
                printf("%d%d\n", row1, coL1);
            }
        }
    }
}

---

the input:
in NAME.TXT is:

Code:

---

100
3 1 3
2 3
1 2
2 2
3 2
3 2 0
1 3
2 3
3 3 3
1 3
2 3

---

the output I got

Code:

---

100
313
23
1
222
32
3
201
32
3
333
13
2

---

the output isn't the same as the input, its values the same, but it's not organized .. any clue how to output the same output as the input?
I want to print what's found on NAME.txt on my screen with the same method that I'm using to print in my code!

what's wrong with my code? I want my output to be the same as the input NAME.txt and not messed up like what I've shown

thanks alot

> while (!feof(filep))
Have you read the FAQ?
Why it's bad to use feof() to control a loop - Cprogramming.com

I showed you the safe way, and you just went ahead and ignored it anyway.

> the input:
>in NAME.TXT is:
Oh right, so NOW it's all space separated.

Garbage in, garbage out.

Next time, be sure what you're posting.
I don't appreciate having time wasted on dead ends.

> printf("%d%d%d\n", size, F, D);
Yeah, try putting spaces between all your %d's, so 1 2 3 actually looks like 1 2 3 and not 123.

Quote:

---

Originally Posted by Salem

> while (!feof(filep))
Have you read the FAQ?
Why it's bad to use feof() to control a loop - Cprogramming.com

I showed you the safe way, and you just went ahead and ignored it anyway.

> the input:
>in NAME.TXT is:
Oh right, so NOW it's all space separated.

Garbage in, garbage out.

Next time, be sure what you're posting.
I don't appreciate having time wasted on dead ends.

> printf("%d%d%d\n", size, F, D);
Yeah, try putting spaces between all your %d's, so 1 2 3 actually looks like 1 2 3 and not 123.

---

but how can I tell my compiler when reach the end of the file as stop? so by !feof() command I can tell the pc to stop when there's no data on the txt file.
second off, how can I solve the problem? can you show me by a code to understand more? I've already tried .
my problem isn't having spaces in 123 or 1 2 3, my problem if you can see my output txt isn't the same as input txt, all the data messed up ..

in my input.txt the fourth line is 1 2 and in my output txt the fourth line is 1
so here's the prblem, the number 2 is written down in line fifth

thanks alot

The problem is: while reading from input.txt file, all the data on the output is messed up! and that's weird!!

Post your actual input file.

Not your attempt to read it and print it.

> but how can I tell my compiler when reach the end of the file as stop?
That's what the == 1 means on the fscanf() call.
It's testing that an integer was read from the file successfully.

Did you read the FAQ?
Did you understand the FAQ?

> my problem if you can see my output txt isn't the same as input txt, all the data messed up ..
Well that's down to you writing bad format strings without any spaces.

Quote:

---

Originally Posted by Salem

Post your actual input file.

Not your attempt to read it and print it.

> but how can I tell my compiler when reach the end of the file as stop?
That's what the == 1 means on the fscanf() call.
It's testing that an integer was read from the file successfully.

Did you read the FAQ?
Did you understand the FAQ?

> my problem if you can see my output txt isn't the same as input txt, all the data messed up ..
Well that's down to you writing bad format strings without any spaces.

---

but I've wrote this code:

Code:

---

int main() {
    int i, j, F, D, size, num, row1, coL1;
    FILE *filep;
    double *ptr = NULL;
    double x;


    if((filep==fopen("NAME.txt", "r")) == NULL) {
        printf("\nFailed to open File.\n");
        return -1;
    }
    while (!feof(filep)) {
        if (fscanf(filep, "%u", &num) == 1) {
            printf("%d\n", num);
        }
        if (fscanf(filep, "%u%u%u", &size, &F, &D) == 3) {
            printf("%d %d %d\n", size, F, D);


            if (fscanf(filep, "%u%u", &row1, &coL1) == 2) {
                printf("%d %d\n", row1, coL1);
            }
        }
    }
}


---

and still not having the correct output, still getting messed data on the output !!

Quote:

---

Originally Posted by RyanC

but I've wrote this code:
...
and still not having the correct output, still getting messed data on the output !!

---

It means, of course, your code is wrong... and Salem already explained why...

Quote:

---

Originally Posted by flp1969

It means, of course, your code is wrong... and Salem already explained why...

---

So how can I solve the problem?! I know that salem explained it but it's not obvious for me!

Have you found and read any documentation for fscanf()? You're not using this function correctly, this is the start of your problems. When you find and read some documentation of fscanf() pay particular attention to the information on the format specifiers, if you use the wrong specifier for the type of variable you invoke undefined behaviour.

Also read the link about why it is usually wrong to use EOF to control a data entry loop.

You also still need to post a sample of your input file (inside code tags please to preserve formatting).

Don't use feof in the control of a loop - i.e. That while loop.

Here is another FAQ explaining why...
Question 12.2

Hi I appreciate your guys your effort to help me.
my problem is this:
I want to read the data from txt file line by line which that data is like this pattern:
when the length of the data line of the txt file is three numbers as passing those three numbers(integers) to fun1 .
when the length of the data line of the txt file is two numbers as passing those two numbers (integers) to func2.
when the length of the data of the line of txt file is one number as passing one number to fun3.

for example if i have txt file like this:

1 2 3
3 4 5
3 4
2
4 5 6
then I want like this to do:
first line goes with its parameters to func1(int x=1,int y=2,int z=3)
second line goes with its parameters to func1(3,4,5)
third line goes with its parameters to func2(3,4)
fourth line goes with its parameters to func3(2)
fifth line goes with its parameters to func1(4,5,6);

any clue how can I start? I tried the code that already posted here but didn't work well.
there's no specified pattern for the number of integers in line, it might be one integer in line or two integer in line or three integers in line. (max three integer in line)

I tried also to pick up line by line as string and split it up but didn't work!


thanks alot

How's this?

Code:

---

char buff[BUFSIZ];
while ( fgets(buff,BUFSIZ,filep) ) {
  int v1,v2,v3;
  if ( sscanf(buff,"%d %d %d", &v1, &v2, &v3) == 3 ) {
    func1(v1,v2,v3);
  }
  else if ( sscanf(buff,"%d %d", &v1, &v2) == 2 ) {
    func2(v1,v2);
  }
  else if ( sscanf(buff,"%d", &v1) == 1 ) {
    func3(v1);
  } else {
    // it's borked
  }
}

---

Quote:

---

Originally Posted by Salem

How's this?

Code:

---

char buff[BUFSIZ];
while ( fgets(buff,BUFSIZ,filep) ) {
  int v1,v2,v3;
  if ( sscanf(buff,"%d %d %d", &v1, &v2, &v3) == 3 ) {
    func1(v1,v2,v3);
  }
  else if ( sscanf(buff,"%d %d", &v1, &v2) == 2 ) {
    func2(v1,v2);
  }
  else if ( sscanf(buff,"%d", &v1) == 1 ) {
    func3(v1);
  } else {
    // it's borked
  }
}

---

---

A minor optimization:

Code:

---

char buff[BUFSIZ];

while ( fgets(buff,BUFSIZ,filep) ) {
  int v1,v2,v3,count;

  count = sscanf("%d %d %d", &v1, &v2, &v3 );
  switch ( count )
  {
    case 1: func1(v1); break;
    case 2: func2(v1,v2); break;
    case 3: func3(v1,v2,v3); break;
    default: // error handlning...
      ...
  }
}

---

Notice sscanf() will return the number of consecutive conversions made.

OOOOppps! @laserlight caught an error here... fgets() will return NULL on error or EOF.
Sorry...

Quote:

---

Originally Posted by flp1969

Notice the test against EOF

---

Isn't that wrong, though? fgets returns a pointer to char, not an int, hence Salem's original implicit test for a non-null pointer is correct.

Quote:

---

Originally Posted by laserlight

Isn't that wrong, though? fgets returns a pointer to char, not an int, hence Salem's original implicit test for a non-null pointer is correct.

---

You are absolutely RIGHT! Sorry... :)
The snippet was edited....

Quote:

---

Originally Posted by laserlight

Isn't that wrong, though? fgets returns a pointer to char, not an int, hence Salem's original implicit test for a non-null pointer is correct.

---

Hi laser, I appreciate your help, and thanks for clarifications. also thanks for flp to make an effort.

I'm still stuck in and I tried many methods like getting line by line as string and splitting it to get every "number" and afterwards converting it by atoi function .. sounds horrible but didn't help me because I always arrive to null pointer error and have many errors in that method.
I tried the method that I declared here before but didn't help.

May you help me please how can I solve the problem? thanks alot.

Stop saying "you're stuck" and post the latest code.

Hi salem; this is my final code but it's not printing at all the parameters!!

for example I just used printf function for func1, func2,func3 ..

Code:

---

int main()
{
    int v1, v2, v3;
    char line[100000000];
    FILE *file = fopen("FILE.txt", "r");
    if (file != NULL)
    {
        /* or other suitable maximum line size */
        while (fgets(line, sizeof line, file) != NULL)
        {
            if (sscanf(line, "%d %d %d", &v1, &v2, &v3) == 3)
            {
                printf("%d %d %d\n", v1, v2, v3);
            } else if (sscanf(line, "%d %d", &v1, &v2) == 2) {
                printf("%d %d %d\n", v1, v2);
            } else if (sscanf(line, "%d", &v1) == 1) {
                printf("%d\n", v1);
            }
        }
    }
    else
        {
        printf("error file openning");
    }
    return 0;
}

---

FILE TXT is the same as:
60
4 1 4
607
4 5 6
3 1
4 2

> char line[100000000];
What are you smoking!?

Pick a reasonable size, like BUFSIZ

100MB FFS
Sheesh!

Quote:

---

Originally Posted by Salem

> char line[100000000];
What are you smoking!?

Pick a reasonable size, like BUFSIZ

100MB FFS
Sheesh!

---

it's not working either!
I changed to 100MB it, it runs and there's not output, it's just running and at the end tell me in command line : Process finished with exit code -1073741571 (0xC00000FD)

[code]

Code:

---

int main()
{
    int v1, v2, v3;
    char line[104857600];
    FILE *file = fopen("FILE.txt", "r");
    if (file != NULL)
    {
        /* or other suitable maximum line size */
        while (fgets(line, sizeof line, file) != NULL)
        {
            if (sscanf(line, "%d %d %d", &v1, &v2, &v3) == 3)
            {
                printf("%d %d %d\n", v1, v2, v3);
            } else if (sscanf(line, "%d %d", &v1, &v2) == 2) {
                printf("%d %d %d\n", v1, v2);
            } else if (sscanf(line, "%d", &v1) == 1) {
                printf("%d\n", v1);
            }
        }
    }
    else
        {
        printf("error file openning");
    }
    return 0;
}

---

Stop being an idiot, and make a decent buffer size.

Quote:

---

Originally Posted by Salem

Stop being an idiot, and make a decent buffer size.

---

Hi salem, I've done this code

Code:

---

int main()
{
    int v1, v2, v3;
    char line[10000];
    FILE *file = fopen("FILE.txt", "r");
    if (file != NULL)
    {
        /* or other suitable maximum line size */
        while (fgets(line, sizeof line, file) != NULL)
        {
            if (sscanf(line, "%d %d %d", &v1, &v2, &v3) == 3)
            {
                printf("%d %d %d\n", v1, v2, v3);
            } else if (sscanf(line, "%d %d", &v1, &v2) == 2) {
                printf("%d %d %d\n", v1, v2);
            } else if (sscanf(line, "%d", &v1) == 1) {
                printf("%d\n", v1);
            }
        }
    }
    else
        {
        printf("error file openning");
    }
    return 0;
}


---

it didn't output anything , I'm not kidding !

Nothing at all?
Not even your error message?

Works for me.

Code:

---

$ cat foo.c
#include <stdio.h>
int main()
{
    int v1, v2, v3;
    char line[BUFSIZ];
    FILE *file = fopen("foo.txt", "r");
    if (file != NULL)
    {
        /* or other suitable maximum line size */
        while (fgets(line, sizeof line, file) != NULL)
        {
            if (sscanf(line, "%d %d %d", &v1, &v2, &v3) == 3)
            {
                printf("V3 = %d %d %d\n", v1, v2, v3);
            } else if (sscanf(line, "%d %d", &v1, &v2) == 2) {
                printf("V2 = %d %d\n", v1, v2);      //!! WAS foo.c:16:24: warning: format ?%d? expects a matching ?int? argument [-Wformat=]
            } else if (sscanf(line, "%d", &v1) == 1) {
                printf("V1 = %d\n", v1);
            }
        }
    }
    else
        {
        printf("error file openning");
    }
    return 0;
}
$ cat foo.txt
60
4 1 4
607
4 5 6
3 1
4 2
$ gcc foo.c
$ ./a.out
V1 = 60
V3 = 4 1 4
V1 = 607
V3 = 4 5 6
V2 = 3 1
V2 = 4 2

---

Yes, your 2nd printf was broken.

Are compiler messages preventing you from making a valid executable?

Quote:

---

Originally Posted by Salem

Nothing at all?
Not even your error message?

Works for me.

Code:

---

$ cat foo.c
#include <stdio.h>
int main()
{
    int v1, v2, v3;
    char line[BUFSIZ];
    FILE *file = fopen("foo.txt", "r");
    if (file != NULL)
    {
        /* or other suitable maximum line size */
        while (fgets(line, sizeof line, file) != NULL)
        {
            if (sscanf(line, "%d %d %d", &v1, &v2, &v3) == 3)
            {
                printf("V3 = %d %d %d\n", v1, v2, v3);
            } else if (sscanf(line, "%d %d", &v1, &v2) == 2) {
                printf("V2 = %d %d\n", v1, v2);      //!! WAS foo.c:16:24: warning: format ?%d? expects a matching ?int? argument [-Wformat=]
            } else if (sscanf(line, "%d", &v1) == 1) {
                printf("V1 = %d\n", v1);
            }
        }
    }
    else
        {
        printf("error file openning");
    }
    return 0;
}
$ cat foo.txt
60
4 1 4
607
4 5 6
3 1
4 2
$ gcc foo.c
$ ./a.out
V1 = 60
V3 = 4 1 4
V1 = 607
V3 = 4 5 6
V2 = 3 1
V2 = 4 2

---

Yes, your 2nd printf was broken.

Are compiler messages preventing you from making a valid executable?

---

No; Im using compiler Clion (c99) does that matter?

It still not working; I guess my compiler not configuring "sscanf" function; what should I do?
What compiler are you using?

This?
CLion: A Cross-Platform IDE for C and C++ by JetBrains

"A cross-platform IDE for C and C++ "
That just means it's a tarted up text editor.

What is your compiler?

> I guess my compiler not configuring "sscanf" function; what should I do?
You're really in no position to make such guesses.

Working with Tool Windows - Help | CLion
I suggest you find whichever tool window contains the RAW output from the compiler.

> What compiler are you using?
Read my post, it says gcc.


Did you run the program from a console?
Or did you just select "Run..." in the IDE?
Because if you ran it within an IDE, the console window could have opened and closed before you'd even noticed it.