Help making a hollow rectangle with thickness border

Code:

---

#include <stdio.h>

main (void)
{
    //variables
    int width, height, thick, i, j;
   
    //user input
    printf("Enter the width of the rectangle.\n");
    scanf("%d", &width);
   
    printf("Enter the height of the rectangle.\n");
    scanf("%d", &height);
   
    printf("Enter the thickness of the rectangle's border.\n");
    scanf("%d", &thick);
   
  //making the box top
    for(i = 0; i < width; i++)
    {   
        printf("*");
    }

    printf("\n");

    //
    for(i = 0; i < (height-2); i++)
    {   
        printf("*");
               
        for(j = 0; j < (width-2); j++)
        {
            printf(" ");
        }
       
        printf("*");

        printf("\n");
        }
       
        //making the box bottom
        for(i = 0; i < width; i++)
        {
          printf("*");
    }
       
        printf("\n");
       
        system("PAUSE");
        return 0;
}

---

This code will produce hollow rectangles but I cannot put my head around where to insert or how to insert the border pieces.

Very new to this so I am looking for code help as well as advice. Please do not just use logic.

Sample output: BOXES SHOULD LOOK NORMAL, FORUM FORMATTING ERROR

Quote:

---

Problem 2: Hollow Rectangle
Print a hollow rectangle of asterisks to the screen. You must read in the width, height, and border thickness of the rectangle from the user. The meaning of these numbers is best understood through examples. If the user enters numbers that don't produce a valid rectangle, your program should instead print a message indicating that there is a problem with the input.

Sample output 1 (Program output is bold, user input is in italics)
Enter the width of the rectangle
8
Enter the height of the rectangle
7
Enter the thickness of the rectangle's border
3
********
********
********
*** ***
********
********
********

Sample output 2 (Program output is bold, user input is in italics)
Enter the width of the rectangle
12
Enter the height of the rectangle
6
Enter the thickness of the rectangle's border
2
************
************
** **
** **
************
************

Sample output 3 (Program output is bold, user input is in italics)
Enter the width of the rectangle
6
Enter the height of the rectangle
10
Enter the thickness of the rectangle's border
4
The thickness you specified is too great relative the width of the rectangle.

---

Here is the code for making the top and bottom borders:

Code:

---

  //making the box top
    for(i = 0; i < width; i++)
    {   
        printf("*");
    }

---

Now, just do that border times.

Border should be on all sides

As I posted in the old thread:

Code:

---

for each row
    for each column
        if row < thickness, print a wall
        if row > box size - thickness, print a wall
        if col < thickness, print a wall
        if col > box size - thickness, print a wall
        otherwise, print a space
    print newline

---

Quzah.

Quote:

---

Originally Posted by quzah

As I posted in the old thread:

Code:

---

for each row
    for each column
        if row < thickness, print a wall
        if row > box size - thickness, print a wall
        if col < thickness, print a wall
        if col > box size - thickness, print a wall
        otherwise, print a space
    print newline

---

Quzah.

---

I didn't understand if that means that my whole structure is wrong? (Very new)

It means exactly what it says it means. You can do it like that or you can do it other ways. Basically, you need to print N lines for the top thickness. Then you need to print N left edge and width - (N+N) spaces, and then N right edges ... for every line in the middle. Then you need to print N bottom edges.


Quzah.

Quote:

---

Originally Posted by quzah

It means exactly what it says it means. You can do it like that or you can do it other ways. Basically, you need to print N lines for the top thickness. Then you need to print N left edge and width - (N+N) spaces, and then N right edges ... for every line in the middle. Then you need to print N bottom edges.


Quzah.

---

Yea, like Ive said multiple times have no experience at this found some problems online to practice. If you just dont want to give an outright answer... well here is what I got with your logic, can you help.

Code:

---

#include <stdio.h>

int main(void)
{
    int i, j, colum, rows, border;
   
    printf("Enter the width: ");
    scanf("%d",&colum);
   
    printf("Enter the height: ");
    scanf("%d", &rows);

    printf("Enter border thickness: ");
    scanf("%d", &border);

// rectangle start
        for(i = 0; i < rows; i++)
        {
        for(j = 0; j < colum; j++)
        {
            if(rows < border)
            {
                printf("*");
            }
            if(rows > (rows - border))
            {
                printf("*");
            }
            if(colum < border)
            {
                printf("*");
            }
            if(colum > (rows - border))
            {
                printf("*");
            }
            else
            {
                printf(" ");
            }
            printf("\n");
        }
    }
    system("PAUSE");
    return(0);
}

---

doesnt work at all

You are printing a newline after each column, not after each row. "Doesn't work" doesn't tell me what your problem is.


Quzah.

It might be easier for you if you add a function to print n characters

void print_char( int n, char ch);

now in this function do a loop to print ch n times; then all you will have to do is call this to print the characters. It will help you clean up the loop you are trying to make to do the box.

There are several problems in the code. The first most glaring and obvious mistake is the "rows < border" lines. You are comparing against rows, which is the number of rows the rectangle is supposed to be made of.
Perhaps you've misinterpreted the logic. if row < thickness, print a wall basically means "if current row < thickness, print a wall."
Fix that first.

Secondly is another logic problem and the third is a off-by-one error. I recommend you try to take quzah's algorithm and write it down on paper and see how it behaves before going further.
Besides that, avoid system("pause"). Alternatives can be found here: http://cpwiki.sourceforge.net/pause_console

i am doing the same program and quzah you have helped alot but im stuck on one part. i cant figure out how to get the right border
when i run program for width : 12 height :6 and thickness:2 i get
**********
**********
**
**
**********
**********

heres my code

Code:

---

#include <stdio.h>

int main(void)
{
    int i, j, height, width, thickness;
   
    printf("Enter the width of the rectangle\n");
    scanf("%d",&width);
    printf("Enter the height of the rectangle\n");
    scanf("%d", &height);
    printf("Enter the thickness of the rectangle's border\n");
    scanf("%d", &thickness);

    if(thickness > width || thickness > height)
        printf("The thickness you specified is too great relative the width of the rectangle.\n");
       
        for(i = 0; i < height; i++)
        {
        for(j = 0; j < width - thickness*2; j++)
        {
           
            if(i < thickness)
                {
                    printf("*");  //prints top part
                }   
            if(i >= (height - thickness))
                {     
                    printf("*");  // prints bottom part
                }
               
          if(j < thickness)
              {
                  printf("*");  //prints left side
              }
            //if(j >= (width - thickness))
            //    {
          //        printf("*");        // for some reason this side wont print not sure if i did it wrong
          //        i++;
          //    }
               
        }   
       
          printf("\n");
         
}       


        system("PAUSE");
        return 0;
}

---

Isn't width supposed to be the entire width of the rectangle?
Then you may want to ask yourself why you have a condition in your loop that looks like
width - thickness*2

The best advice I can give is that you write down on paper how exactly the algorithm is supposed to work.
Once you realize how it works and picture it in your head, then it's time to code.
Also take a look at http://cpwiki.sourceforge.net/pause_console

Quote:

---

Originally Posted by quzah

You are printing a newline after each column, not after each row. "Doesn't work" doesn't tell me what your problem is.


Quzah.

---

That's because I can not understand what you're telling me before you at least critique what is and is not correct about my original piece of code. Also, it is difficult to express empathy in short text conversations, so I do want to state that I am asking in respect. :)

Quote:

---

Originally Posted by quzah

You are printing a newline after each column, not after each row. "Doesn't work" doesn't tell me what your problem is.


Quzah.

---

Oh that must be a lie - noobs tell us "it doesn't work", all the time!! :p :p :p

Quote:

---

Originally Posted by Adak

Oh that must be a lie - noobs tell us "it doesn't work", all the time!! :p :p :p

---

Using the logic formula produced the second piece of code I posted there and it does not produce boxes.

So where are you printing the spaces?

Code:

---

for each row
    for each column
        if row < thickness, print a wall
        if row > box size - thickness, print a wall
        if col < thickness, print a wall
        if col > box size - thickness, print a wall
        otherwise, print a space
    print newline

---

Quzah.

Quote:

---

Originally Posted by quzah

So where are you printing the spaces?

Code:

---

for each row
    for each column
        if row < thickness, print a wall
        if row > box size - thickness, print a wall
        if col < thickness, print a wall
        if col > box size - thickness, print a wall
        otherwise, print a space
    print newline

---

Quzah.

---

Does my else function not make sense where it is then?

I'm going to give a tip.
Let's start simple. Let width = 10, height = 10, thickness = 2.
Now let the console be a coordinate system with origin in the upper-left corner.
Let's see if you can follow me here.
Row zero. We print stars all the way.
Row one. We print stars all the way.
Row two. We print two stars, 6 spaces, then 2 stars. Right?
Repeat this for row 3-7.
Now repeat row 0-1 and we're done.

Let's try to generalize it.
If row is 0 or 1 OR row > is 8 or 9, always print a star for every column.
If row 2...7 AND column is 0 or 1 or 8 or 9, print a star.
Else, print a space.

Try implementing that first and the generalizing it to given values.

Elysia i would like to thank you. your logic helped a lot kinda feel bad that it took me this long to see it and how easy it seems now that i finally got it.
this is what i got

Code:

---

for(row = 0; row < height; row++)
        {
        for(column = 0; column < width; column++)
        {
             
            if(row < thickness)
                {
                    printf("*");  //prints top part
                }   
            if(row >= (height - thickness))
                {     
                    printf("*");  // prints bottom part
                }
            if(row >= thickness && row < (height - thickness) && column < thickness)
                {
                    printf("*");
                }
            if(row >= thickness && row < (height - thickness) && column > thickness && column <=(width - thickness))
                {
                    printf(" ");
                }   
            if(row >= thickness && row < (height - thickness) && column >=(width - thickness))
                {
                    printf("*");
                }

---