Binary data

Code:

---

  while(fileones.get(buffer, 1024))
  {
        send(mysocket, buffer, 1024, 0);
        ZeroMemory(buffer, 1024); // reset buffer
  }

---

Before asking where I declared mysocket, buffer, etc. It's all there, this is just the only part giving me trouble. It successfully sends 2 kbs(recv()'d and written to file on the other end), but that's it. The file is around 3mbs. If anyone could give me an idea as to why it only reads 2 kbs, that would be great. Thanks.

Oh I think it reads all 3MB, but you're assuming that send() always sends the whole buffer the first time you call it.
You need to check that send() actually sent the data (check the return result).

Also, your ZeroMemory() seems kinda pointless.

Also, what if your file isn't a multiple of 1024 bytes in length? You send an arbitrary amount of non-file data across the link.

Quote:

---

Originally Posted by Salem

You need to check that send() actually sent the data (check the return result).

---

I checked the return result, and both times it's 1024. It only runs through the while loop twice.

get(..) seems like a wierd function to use with a buffer like that on a binary file. It appends a null-terminator to the end.

Edit: I don't see why you're just reading small chunks of the file and sending them.

I'm doing it because I don't want to send the entire file in one send, since it's crashed the program before, and would not allow me to see the progress of the send.

Well, thanks anyway.

If you are using Windows, indicated by the use of ZeroMemory macro, you can use WSASend and the lpCompletionRoutine.

Are you sure you opened the file in binary mode?

Without the send(), can you read the file to the end anyway?

I got it to work by modifying the while loop, and using read() instead. Thanks for the replies everyone.