help with structure arrays

I read the rules, and no i'm not asking anyone to do my homework...I want to know what i'm doing wrong with these structure arrays. I've tried to figure it out but i still can't get it. Here's the code:

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <strings.h>

#define MAXSIZE 80

typedef struct {
    char name[80];
    double diam;
    double dist;
    int moons;
} myVar;


void printPlanets( myVar planetInfo[] )
{
    int i;

    for( i = 0; i < 8; i++ )
    {
        printf("Planet %d:\n", i);
        printf("\tname: %s\n", planetInfo[i].name);
        printf("\tdiameter: %g\n", planetInfo[i].diam);
        printf("\tdistance to the Earth: %g\n", planetInfo[i].dist);
        printf("\tnumber of moons: %d\n", planetInfo[i].moons);
    }
}

int main( int argc, char *argv[] )
{
    myVar planets[7];
    int i;
    FILE *in;

    if( argc == 2 )
    {
        in = fopen(argv[2], "r");
    }
    else
    {
        in = stdin;

    for( i=0; i < 8; i++ )
    {
        printf("Please enter the name of a planet: ");
        fgets(planets[i].name, MAXSIZE, in);
        printf("Please enter the diameter of the planed (km.): ");
        scanf("%g", planets[i].diam);
        printf("Please enter the planet's distance from the Earth: ");
        scanf("%g", planets[i].dist);
        printf("Please enter the number of moons for the planet: ");
        scanf("%d", planets[i].moons);

        if( i == 7 )
        {
            printf("Thank you, you entered the following data:\n");
        }
    }
    }

    printPlanets(planets);

    return 0;
}

---

Didn't test ur code...just saw three lines and found 1 error...its string.h not strings.h

I've always used strings.h in my class.

But that's not relevant, b/c i haven't put in the code yet that needs strings.h. I didn't use my MAXSIZE either...

Here is the corrected code...u were missing & in scanf()...and i think u should again see ur for loop...are u sure it should be < 8

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#define MAXSIZE 80

typedef struct {
    char name[80];
    double diam;
    double dist;
    int moons;
} myVar;


void printPlanets( myVar planetInfo[] )
{
    int i;

    for( i = 0; i < 8; i++ )
    {
        printf("Planet %d:\n", i);
        printf("\tname: %s\n", planetInfo[i].name);
        printf("\tdiameter: %g\n", planetInfo[i].diam);
        printf("\tdistance to the Earth: %g\n", planetInfo[i].dist);
        printf("\tnumber of moons: %d\n", planetInfo[i].moons);
    }
}

int main( int argc, char *argv[] )
{
    myVar planets[7];
    int i;
    FILE *in;

    if( argc == 2 )
    {
        in = fopen(argv[2], "r");
    }
    else
    {
        in = stdin;

    for( i=0; i < 8; i++ )
    {
        printf("Please enter the name of a planet: ");
        fgets(planets[i].name, MAXSIZE, in);
        printf("Please enter the diameter of the planed (km.): ");
        scanf("%g", &planets[i].diam);
        printf("Please enter the planet's distance from the Earth: ");
        scanf("%g", &planets[i].dist);
        printf("Please enter the number of moons for the planet: ");
        scanf("%d", &planets[i].moons);

        if( i == 7 )
        {
            printf("Thank you, you entered the following data:\n");
        }
    }
    }

    printPlanets(planets);

    return 0;
}

---

your scanfs are missing the address of operator&
eg:

Code:

---

scanf("%d", &planets[i].moons);

---

Quote:

---

Originally Posted by sunnypalsingh

Here is the corrected code...u were missing & in scanf()...and i think u should again see ur for loop...are u sure it should be < 8

---

ohh thanks. didn't see that missing &. And yeah, it needs to be <= 8 so it includes the 9th planet. Thanks alot, I"ll try those out. And why can't it be strings.h? I've never used string.h....

Quote:

---

Originally Posted by mapunk

And why can't it be strings.h? I've never used string.h....

---

What functions are u planning to use??

strlen and strcpy...they're in both strings.h and string.h


k so now i have this code, and when I try to input the information, it only allows me to enter the planet.name once, but i can enter all the other information. Any ideas why? It'll just skip the planet.name query after i enter it the first time

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <strings.h>

#define MAXSIZE 80

typedef struct {
    char name[MAXSIZE];
    double diam;
    double dist;
    int moons;
} myVar;


void printPlanets( myVar planetInfo[] )
{
    int i;
 
    for( i = 0; i < 9; i++ )
    {
        printf("Planet %d:\n", i);
        printf("\tname: %s\n", planetInfo[i].name);
        printf("\tdiameter: %g\n", planetInfo[i].diam);
        printf("\tdistance to the Earth: %g\n", planetInfo[i].dist);
        printf("\tnumber of moons: %d\n", planetInfo[i].moons);
    }
}

int main( int argc, char *argv[] )
{
    myVar planets[8];
    int i;
    FILE *in;

    if( argc == 2 )
    {
        in = fopen(argv[2], "r");
    }
    else
    {
        in = stdin;

        for( i=0; i < 9; i++ )
        {
            printf("Please enter the name of a planet: ");
            fgets(planets[i].name, MAXSIZE, in);
            printf("Please enter the diameter of the planed (km.): ");
            scanf("%g", &planets[i].diam);
            printf("Please enter the planet's distance from the Earth: ");
            scanf("%g", &planets[i].dist);
            printf("Please enter the number of moons for the planet: ");
            scanf("%d", &planets[i].moons);

            if( i == 7 )
            {
                printf("Thank you, you entered the following data:\n");
            }
        }
    }

    printPlanets(planets);

    return 0;
}

---

scanf is causing problem for u...try clearing stream after last scanf.....u can use fflush(stdin);.....but this has a undefined behavior...should not be used for input streams.....but some compilers do support it...like VC 6.0.....
maybe gurus can throw more light on it