Simple code :: Cant figure out the problem...

Someone plz tell me what's wrong with my code...

Code:

---

#include <iostream>
#include <stdlib.h>
#include <stdio.h>
#include <ctype.h>

using namespace std;


int main (int argc, char *argv[])
{
  cout << "Hi"; 
  char input;
  cout << "Enter a character only" << endl;
  cin >> char;
  if isdigit(input)
  {
                  cout << "no no no...";
                 
  } 
 
 
  system ("PAUSE");
    return 0 ;
}

---

It gave lots of errors in Bloodshed Dev C++ 4.9.9.2.

Thanx

>cin >> char;
Perhaps you meant:

Code:

---

cin>> input;

---

>if isdigit(input)
Parentheses?

Code:

---

if ( isdigit ( input ) )

---

But a digit is also a character, so your program still has a logic error. Maybe you should ask for a non-digit, or a letter, since that is what most people want when they do not want a digit.

Oh sorry, ya i meant cin >> input;

But the following code worked just fine using Turbo C++...

Code:

---

#include<iostream.h>
#include<conio.h>
#include<ctype.h>
void main()
{
clrscr();
char c;
cout<<"Enter any character ...correction : non digit..."<<endl;
lbl:
cin>>c;
if isdigit(c)
{
cout<<"Please enter non digit only"<<endl;
goto lbl;
}
getch();
}

---

Quote:

---

Originally Posted by pritin

But the following code worked just fine using Turbo C++...

---

Funny compiler.
K.

A start would be to change these...

Code:

---

#include <stdlib.h>
#include <stdio.h>
#include <ctype.h>

---

...to these...

Code:

---

#include <cstdlib>
#include <cstdio>
#include <ctype.h> //Never heard of this one, so if it works this way, use it.

---

And I noticed the "using namespace std;" statement isn't included.

EDIT: edited out the "iostream's not there"; I'm obviously blind. :P

>> #include <ctype.h> //Never heard of this one, so if it works this way, use it.
<ctype.h> becomes <cctype>, although either version is technically valid for all three of the headers you mentioned. They should not cause compile errors.

The errors reurned for the following program are---

Code:

---

#include<iostream>
#include<conio>
#include<ctype>
void main()
{
clrscr();
char c;
cout<<"Enter any character ...correction : non digit..."<<endl;
lbl:
cin>>c;
if isdigit(c)
{
cout<<"Please enter non digit only"<<endl;
goto lbl;
}
getch();
}

---

1. conio no such file or dir
2.ctype no such file or dir
3. 'main' must return 'int'
4. In function 'int main(...)'; <-- no line number.
5. cout undeclared
6. cout undeclared
7.clrscr undefined
8. expected '(' before isdigit....

???Still need help... :confused:

Plz help!!

hello, use the full file name 'filename.h', and be sure to open and close the brakets on the conditionals; that works:

Code:

---

#include<iostream.h>
#include<conio.h>
#include<ctype.h>
void main()
{
//clrscr();
char c;
cout<<"Enter any character ...correction : non digit..."<<endl;
lbl:
cin>>c;
if (isdigit(c))
    {
    cout<<"Please enter non digit only"<<endl;
    goto lbl;
    }
getch();
return 0;
}

---

Niara

Code:

---

#include <iostream>
#include <stdlib.h>
#include <stdio.h>
#include <ctype.h>

using namespace std;


int main()
{
  cout << "Hi"; 
  char input;
  cout << "Enter a character only" << endl;
  cin >> input;
  if (isdigit(input)!=0)
  {
  cout << "no no no...";
                 
  } 
 
 
    system ("PAUSE");
    return 0 ;
}

---

This worked for me in Dev++.

Things to note: some files need to have the .h extension, however iostream and fstream are two exceptions. They work as long as you write 'using namespace std' at the top. Second, you might want to use cin.get(); to pause the program instead of system pause, since system is not considered a generic command for all OS.

<conio.h> is not a standard C or C++ library header. Therefore, you leave it like it is: <conio.h>

<ctype.h> is a standard C library header so in C++ you remove the .h and add the c in front of it: <cctype>

In standard C++, everything in the standard libraries is placed in the std namespace. So when you include the standard io stream library header <iostream>, you need to qualify cout, cin, endl, etc. with std:: or add using namespace std; to the top of your program under the #includes.

The old, non-standard headers that work on old compilers, like <iostream.h> do not require the std:: or using namespace std. However, modern compilers do not work with the outdated headers like that. You should not use your later code or Niara's code because it is old and outdated and will not compile on modern compilers. If your compiler is too old to compiler correct code, then getting a new compiler would be a better idea than writing non-standard code. The original code in the first post was just fine if you make the changes suggested by Prelude.

Hey Thanks ppl!
The code by trrenef is just fine, and just one last thing...

How to check if an alphanumeral has bween entered...

eg. when a4 is entered in the prev. prog., it does not say no no no...

What you are trying to do validate user input. If you are just beginning programming, this topic is best avoided until you become competent in what you are doing.

It best just to assume the user actually inputs an integer or a character as specified in your program. Catching, or validating user input can be quite tricky.

However, if this really bothers you look into using 'cin.ignore' to recieve only integer input. Also using 'cin.getline' to accept whitespace input. Also using 'atoi' to convert a string to an integer.

One other thing, when you enter 'a4' at the command line, your program is expecting to receive ONE character only. 'a4' would be considered two characters, thus you have to account for that in your program.

Perhaps you might want to look into 'strings' in the FAQ? :confused: