arg...function calls

im having problems with my function calls and relevant operators...ive been working on this for hours but i cant get the result of my function to be recognized by the main function. this is where im at:

Code:

---

int remainder;
int multiple (int x, int y)
{
   
        remainder = x % y;

return remainder;
}

int choice;

int main ()
{
int x;
int y;
do{ 
   
    cout << "Enter first integer (small): ";
    cin >> y;
    cout << "Enter second integer (larger): ";
    cin >> x;
    cout << "Is the first a multiple of the second?\n";
    if (remainder > 0)
        cout << "No." << multiple (x,y) << "\n";
    else
        cout << "Yes." << multiple (x,y) << "\n";
   
    cout << "Press 1 to try again, any other key to quit: ";
    cin >> choice;
} while (choice == 1);

return 0;
}

---

it just tells me yes everytime with a zero or one at the end(and i dunno how to remove that either!), so everything else works, even the do-while statement

any small hints or nudgings in the right direction will help, thank you.

> if (remainder > 0)
This isn't a function call

This is
if (remainder(x,y) > 0)

>> if (remainder > 0)

what is the value of remainder when your program runs? step through it line by line from the begging. The function has to be called to give remainder a value.

Please use code tags, makes it much easier for us to read!

Remember, the function will run at exactly the point you want it to. The way your logic is set up, it asks what remainder is BEFORE you figure out what it should be, then you have it print out yes or no followed by the value of remainder.

I think what you want is something like this:

Code:

---

do{ 
   
    cout << "Enter first integer (small): ";
    cin >> y;
    cout << "Enter second integer (larger): ";
    cin >> x;
    remainder=multiple(x,y);
    cout << "Is the first a multiple of the second?\n";
    if (remainder > 0)
        cout << "No because the remainder is " << remainder << "\n";
    else
        cout << "Yes because the remainder is " << remainder << "\n";
   
    cout << "Press 1 to try again, any other key to quit: ";
    cin >> choice;
} while (choice == 1);

---

Use PJYelton's answer - you have too many remainders in your code

ohhh, ok...tricky stuff...

so when i used 'if (remainder > 0)' it was just returning the result of the modulus, but instead i needed to call the actual function name.

alright, well thanks for the quick responses, and i'll take the time to peruse the FAQ while im here :o :D

p.s. code tags are my friends...code tags are my friends...code tags are my friends...

Quote:

---

Originally Posted by 2fastwrx

so when i used 'if (remainder > 0)' it was just returning the result of the modulus, but instead i needed to call the actual function name.

---

Actually, no, it was getting the current value of remainder (which could be anything because you didn't initialize it to anything). The modulus was never actually performed until later. Only when you call the function does the code inside the function get executed, and the modulus is actually done.

gotcha...so my custom functions arent executed until main tells them to. and without the function call written correctly (using the name and arguments...must drill that into brain) the functions are just worthless code

Be sure if you dont have arguements to use the ()'s at the end that can be a headache sometimes if you forget.