read a character from a *.txt

Hi

here is my code:

Code:

---


int main()                                                                               
{                                                                                       
  ifstream OpenFile("test.txt", ios::in);
   
    char ch;

   
    while(!OpenFile.eof())

      {

            OpenFile.get(ch);

            cout << ch;
                       
      }

      OpenFile.close();
       
      return 0;                                                                       
                                                                                               

}

---

if there is "123" in the test.txt file

but it prints out 1233, there is extra "3", I don't know why, what should I do to prevent it? Thanks

The problem is your loop. eof doesn't get set until you've read one past the end of the file. A few ways to fix your problem: One is to check the return value of get() in your loop condition, another is to make the loop an infinite loop and do an if(eof()) break; after the get(), and another is to call get() first, and reverse the order of get() and cout.

Code:

---

while(OpenFile.get(ch))
{
      cout << ch;               
}

for(;;)
{
    OpenFile.get(ch);
    if(OpenFile.eof())
          break;

    cout << ch;
}

OpenFile.get(ch);
while(!OpenFile.eof())
{
    cout << ch;
    OpenFile.get(ch);
}

---

>while(!OpenFile.eof())
This is wrong, and you've been around long enough to know it's wrong and why. :rolleyes:

I usually use
>while(OpenFile.good())
Is that acceptable?

>>while(OpenFile.good())
>Is that acceptable?
Here's a research exercise for you. Are the semantics for good() any different than eof() when used as a loop condition?

Ewww... exercise... that's evil. :p

>>This is wrong, and you've been around long enough to know it's wrong and why.
Doesn't it work in the example I gave?

>Doesn't it work in the example I gave?
Yes, it does. I didn't notice that you played an order trick in the body.

how about

while(OpenFile)

or

while(OpenFile.get(ch))

>>I didn't notice that you played an order trick in the body.
I wouldn't have thought of it, if I didn't see a friend do it the day before (although in different circumstances). It was kind of a neat trick he used to help parse data :)

>>while(OpenFile.get(ch))
If you'd read my post, you might have seen that it was the first example I gave ;)