The classic 'invisible' parse error.

I'm getting a parse error on both of the following lines, and I can't figure out why. CAR is typdeffed to be a structure, numCars is an integer, and costPtr/wtPtr are both pointers. For the life of me I can't see it, which is why I hope some fresh minds might be able to help! The typedef for struct CAR is below.

Code:

---

FillArray ( CAR train, numCars, float &costPtr, int &wtPtr );
FindTotals ( CAR train, numCars, float &costPtr, int &wtPtr );

typedef struct car
    {
      int  carNum;
      char  cargo[LENGTH];
      char  origin[LENGTH];
      char  destination[LENGTH];
      int  weight;
      int  miles;
      float cost;
    }CAR;

---

>>FillArray ( CAR train, numCars, float &costPtr, int &wtPtr );
Maybe
>>FillArray ( CAR train, int numCars, float *costPtr, int *wtPtr );

Make sure the typedef for CAR comes before these prototypes.

I typdeffed it in the header file, which is # included. I'll try moving it.

Here's the full code.

Code:

---

/*******************************************************************
 * File:              proj3.c
 * Created by:        Chris
 * Created on:        04/07/2004
 * Class:            CMSC201
 * Section:          0204
 * Email:            [email protected]
 *
 *  Description:      Main file of Project 3, a train report program.
 *******************************************************************/

#include <stdio.h>
#include <stdlib.h>
#include "trains.h"
#include <strings.h>

/* Maximum string length for structure */
#define LENGTH 12

int main()
{
  int numCars;

  typedef struct car
  {
            int  carNum;
            char  cargo[LENGTH];
            char  origin[LENGTH];
            char  destination[LENGTH];
            int  weight;
            int  miles;
            float cost;
  }CAR;

  CAR *train;

  PrintGreeting ();

  numCars = ReadNumCars ();

  train = (CAR *) malloc(numCars * sizeof(CAR));
 
  FillArray ( train,  numCars, &costPtr, &wtPtr );
  FindTotals ( train, numCars, &costPtr, &wtPtr );

 
  return 0;
}

/*******************************************************************
 * File:              train.c
 * Created by:        Chris
 * Created on:        04/06/2004
 * Class:            CMSC201
 * Section:          0204
 * Email:            [email protected]
 *
 *  Description:      Library file of Project Three containing all
 *                    of the functions used within the program.
 *
 *******************************************************************/

#include <stdio.h>
#include <stdlib.h>
#include "trains.h"
#include <string.h>

#define LENGTH 12

/* Display greeting message */
/* name: PrintGreeting      */
/* inputs: none            */
/* returned value: none    */
void PrintGreeting ()
{
  printf( "\nThank you for using Train Report!  This program will");
  printf( "\nread information from the data file, and print out a");
  printf( "\ntrain report on each of those cars, and statistics");
  printf( "\nabout the whole train, followed by a graphical");
  printf( "\nrepresentation of the train.  Enjoy!\n\n");
}


/* Reads number of cars in train */
/* name: ReadNumCars            */
/* inputs: none                  */
/* returned value: none          */
int ReadNumCars ()
{
  int cars = 0;

  scanf( "%d", &cars);

  return cars;
}

/* Fills the array with items from the data file  */
/* name: FillArray                                */
/* inputs: number of cars                          */
/* returned value: none                            */
void FillArray (CAR* train, int numCars, float* costPtr, int* wtPtr)
{
  int i;

  char str1[LENGTH] = "coal";
  char str2[LENGTH] = "cattle";
  char str3[LENGTH] = "hogs";
  char str4[LENGTH] = "eggs";
  char str5[LENGTH] = "autos";

  for ( i = 0; i < numCars; i++ )
  {
      scanf("%d", &train[i].carNum);
      scanf("%s", train[i].cargo);
      scanf("%s", train[i].origin);
      scanf("%s", train[i].destination);
      scanf("%d", &train[i].weight);
      scanf("%d", &train[i].miles);

if( strcmp(train[i].cargo, str1) == 0 )
      {
        train[i].cost = 29.1;
      }
      if( strcmp(train[i].cargo, str2) == 0 )
      {
        train[i].cost = 52.5;
      }
      if( strcmp(train[i].cargo, str3) == 0 )
      {
        train[i].cost = 63.1;
      }
      if( strcmp(train[i].cargo, str4) == 0 )
      {
        train[i].cost = 75.9;
      }
      if( strcmp(train[i].cargo, str5) == 0 )
      {
        train[i].cost = 16.5;
      }

  }

}

/* Finds the total weight and total cost of the train                    */
/* name: FindTotals                                                      */
/* inputs: array of structures, number of cars, cost and weight pointers  */
/* returned values: none                                                  */
void FindTotals (CAR* train, int numCars, float* costPtr, int* wtPtr)
{
  int i;
  int increment;
  int weight = 0;
  float cost = 0;

  costPtr = &cost;
  wtPtr = &weight;

  for ( i = 0; i < numCars; i++ )
  {
      increment = train[i].cost * train[i].miles * train[i].weight;
      cost = cost + increment;
  }
  i = 0;

  for ( i = 0; i < numCars; i++ )
  {
      weight = weight + train[i].weight;
  }
}


/* Prints the train report                                              */
/* name: PrintReport                                                    */
/* inputs: array of structures, number of cars, weight and cost pointer  */
/* returned values: none                                                */
void PrintReport (CAR* train, int numCars, float* costPtr, int* wtPtr)
{
  int i;

  printf( "\n\nThere are %d cars in this train.\n", numCars);
  printf( "The data for each car is as follows:\n\n" );
  for ( i = 0; i < numCars; i++ )
  {
      printf( "\n\nCar number  : %d", train[i].carNum );
      printf( "\nCargo      : %s", train[i].cargo );
      printf( "\nOrigin      : %s", train[i].origin );
      printf( "\nDestination : %s", train[i].destination );
      printf( "\nWeight      : %d pounds", train[i].weight );
      printf( "\nDistance    : %d miles", train[i].miles );
      printf( "\nCost        : $  %f", train[i].cost );
  }

  printf( "\n\n-------------------------------" );
  printf( "\n-------------------------------\n");
  printf( "\nNumber of Cars :            %d", numCars);
  printf( "\nTotal Weight  :            %d tons", *wtPtr);
  printf( "\nTotal Cost    :  $        %f", *costPtr);


}

---

The only place you have CAR declared is within your main function. You need to have it in an #include or something to that effect.

trains.h?

Yeah, I declared it in trains.h, and got rid of the declaration in main. That, and I declared the pointers in main and removed the & from the function calls, and it compiled = ]. Now there's logic errors to mess with.

logic errors are always fun. Hope you get them and don't be afraid to ask for more help here.

I didn't have a properly formatted input data file. Now it seems to be working perfectly! Just have to write the last function and I shall be done.

Edit: Thantos, you HOPE I get logic errors? Ouch, that's harsh! :p

Quote:

---

Hope you get them

---

Heh a little misleading. I meant "get them" as in find them and fix them.

But hey getting logic errors builds character.

>But hey getting logic errors builds character.
Suddenly my mind just snapped back into 'Calvin & Hobbes' mode. :p

"Why is it whenever I build character, he saves $100?"

next time use vi

Vi? Finally finished with the project. Pulled something of an all-nighter to get it done, and much thanks for the help from Ken and Thantos.

vi highlights incomplete parens and such....heh
the unix editor "vi" or linux vim whatever....