My if statements are screwing up

There is something wrong with my program. Every time I run it it tells me that I have made an improper choice. I think it is a problem with my if statements, but could it be that there is something wrong somewhere else???? (I left out my "other_choice" function, so it would be easier to find the problem)

I am using Dev C++ 4.9.8.0 on WinXP

Code:

---

#include <iostream>
#include <cstdlib>
#include <stdio.h>


using namespace std;

int main_choice(int choice)
{
    cout<< "Please make a choice\n";
    cout<< "1) box\n";
    cout<< "2) cylinder\n";
    cout<< "3) sphere\n";
    cin>> choice;
    return choice;
    }




int main()
{
  int x;
  main_choice(x);
  if(x==1)
  {
    cout<< "You chose to make a box!!!\n";
    int y;
    other_choice(y);
    }
  else if(x==2)
  {
    cout<< "You chose to make a cylinder!!!\n";
    int y;
    other_choice(y);
    }
  else if(x==3)
  {
    cout<< "You chose to make a sphere!!!\n";
    int y;
    other_choice(y);
    }
  else
  {
    cout<< "You did not make a proper choice\n";
    system("Pause");
    return 0;
    }     
  system("PAUSE");       
  return 0;
}

---

Thanx in advance

you are passing x by value, not by reference. In essence the value of x is being passed to main_choice, not x itself. the value is changed in main_choice but it is never sent back to main(). Change this:

int main_choice(int choice)

to this:

int main_choice(int & choice)

and everything should work. Of course then there would be no need to return an int from main_choice (unless you want to send back a success flag of some sort). Alternatively, don't sent x at all. Just make main_choice have no parameters. Then in main do this:

x = main_choice();

That should work, too.

[edit]

n/m

[/edit]

Don't do this:

Quote:

---

Originally posted by elad
you are passing x by value, not by reference. In essence the value of x is being passed to main_choice, not x itself. the value is changed in main_choice but it is never sent back to main(). Change this:

int main_choice(int choice)

to this:

int main_choice(int & choice)

and everything should work. Of course then there would be no need to return an int from main_choice (unless you want to send back a success flag of some sort).

---

Do this:

Quote:

---

Originally posted by elad
Alternatively, don't sent x at all. Just make main_choice have no parameters. Then in main do this:

x = main_choice();

That should work, too.

---

Your passing in x....to the function main_choice... And you haven't declared x's value yet? Check that.

Your initializing a variable of int type x, and attempting to pass x to a function that takes a value of int, when you haven't defined x's value yet? Check that.