cin.getline problem...

Hello everybody,

here is one of the function definition in my c++ program...
Unfortunately, it doesn't work...(It compile but it won't let me to enter the name.)

void ListMemberName(Member arr[], int length1)
//Purpose: List member by name
//Pass by Value: length1
//Pass by Reference: arr[]
{
char target[30];
int ctr=0;
int found = 0;

cout<<"Enter name of the member"<<endl;
cin.getline(target,30,'\n');

while ((ctr<length1)&&(found==0))
{
if (strcmp(target, arr[ctr].name)==0)
{
found=1;
cout<<arr[ctr].num<<' '<<arr[ctr].gend<<' '<<arr[ctr].name<<endl;
}
else
ctr++;
}
if (found==0)
cout<<"Invalid input"<<endl;
}

I'm pretty sure it is the line "cin.getline(target,30,'\n');" that cause the problem.
Since it required to enter a full name(have space), therefore i use cin.getline instead of cin>>.

Thanks

i think you have to derefrence the name of the array like this

if (strcmp(*target, arr[ctr].name)==0)

hope it helps :)

>>if (strcmp(*target, arr[ctr].name)==0)
That won't work, strcmp() wants to pointers as it's parameters.

davidvoyage200: I suggest you do some debugging. If you don't have a "proper" debugger to hand, try just writing out to the screen the strings that are being compared, just to see if that process is working as you think.

Also, please read this :)

thanks for replying,

yes, i am using visual c++ to compile and debug it, there are no syntax error, but the fucntion just not allow me to type the name. (before i enter the name, the program quickly display "Invalid Input".), therefore i don't even have time to type the name...

sorry people,

i typed my code with tags, but unfortunately, when i copy paste my code, and then post it, it automatically became "non-tags".

Quote:

---

Originally posted by davidvoyage200
thanks for replying,

yes, i am using visual c++ to compile and debug it, there are no syntax error, but the fucntion just not allow me to type the name. (before i enter the name, the program quickly display "Invalid Input".), therefore i don't even have time to type the name...

---

... then there is probably some data left in the input buffer, maybe just a newline character from a previous input call.

ok, here is my complete program with the input file.

the program have trouble when "list member by name"

and this is my input file

the password of the program is "geek"

>>the program have trouble when "list member by name"
On my system, the program has trouble even compiling.

Code:

---

Borland C++ 5.5 for Win32 Copyright (c) 1993, 2000 Borland
E:\junk1.cpp:
Error E2015 junk1.cpp 14: Ambiguity between 'string' and 'std::string'
Error E2015 junk1.cpp 34: Ambiguity between 'string' and 'std::string' in function main()
Error E2451 junk1.cpp 328: Undefined symbol 'i' in function RemoveMember(Member *,int &)
Error E2285 junk1.cpp 328: Could not find a match for 'strcpy(undefined,char *)' in function RemoveMember(Member *,int &)
*** 4 errors in Compile ***

---

I'll have a look and post again soon.

cin >> number;
When you do this it can leave a newline character in the buffer. I expect this is what is causing your problem.

In this loop:
while ((ctr < length1) && (found == 0))
put this line:
cout <<"Comparing >" <<target <<"< with >" <<arr[ctr].name <<"<" <<endl;

This will display exactly what is being compared for each iteration of the loop. You should be able to determine the problem from here. Have fun debugging :)