Sams Teach Yourself ?

This is question #8 from chapter 5 in Sams teach yourself c programming in 21 days:

8. Write a function that receives two numbers as arguments. The function
should divide the first number by the second. Don't divide by the second
number if it's zero. (Hint: Use an if statement.)

Code:

---

#include <stdio.h>

float a,b,c=0;

float divide(float c,float d);



int main(void)
{
        printf("Please enter two numerical values(deciamals are accepted): ");
        scanf("%f,%f",&a,&b);

        float divide(float c,float d);

        c=float divide(float c, float d);

        printf("Answer: %d", c);

        return 0;
}

float divide(float c, float d)
{
        float e=0;

        if(d>0)
                e=c/d;
        else
                void;

                return e;
}

---

Anyways when I execute it, I enter one number and it goes straight to "Hit any key to..." how do I stop this, it has never happened before and I know this should be an easy question but still I would appreciate a little help thanks in advance:)

P.S. The only error it has is: (16) : error C2062: type 'float' unexpected, how exactly do I go about fixing that, because it is already declared as a float...

>Anyways when I execute it
You mean it actually compiles for you? What compiler do you use?

Code:

---

#include <stdio.h>

/*
** Globals should be avoided when possible.
*/
float a,b,c=0;

float divide(float c,float d);

int main(void)
{
  printf("Please enter two numerical values(deciamals are accepted): ");
  /*
  ** Be aware that scanf will expect the user to enter <num>,<num>.
  */
  scanf("%f,%f",&a,&b);
  /*
  ** You already did this, there's no need for another prototype.
  */
  float divide(float c,float d);
  /*
  ** This is an invalid function call.
  */
  c=float divide(float c, float d);
  /*
  ** We are working with floats, right? Why print an integer value then?
  */
  printf("Answer: %d", c);
 
  return 0;
}

float divide(float c, float d)
{
  /*
  ** Not needed.
  */
  float e=0;
 
  if(d>0)
    e=c/d;
  else
    /*
    ** This is illegal.
    */
    void;
 
  return e;
}

---

Here is another way to do it, with the errors (mostly)removed. But that is for a later lesson. :)

Code:

---

#include <stdio.h>

static float divide(float c,float d);

int main(void)
{
  float a, b, c;
  printf("Enter two numbers(decimals are accepted): ");
  if ( scanf("%f %f",&a,&b) == 2 ) {
    c=divide(a, b);
    printf("Answer: %.2f", c);
  }
  return 0;
}

static float divide(float c, float d)
{
  if(d > 0.0)
    return c / d;
  return 0.0f;
}

---

-Prelude

Well I will try to fix it, then if it is still weird(most likely ;)) I will probably try your "later lesson" way, thanks Prelude :)

P.S.

Quote:

---

>Anyways when I execute it
You mean it actually compiles for you? What compiler do you use?

---

Sorry about that, I have yet another program that...er somewhat works :o, but that is for a "later time" right ;)

>I will probably try your "later lesson" way
By later lesson I meant the remaining problem areas. I'm still curious as to what compiler ran your code, even MSVC++ 6 gave several errors on it and we all know how lenient that compiler is. :p

-Prelude

That would be what I am using, and it did give me errors, I just got the 3 different programs mixed up :o, sorry again, like I said I will just try what you posted and go from there, I don't like these "factorials" and "recursive functions" very much, but then again I am only learning and haven't made anything good so I suppose when/if I do I will find out then.