code revision help

After running my code it spits out long numbers.Im new to C so im not sure what I
am doing wrong.

Code:

---


#include <stdio.h>
int main(void)

{
        int x,remainder;
        float y,sum,product,quotient, expression;
       
       
        printf("Enter an integer> ");  //calling for an integer value
        scanf("%d", &x);
        printf("Enter a real number> ");  //calling for a real number
        scanf("%f",&y);
       
        x=x;
        y=y;
        sum=x+y;
        product=x*y;
        quotient=x/y;
        remainder=x/7
        expression=(2*x)+(8y/7);
       

        printf("_____________________________\n");
       
        printf("x value: %d\n", x);            //prints x value
                                   
        printf("y value: %f\n", y);            //prints y value
                         
        printf("%f=%d+%f\n", sum);        //prints sum
                       
        printf("%d*%f=%f\n", product);    //prints product
       
        printf("%d/%f=%f\n", quotient);  //prints quotient

        printf("%d/7\n",remainder);            //prints remainder

        printf("(2*%d)+(8*%f/7)\n",expression);  //prints expression
       
        printf("_____________________________\n");
       
        return(0);
        }

---

Code:

---

printf("%f=%d+%f\n", sum);

---

Don't lie to printf. If your format string says you have three numbers, then you had better have three numbers ready to go behind it.

Quote:

---

Originally Posted by mshel130

Code:

---

{
        int x,remainder;
...
        printf("x value: %d\n", x);            //prints x value
        }

---

---

I am by no means an experienced c programmer, maybe a few lines ahead of you...but I have experienced that you get strange results when you tell printf to print a double which you do by '%d' while you are actually printing an integer (x is an integer). It should be '%i'.

%d isn't double, it's an int.

You are right. It is too early for me to know even the simplests of things.

Thank you tabstop. I fixed the error by("Don't lie to printf") backing up printf with 3 numbers and achieved the desired results.

Quote:

---

Originally Posted by mshel130

After running my code it spits out long numbers.Im new to C so im not sure what I
am doing wrong.

Code:

---

        x=x;
        y=y;

---

---

This line is redundant to your scanf's and is not needed.

Quote:

---

Originally Posted by mshel130

Code:

---

            remainder=x/7

---

---

This doesn't give you the remainder, it performs integer division. If x < 7 you will get zero. Use MOD (%) for remainder.

Quote:

---

Originally Posted by mshel130

Code:

---

            expression=(2*x)+(8y/7);

---

---

C is not a math parser, you should have gotten an error with this line. 8y means nothing.