Problem with linked lists

I'm having some problems with this simple code:

Code:

---

#include <stdio.h>
#include <stdlib.h>

typedef struct make_point {
        int x;
        int y;
        char name[4];
        }point;
struct nodea {
        point naero;
        struct nodea *prox;
};
typedef struct nodea *listap;

void insere_point(listap x, point novo_point)
{
        listap t = (listap) malloc(sizeof(listap));
        t->naero = novo_point;
        t->prox = x->prox;
        x->prox = t;
}

main()
{
listap total_point;
point novo;
scanf ("%d%d%s",&novo.x,&novo.y,novo.name);
insere_point (total_point,novo);
printf ("%d%d%s\n",total_point->naero.x,total_point->naero.y,total_point->naero.name);
}

---

As you can see I just want to do a simple scan and print to and from a list, and when i put this on the standard input "3 15 FRA" i get a random number instead of 3 15 FRA. I've been trying from quite some time to find my mistake but i still can't do this, anyone got a hint to what i'm doing wrong?

Try this, to understand your mistake

Code:

---

listap total_point = NULL;
point novo;
scanf ("%d%d%s",&novo.x,&novo.y,novo.name);
printf("List points to %p\n", (void*)total_point );
insere_point (total_point,novo);
printf("List NOW points to %p\n", (void*)total_point );
printf ("%d%d%s\n",total_point->naero.x,total_point->naero.y,total_point->naero.name);

---

> typedef struct nodea *listap;
Using a typedef just to hide a pointer is pretty poor generally.
Being able to see instantly how many levels of indirection are present is generally more useful (as it would have been in this case).


Also, see the FAQ on casting malloc, and why you got the wrong size in your sizeof().

thank you for you reply,
I tried out the code you wrote and I got the following result:
"
List points to 0xbff33f78
List NOW points to 0xbff33f78
-107457741610972391

"
i had to "listap total_point = NULL;" to listap total_point; because it was giving me a segmentation fault with the first one. Now i can see that the pointer points to the same place after he inserted the new Point, but it's not supposed to? since total_point (the point) should always point to the first node isn't it?
I also read the faq as you mentioned, on how to cast malloc, i tried to change my malloc(sizeof(listap)); to malloc(sizeof(t)); but i got the same result.

Your insere function appears to want to insert the node in the second place always, which is ... a little unusual, but fine. But what are you going to do when there's not anything in the list? You'll need to do something different in that case.

If you do need to create a new node, you need to create a new node. listap is not a node, and neither is t.

> since total_point (the point) should always point to the first node isn't it?
Yes, it should be pointing at your first node.
If you can make it do that, you should be OK.

> i tried to change my malloc(sizeof(listap)); to malloc(sizeof(t));
Well it should be sizeof(*t)