Question on passing array arguments to function, and not printing

I'v been working on a binary tree problem. I know there are those that only take one variable, prob an int or a char. However, my instructions were to pass a struct with addresses, phone numbers etc. My program compiles but perhaps my logic is crap. I believe it lies in the way i pass the array arguments to the insert function.


My function takes it like this:

Code:

---



BST insertnode(BST t, int x,int a,char *array)
{

        if(t==NULL) {
          t=(node*)malloc(sizeof(node));
      if(t==NULL) printf("\n Out of Space !!");

      else {

          t->info = x;
          t->phone=a;
          t->fname[90]=*array;

          t->left = t->right = NULL;

        }
    }



    else
      if (x<t->info) {
        t->left=insertnode(t->left,x,a,array);
    }

    else
        if (x>t->info) {
          t->right=insertnode(t->right,x,a,array);
    }

    return t;

}

---

Everything seems to work fine, but when i try to print my information, i get the info and phone to the screen, but the fname doest print anything, which i assume is a problem the way im passing it to the function. ANyway any comments, or help would be appreciated.

Code:

---

BST insertnode(BST t, int x,int a,char *array)
{

        if(t==NULL) {
          t=malloc(sizeof(node));
      if(t==NULL) printf("\n Out of Space !!");

      else {

          t->info = x;
          t->phone=a;
          strncpy(t->fname, array, sizeof(t->fname))

          t->left = t->right = NULL;
        }
    }
    else
      if (x<t->info) {
        t->left=insertnode(t->left,x,a,array);
    }

    else
        if (x>t->info) {
          t->right=insertnode(t->right,x,a,array);
    }

    return t;

}

---

What do you want this line

Code:

---

t->fname[90]=*array;

---

to do? I would think that it would set the ninetieth character of fname to whatever the value of the char pointer passed in was, cast to a character. If you want to copy a string, you should use strcpy.

Quote:

---

Originally Posted by master5001

[code]

---

Dammit how could i have overlooked that assignment that i did, u sure are the master Matt, lol, that worked perfectly!! U are the man, lol!! Thanks bro!!

Quote:

---

Originally Posted by tabstop

What do you want this line

Code:

---

t->fname[90]=*array;

---

to do? I would think that it would set the ninetieth character of fname to whatever the value of the char pointer passed in was, cast to a character. If you want to copy a string, you should use strcpy.

---

Yea thanks Tabstop, case closed, i overlooked that assignment, wasnt thinking there, Matt solved the prob! Yea and u are right too, strcpy to copy too, that ota work too

Cheers thanks!

> t->fname[90]=*array;
Is fname an array?
If not, you need to allocate space.

Then you need to use strcpy()

Quote:

---

Originally Posted by Salem

> t->fname[90]=*array;
Is fname an array?
If not, you need to allocate space.

Then you need to use strcpy()

---

Yup fname is an array in the type struct Salem, yea strcpy works that was my prob. Thanks man!

Quote:

---

Originally Posted by Matus

Dammit how could i have overlooked that assignment that i did, u sure are the master Matt, lol, that worked perfectly!! U are the man, lol!! Thanks bro!!

---

Yeah no problem dude. Its a simple mistake that can happen to the best of us. That is why they put erasers on pencils and delete keys on keyboards (in fact, that is why there are 3 keys capable of deletion on a keyboard ;))