Re-Assigning Values To Array

Hi, i'm really new to (C) programming.
I'm practicing by writing a code that will take a string, and then send the individual words of that string, to a function to be printed. The problem is that because i override the characters in the respective elements of the array, if one of the words is shorter than the one before it, it carries across the excess letter.

E.g "what you want" gives me :
what you want
what
yout
want

I'm thinking i need to re assign the value 0 to my whole array (since apparently i cant re-initialize in C), problem is the loop I'm using doesn't work. When i compile it in Visual C++, i get the following message.

"Run-Time Check Failure #2 - Stack around the variable 'textblock' was corrupted."

You'll see the loop commented out in the second If statement in my While.

Warning. What your about to see is a very ugly, and extremely inefficient chunk of code. Please be gentle.

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>

int main(int argc, char *argv[]){

char mytext[21] = {"what you want"};
char textblock[21] = {0};
int wordplace(char textblock[]);

printf("%s\n", mytext);

int i = 0;
int j = 0;
int f = 0;

while((i<22) && (j<22) && (mytext[i] != '\0')){
       
        if(( mytext[i]>='a' && mytext[i]<='z' ) || ( mytext[i]>='A' && mytext[i]<='Z' )){
      textblock[j] = mytext[i];
        }

        i++;
        j++;

        if (mytext[i] == ' ' || mytext == 0 || mytext[i] == '\0'){
                mytext[i] = '\0';
                wordplace(textblock);
                i++;
                j = 0;
                //while (j<22){
              //textblock[j] = 0;
                  //j++;
                }
               
        }

}

return 0;

}

int wordplace(char textblock[]){

        printf("%s\n", textblock);

        return 0;

}

---

Please help. Thank You.

Code:

---

                mytext[i] = '\0';
                wordplace(textblock);

---

Perhaps you should be updating textBlock[j] rathter than mytext[i] here?

--
Mats

By the way:

Code:

---

(i<22) && (j<22)

---

will allow i or j to reach 21, which is beyond the end of a [21] array. It should be 21 not 22.

--
Mats

You need to reset j to 0 after that commented-out while loop...

Quote:

---

Originally Posted by rasta_freak

You need to reset j to 0 after that commented-out while loop...

---

Although the entire commmented out loop would be superfluous when using the code suggested in my first reply. The second reply explains why the stack block is being correupted, as it writes to location 21 of a [21] array, which is out of bounds, as a 21 item long arrat allows 0..20 as valid indices.

--
Mats

Quote:

---

Originally Posted by matsp

Although the entire commmented out loop would be superfluous when using the code suggested in my first reply. The second reply explains why the stack block is being correupted, as it writes to location 21 of a [21] array, which is out of bounds, as a 21 item long arrat allows 0..20 as valid indices.

--
Mats

---

You may have given him "proper" way of doing it, but i just pointed out (to him) "error" in his way...(not saying it's "proper" or good)

EDIT: actually, I'm totaly wrong (;)), because I thought he passed over whole stack (and not "only" 1 byte), but it's obvious he has runtime protection which detected that 1 byte overflow (i thought it was segfault...)

EDIT2: but anyway, if he will use that loop, he should reset j to 0 (and use "j<21" of course)