Porblems getting a program to find a file

Hi all

I am in the initial stages of writing a program to perform mathematical tasks from digits placed in a file, namley notepad. The program keeps returning "No such directory" when I enter a pre prepared file name and after several hours of going round in circles I am getting nowhere. The notepad file and the program are in the same folder (If this helps) and entering either just the file name or even the whole location string just returns the above error. Probably missing something really silly as I am quite new to this, does anyone know why I cant locate the file.

Thanks

Code:

---


#include<stdio.h>
#include<stdlib.h>
main(void)
{
char ch, filename[25];
FILE *fp;
printf("Enter the name of file you wish to see");
gets(filename);

fp = fopen(filename,"r");
if(fp==NULL)
{
 perror("Error.\n");
 exit(EXIT_FAILURE);
 }
 printf("The contents of %s file are :-\n\n", filename);
 
 while((ch=fgetc(fp) )!=EOF)
 printf("%c",ch);
 fclose(fp);
return 0;

}

---

Try giving filename more space and entering the entire path again.

I'm contractually obligated to also mention:

• you should use fgets instead of gets (but beware that it leaves the newline in the string)
• you should explicitly define main as returning an int

Hello

Sorry should have seen the int before main, begining to wonder if i'll ever get the hang of this. I have tried giving the filename up to 100 characters but still returns the same error also not sure how to get fgets to work as when i enter it, it wont compile probably missing something there too lol.

Using fgets is more trouble but it allows you to protect your program from buffer overflow.

Code:

---

const int MAXSIZE = 100;
char filename[MAXSIZE];
int len;
fgets(filename, MAXSIZE, stdin);
len = strlen(filename);
if (filename[len-1] == '\n')
    filename[--len] = 0;

---

Can you post exactly what you're typing in for the full path?

The file is located in the following position, is not protected and is created by wordpad

E:\Numbers

Will give fgets another go

Is Numbers a directory? If not, shouldn't it be Numbers.txt? Try opening wordpad or notepad and typing in the exact full path that you're typing into your program. Remember to include the drive letter.

It was the txt that was missing on the end of the path, also got fgets to work will have to go over it later to try and make sense of it. Thankyou for you help.

Mystery solved! :)

Code:

---

char ch, filename[25];
...
while((ch=fgetc(fp) )!=EOF)

---

The fgetc function returns an int, not a char. This is important when comparing against EOF.