Help me with this weird error please

Code:

---

#include "Security.h"


#include <iostream>
#include <SFML/Graphics.hpp>
#include <SFML/Window.hpp>




Security::Security()
{
    //ctor
}


Security::~Security()
{
    //dtor
}


void Security::ErrorMsg()
{
    sf::RenderWindow ErrorBox(sf::VideoMode(200,100,32),"Error");


    sf::Text ErrorText;
    sf::Font ErrorFont;


    if(ErrorFont.loadFromFile("monospa1.ttf"))
        ErrorText.setFont(ErrorFont);
    ErrorText.setString("Access denied");
    ErrorText.setScale(sf::Vector2f(0.6,0.6));
    ErrorText.setPosition(200/6,130/3);


    while(ErrorBox.isOpen())
    {
        sf::Event Error;


        {
            while(ErrorBox.pollEvent(Error))
            {
                if(Error.type == sf::Event::Closed || sf::Keyboard::isKeyPressed(sf::Keyboard::Escape))
                    ErrorBox.close();
            }
        }


        ErrorBox.draw(ErrorText);
        ErrorBox.display();
    }
}


bool Security::passwords(int passType)
{
    std::string pass;


    if(passType == 1)
    {
        std::cout << "Type in your password (MPP ONLY): " << std::endl;
        std::getline(std::cin, pass);
        if( pass == "HelloWorld")
            return true;
        else
            ErrorMsg();


    }
    else if (passType == 2)
    {
        std::cout << "[Click this window and type in your password]";
        std::cout << "\n\n\n                Type in your password (Teachers and Students): " << std::endl << std::endl;
        std::cout << "        password: ";
        std::cout << "  " ;
        std::getline(std::cin,pass);


        if (checkPassword(pass))
            return true;
        else
            ErrorMsg();
    }


    return false;
}


bool Security::checkPassword(std::string password)
{


    passwordArray[0] = "12345";


    for(int i =0;i<1500;i++)
    {
        if(password == passwordArray[i])
            return true;
    }
}



line 45 : error: expected unqualified-id before 'namespace'
line 89 : error: expected '}' at end of input|
line 89 : error: expected unqualified-id at end of input|

---

The problem probably lies in Security.h.

Thanks. One more question; I'm having problem with making something like a "serial key". Something like just simply storing strings somewhere in the code and then use if statement to check valid password, and say that I'm the one who gives out the password. How can I do this without hard-coding? Do you know any method of doing so?

You're generally better off putting the includes for standard things such as iostream before your own header files. That way you've unlikely to screw up anything in the compilation of standard libs.

Passwords usually come down to running with whatever is input. I mean, the password is never compared at all. If it is the right password, it should decrypt whatever you are trying to keep secret.

Quote:

---

Originally Posted by iMalc

You're generally better off putting the includes for standard things such as iostream before your own header files. That way you've unlikely to screw up anything in the compilation of standard libs.

---

Including your own header files before the standard ones has the advantage that you are more likely to make the inclusion dependency correct. If you include standard headers first, you may often forget to include them properly in the other header files. If file Foo.cpp includes its corresponding header Foo.hpp first, it automatically ensures that every standard header is properly included (or else it will not compile). Then you can be sure that someone who includes your Foo.hpp, without including anything else, will not run into something-not-included problem. Precompiled headers make it a bit harder, but you can always turn them off temporarily to check your include directives.

Quote:

---

Originally Posted by kmdv

Including your own header files before the standard ones has the advantage that you are more likely to make the inclusion dependency correct. If you include standard headers first, you may often forget to include them properly in the other header files. If file Foo.cpp includes its corresponding header Foo.hpp first, it automatically ensures that every standard header is properly included (or else it will not compile). Then you can be sure that someone who includes your Foo.hpp, without including anything else, will not run into something-not-included problem. Precompiled headers make it a bit harder, but you can always turn them off temporarily to check your include directives.

---

Actually that too is entirely correct. There is no perfect solution.
Although, something to randomise the order of header inclusions every time you build would be quite interesting.

Quote:

---

Originally Posted by Meerul264

Thanks. One more question; I'm having problem with making something like a "serial key". Something like just simply storing strings somewhere in the code and then use if statement to check valid password, and say that I'm the one who gives out the password. How can I do this without hard-coding? Do you know any method of doing so?

---

Typically one have a system where one can create passwords, storing them in some sort of database.
This goes without saying, but all your passwords should be encrypted with non-symmetric keys (one way passwords).
Then encrypt the inputted password if you must compare it.