error C2143: syntax error : missing ')' before ';'

Hello,

I am return a string from a function. Function prototype:

Code:

---

char* ToUpper(char *str, const int length);

---

In my main i have the following:

Code:

---

char string2[] = "Hello how are you today?";
strcpy(string2, ToUpper(string2, strlen(string2));

---

I keep on getting the following error message.

error C2143: syntax error : missing ')' before ';'

Any advice would be most gratefull,

Thanks,

Quote:

---

Originally Posted by steve1_rm

Code:

---

strcpy(string2, ToUpper(string2, strlen(string2));

---

error C2143: syntax error : missing ')' before ';'

---

Count your parentheses. You have 3 opening but only 2 closing on that line.

Thanks,

I was looking everywhere.

A stupid mistake. I will have to look more closely next time.

Try putting spaces at certain places to make it easier to spot where there needs to be ending ).

> strcpy(string2, ToUpper(string2, strlen(string2));
If ToUpper() returns string2, then not only is the strcpy a waste of time, it's also undefined.

Very few C library functions which move data around are guaranteed to do the "right thing" when the source and destination overlap. memmove() is an exception.