strange debugger results on atomic 16 bit variable

I have unsigned int variable that throughout code is either assigned a 0 or a 1 ....that's it....I am noticing the debugger when stopped sometimes (due to code going awry ---- verified with logic analyzer) that the variable is showing large int values like 15191, etc....I am now wondering if I am running into buffer overflow issues. I am using memcpy multiple times throughout the code and I found that ppl are saying buffer overflow can be a very real issue with memcpy. Can someone tell me if the following should be ok to use without buffer overflow issues?

Code:

---

memcpy(radioID, (const void *)&RXData[9], sizeof(radioID));

---

Here radioID is 4 deep
RXData is 32 deep BUT I am specifically using the sizeof on the smaller array

Thanks

When you say "RXData is 32 deep", you mean that it has a size of 32 bytes? How many bytes is the size of RXData[0]?

But yeah, what you have shown should not result in overwriting memory unexpectedly; but that doesn't mean you are reading from memory correctly (although that's unlikely to result in the behaviour you observed for the unsigned int).

Note that you don't need the cast to const void* since the implicit type conversion from pointer to object type to const void* is always safe.

Your memcpy is wrong to start with (is this really your code, or just something you paraphrased from memory?)

> memcpy(radioID, (const void *)&RXData[9], sizeof(radioID));
You're missing an & on the first parameter.

Code:

---

char radioID[4];

---

The code I have above seems to work.....why do I need to place &radio.....I'm guessing bcz memcpy is a block type copy vs copy one after the other until sizeof is reached?

Well you said atomic, and arrays can never be atomic.

Sure, it makes your memcpy valid, but it isn't solving your problem.

> I have unsigned int variable that throughout code is either assigned a 0 or a 1
So this variable is actually nowhere in your post then?

Your 'guess' at one line of code which isn't even to do with the thing you're observing just isn't going to get it done.

Post a whole program, or at least some cut-down version which demonstrates the problem.