program wont work, why?

Code:

---


#include <stdio.h>
#include <conio.h>
#include <string.h>

int main()
{
    char name[10];

    printf("Please enter your name.\n");
    getch();
    scanf("%s", name);
    printf("Hello %s!", name);
    getch();
}

---

after i put in a name, and press enter, it doesnt pause to let me see the Hello %s!", name the window just closes. ive tried using the void main thing but it wont work on my compiler for some reason. can anyone tell me why this isnt working?

Please spend some time in the FAQ.

they pause the program until i press enter. i try to use void main with the program and take out the getch()s but then i cant see the program at all, it just comes up for like a second then goes off..i cant enter anything in. so i usually add getch()s to pause my program(and they usually work) but this one isnt working for some reason.

You can this programme as under:

Code:

---

#include <stdio.h>
#include <conio.h>

void main()
{
    char name[10];
    printf("Please enter your name: ");
    scanf("%s", name);
    printf("Hello %s!", name);
    getch();
}

---

Anu

ehh....its still doing the same thing : \

you haven't read the FAQ?

go to Start > Run and type cmd.exe. then enter your exe's path in command prompt (surround path with double quotes if there are any spaces).

> #include <conio.h>
Get rid of this include, you don't need it.

> getch();
> scanf("%s", name);
Never mix input methods, especially standard with non-standard ones.
If you need to get a single char, use getchar().
But as others have said, see the FAQ first.

Code:

---

#include <stdio.h>
#include <string.h>

int main()
{
    char name[10];

    printf("Please enter your name.\n");
    scanf("%s", name);
    printf("Hello %s!\n", name);
    printf("Press any key to continue\n");
    while (getchar() != '\n')
    getchar()
    return 0;
}

---

This should make the program do what you want. Dont forget main has to return a value.

Quote:

---

Originally Posted by jlharrison

Code:

---

#include <stdio.h>
#include <string.h>

int main()
{
    char name[10];

    printf("Please enter your name.\n");
    scanf("%s", name);
    printf("Hello %s!\n", name);
    printf("Press any key to continue\n");
    while (getchar() != '\n')
    getchar()
    return 0;
}

---

This should make the program do what you want. Dont forget main has to return a value.

---

You have a missing semicolon, but further, the

Code:

---

while (getchar() != '\n')
{
    getchar();
}

---

(reformatted for your reading pleasure) both doesn't do what the prompt ("Press any key to continue") says it should (it only exits on return), it also reads two characters each time through, so if the user types "<space><cr>", it will not recognize that as <cr>.

I'm not saying that I think that the use of getchar() is good in general, but if you're going to use it, use it correctly.

You absolutly right. I am a noob and should have kept my mouth shut!

Quote:

---

Originally Posted by jlharrison

You absolutly right. I am a noob and should have kept my mouth shut!

---

Not at all. This is a place to learn, and you certainly don't have to be perfect before you post. Just learn from your mistakes and soldier on :)

Quote:

---

Originally Posted by jlharrison

You absolutly right. I am a noob and should have kept my mouth shut!

---

As eerok said, you should not silence yourself just because you're not an expert yet. I had not intended to impune you as a person -- you'll only learn by doing, and if you're afraid to make a mistake, you learn very slowly.

I'm sorry if the tone of my post seemed overly critical.