fault with code but unsure where!

hi everyone
ive just made a little program that uses structures, and memory allocation
the program comes up with a error message saying 'segmentation fault'
i think this is because there is a bug in the memory allocation part of the program but im not sure

Code:

---

#include <stdio.h>
#include <string.h>
#include <stdlib.h>
#include "simpleio.h"

struct book
{
    char *author;
    char *name;
}copy1;
struct book copy2;

int main()
{
    copy1.author=malloc (*copy1.author * sizeof (char));
    copy1.name=malloc (*copy1.name * sizeof (char));
    printf("please enter the authors name and the name of the title\n");
    gets(copy1.author);
    gets(copy1.name);
   
    copy2.author = copy1.author;
    copy2.name = copy1.name;
    free(copy1.author);
    free(copy1.name);
   
    printf("your book %s by %s is on its way in the post\n", copy2.name, copy2.author);
    return 0;
}

---

thanks in advance

You need to figure out how much memory you'll need to allocate at runtime using malloc(), at runtime.

This bit is nonsense.

Code:

---

  copy1.author=malloc (*copy1.author * sizeof (char));
  copy1.name=malloc (*copy1.name * sizeof (char));

---

Also, don't use gets(). Google why it's the Devil and what you can do about it.

sizeof (char)

that's one byte, you may want more...

ive used fgets but you need three input variables to make it work so that was out the question for me and i know about its 'crash' issues and its vulnerabilities
thanks for the replies but i already know there is a problem im just not sure how to fix it...

Quote:

---

Originally Posted by aadil7

ive used fgets but you need three input variables to make it work

---

I'm not sure what you think this means. You need to give fgets three parameters, but you don't need three input variables. You call fgets with (1) where you want the input to go (2) how much input you want (3) where you want it from.

1st of all could you let us know where and when you get the error, secondly......

Quote:

---

Originally Posted by msh

You need to figure out how much memory you'll need to allocate at runtime using malloc(), at runtime.

This bit is nonsense.

Code:

---

  copy1.author=malloc (*copy1.author * sizeof (char));
  copy1.name=malloc (*copy1.name * sizeof (char));

---

---

is right. Re-check your memory allocation.
malloc

Closed by request.