Help About a simple calculator pls!!

hello all!! I really need a little help! My problem is that I am writing a simple calculator which is actually my homework and it must do calculation like 2*4+5 is 13..that is there is no precedence..But I dont know how I can write +5 after first equ( 2*4)..My program just gives 8 as a result..Pls help me!! what ı wrote::

Code:

---

    int main(){
    int a,b,sum,c;
    char ch;
    printf("enter your application\n");
    scanf("%d%c%d",&a,&ch,&b);
    while(ch!='!' ){
        if(ch=='+')
        sum=a+b;
        if(ch=='-')
        sum=a-b;
        if(ch=='/')
        sum=a/b;
        if(ch=='*')
        sum=a*b;
     
        scanf("%c%d",&ch,&c); 
            printf("%d",sum);
    anykey();
    return 0;
}

---

Read the first int, then everything after that is 'operation' and 'operand' pairs.

Why don't you assign sum = a before the while() loop? Then you can keep a running total each time through the loop:

Code:

---

        if(ch=='+')
            sum += b;
        if(ch=='-')
            sum -= b;
        if(ch=='/')
            sum /= b;
        if(ch=='*')
            sum *= b;

---

Code:

---

        if(ch=='+')
            sum += b;
        if(ch=='-')
            sum -= b;
        if(ch=='/')
            sum /= b;
        if(ch=='*')
            sum *= b;

---

Consider this. If you want an addition ( the first if ); the others if are still going to be checked for truthfulness. If else or switch are better alternatives.

Are you also considering in your program when the input of the user is not a single digit? what if it isdouble digit or more?

Quote:

---

Originally Posted by aaron_88

hello all!! I really need a little help! My problem is that I am writing a simple calculator which is actually my homework and it must do calculation like 2*4+5 is 13..that is there is no precedence..But I dont know how I can write +5 after first equ( 2*4)..My program just gives 8 as a result..Pls help me!! what ı wrote::

Code:

---

    int main(){
    int a,b,sum,c;
    char ch;
    printf("enter your application\n");
    scanf("%d%c%d",&a,&ch,&b);
    while(ch!='!' ){
        if(ch=='+')
          sum=a+b;
        if(ch=='-')
          sum=a-b;
        if(ch=='/')
          sum=a/b;
        if(ch=='*')
          sum=a*b;
     
        scanf("%c%d",&ch,&c); 
            printf("%d",sum);
    } /* maybe here? */
    anykey();
    return 0;
}

---

---

I've highlighted the curly brace problem (a typo I suspect).
Your program logic doesn't DO anything if int c is added in. It just prints up the same sum
it had before. :(

Consider a switch instead of that if.

I would probably read the entire line in, and just increment through it until you find a +,-,/,* sign then take everything before that as number1. Store the sign. Read to the next sign(to get number2), do your math and store that as number1. Repeat.