If Statements? What’s wrong with it?

I’ve done an if statement before in a previous program but it was numbers …

Code:

---

void process()
{
    total=float(miles_after - miles_before)*0.42f;
    if (total>=1000);
    {
    total=total+10.84;
    }

}

---

But now I’m trying to do it with text and it doesn’t seem to be working. When I run the program the text appears weather my statement is true or flase.

Code:

---

void output()
{
    printf("Your new balance is %2.f\n",updated_current);
    if(updated_current<0);
    {
    printf("We would like to make you aware you have entered your over draft.");
    }
}

---

Help much appreciated!

Chris

Lose the semi-colon:

Code:

---

if(updated_current<0);

---

Quote:

---

Originally Posted by rags_to_riches

Lose the semi-colon:

Code:

---

if(updated_current<0);

---

---

Simple as that ...

I find sometimes thats all you need someone else to spot the silly mistakes. Thanks man :D

If you indented like this:

Code:

---

void output() {
    printf("Your new balance is %2.f\n",updated_current);
    if(updated_current<0)  {
          printf("We would like to make you aware you have entered your over draft.");
    }
}

---

Instead of like this:

Code:

---

void output()
{
    printf("Your new balance is %2.f\n",updated_current);
    if(updated_current<0);
    {
    printf("We would like to make you aware you have entered your over draft.");
    }
}

---

Mistakes like that will be harder to make, easier to spot, AND your code will be more readable for everyone including yourself! If you want to add whitespace, use a blank line instead of placing { by itself -- which will usually be the least appropriate place for more whitespace anyway.

It is possible to do it this way, too:

Code:

---

void output()
{
    printf("Your new balance is %2.f\n", updated_current);
    if (updated_current < 0)
    {
          printf("We would like to make you aware you have entered your over draft.");
    }
}

---

Or even

Code:

---

void output()
{
    printf("Your new balance is %2.f\n", updated_current);
    if (updated_current < 0)
          printf("We would like to make you aware you have entered your over draft.");
}

---

Also, I'd like to say: lose the globals. Pass by arguments instead. It makes debugging much easier.